Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky multi/TestDisconnectAll #234

Closed
oleg-jukovec opened this issue Nov 24, 2022 · 0 comments · Fixed by #255
Closed

Flaky multi/TestDisconnectAll #234

oleg-jukovec opened this issue Nov 24, 2022 · 0 comments · Fixed by #255
Assignees
@oleg-jukovec
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@oleg-jukovec
Copy link
Collaborator

oleg-jukovec commented Nov 24, 2022 •
edited
Loading

Sometimes the test fails on CI:

2022-11-24T14:32:39.7482366Z --- FAIL: TestDisconnectAll (0.40s)
2022-11-24T14:32:39.7500147Z     multi_test.go:136: incorrect status after desconnect all
@oleg-jukovec oleg-jukovec added 1sp bug Something isn't working good first issue Good for newcomers labels Nov 24, 2022
@oleg-jukovec oleg-jukovec self-assigned this Dec 27, 2022
oleg-jukovec added a commit that referenced this issue Dec 27, 2022
@oleg-jukovec
bugfix: flaky multi/TestDisconnectAll
272a347 
After the fix the test stops tarantool intances to avoid concurrent
reconnects by a ConnectionMulti instance.

Closes #234
@oleg-jukovec oleg-jukovec mentioned this issue Dec 27, 2022
Merged
2 tasks
oleg-jukovec added a commit that referenced this issue Dec 28, 2022
@oleg-jukovec
bugfix: flaky multi/TestDisconnectAll
11c3438 
After the fix the test stops tarantool intances to avoid concurrent
reconnects by a ConnectionMulti instance.

Closes #234
oleg-jukovec added a commit that referenced this issue Dec 28, 2022
@oleg-jukovec
bugfix: flaky multi/TestDisconnectAll
b0956f3 
After the fix the test stops tarantool intances to avoid concurrent
reconnects by a ConnectionMulti instance.

Closes #234
oleg-jukovec added a commit that referenced this issue Dec 28, 2022
@oleg-jukovec
Release 1.10.0
5aca571 
Overview

    The release improves compatibility with new Tarantool versions.

Breaking changes

    There are no breaking changes in the release.

New features

    Support iproto feature discovery (#120).

    Support errors extended information (#209).

    Support error type in MessagePack (#209).

    Support event subscriptin (#119).

    Support session settings (#215).

    Support pap-sha256 authorization method (Tarantool EE
    feature) (#243).

    Support graceful shutdown (#214).

Bugfixes

    Decimal package uses a test variable DecimalPrecision instead
    of a package-level variable decimalPrecision (#233).

    Flaky test TestClientRequestObjectsWithContext (#244).

    Flaky test multi/TestDisconnectAll (#234).
@oleg-jukovec oleg-jukovec mentioned this issue Dec 28, 2022
Merged
oleg-jukovec added a commit that referenced this issue Dec 29, 2022
@oleg-jukovec
Release 1.10.0
a8da132 
Overview

    The release improves compatibility with new Tarantool versions.

Breaking changes

    There are no breaking changes in the release.

New features

    Support iproto feature discovery (#120).

    Support errors extended information (#209).

    Support error type in MessagePack (#209).

    Support event subscription (#119).

    Support session settings (#215).

    Support pap-sha256 authorization method (Tarantool EE
    feature) (#243).

    Support graceful shutdown (#214).

Bugfixes

    Decimal package uses a test variable DecimalPrecision instead
    of a package-level variable decimalPrecision (#233).

    Flaky test TestClientRequestObjectsWithContext (#244).

    Flaky test multi/TestDisconnectAll (#234).
oleg-jukovec added a commit that referenced this issue Dec 30, 2022
@oleg-jukovec
Release 1.10.0
0f59c42 
Overview

    The release improves compatibility with new Tarantool versions.

Breaking changes

    There are no breaking changes in the release.

New features

    Support iproto feature discovery (#120).

    Support errors extended information (#209).

    Support error type in MessagePack (#209).

    Support event subscription (#119).

    Support session settings (#215).

    Support pap-sha256 authorization method (Tarantool EE
    feature) (#243).

    Support graceful shutdown (#214).

Bugfixes

    Decimal package uses a test variable DecimalPrecision instead
    of a package-level variable decimalPrecision (#233).

    Flaky test TestClientRequestObjectsWithContext (#244).

    Flaky test multi/TestDisconnectAll (#234).
pull bot pushed a commit to kokizzu/go-tarantool that referenced this issue Jan 1, 2023
@oleg-jukovec
Release 1.10.0
0ffd926 
Overview

    The release improves compatibility with new Tarantool versions.

Breaking changes

    There are no breaking changes in the release.

New features

    Support iproto feature discovery (tarantool#120).

    Support errors extended information (tarantool#209).

    Support error type in MessagePack (tarantool#209).

    Support event subscription (tarantool#119).

    Support session settings (tarantool#215).

    Support pap-sha256 authorization method (Tarantool EE
    feature) (tarantool#243).

    Support graceful shutdown (tarantool#214).

Bugfixes

    Decimal package uses a test variable DecimalPrecision instead
    of a package-level variable decimalPrecision (tarantool#233).

    Flaky test TestClientRequestObjectsWithContext (tarantool#244).

    Flaky test multi/TestDisconnectAll (tarantool#234).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleg-jukovec oleg-jukovec

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bugfix: flaky multi/TestDisconnectAll tarantool/go-tarantool
1 participant
@oleg-jukovec