Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support graceful shutdown #214

Closed
oleg-jukovec opened this issue Sep 14, 2022 · 5 comments · Fixed by #249
Closed

Support graceful shutdown #214

oleg-jukovec opened this issue Sep 14, 2022 · 5 comments · Fixed by #249
Assignees
@DifferentialOrange
Labels
feature A new functionality

Comments

@oleg-jukovec
Copy link
Collaborator

The graceful shutdown protocol is a mechanism that helps to prevent data loss in requests in case of a shutdown command.

https://www.tarantool.io/en/doc/latest/dev_guide/internals/box_protocol/#graceful-shutdown-protocol
@oleg-jukovec oleg-jukovec added teamE feature A new functionality labels Sep 14, 2022
@R-omk
Copy link

R-omk commented Sep 14, 2022

#119 this should be implemented first.

Details tarantool/doc#2633

@ice-ares
Copy link

what about supporting graceful shutdown from the client? Especially in the connection pool. I.E. client called .Close() or context cancelled, but we still have pending requests

@oleg-jukovec
Copy link
Collaborator Author

This is planned to be done by 2023. Perhaps it will be ready this month.

@DifferentialOrange DifferentialOrange mentioned this issue Dec 16, 2022
Merged
3 tasks
DifferentialOrange added a commit that referenced this issue Dec 16, 2022
@DifferentialOrange
code health: reuse Retry in test helpers
492215f 
Part of #214
DifferentialOrange added a commit that referenced this issue Dec 16, 2022
@DifferentialOrange
make: clean cache for test
10fb45b 
After this patch, "make test" behaves similar to "make test-*".

Part of #214
DifferentialOrange added a commit that referenced this issue Dec 16, 2022
@DifferentialOrange
feature: support graceful shutdown
5d2a7f0 
If connected to Tarantool 2.10 or newer and WatchersFeature is required,
after this patch connection supports server graceful shutdown [1]. In
this case, server will wait until all client requests will be finished
and client disconnects before going down (server also may go down by
timeout). Client reconnect will happen if connection options enable
reconnect.

1. https://www.tarantool.io/en/doc/latest/dev_guide/internals/iproto/graceful_shutdown/

Closes #214
DifferentialOrange added a commit that referenced this issue Dec 16, 2022
@DifferentialOrange
code health: reuse Retry in test helpers
5f81bea 
Part of #214
DifferentialOrange added a commit that referenced this issue Dec 16, 2022
@DifferentialOrange
make: clean cache for test
609b5b1 
After this patch, "make test" behaves similar to "make test-*".

Part of #214
DifferentialOrange added a commit that referenced this issue Dec 16, 2022
@DifferentialOrange
feature: support graceful shutdown
78d67b5 
If connected to Tarantool 2.10 or newer and WatchersFeature is required,
after this patch connection supports server graceful shutdown [1]. In
this case, server will wait until all client requests will be finished
and client disconnects before going down (server also may go down by
timeout). Client reconnect will happen if connection options enable
reconnect.

1. https://www.tarantool.io/en/doc/latest/dev_guide/internals/iproto/graceful_shutdown/

Closes #214
DifferentialOrange added a commit that referenced this issue Dec 16, 2022
@DifferentialOrange
code health: reuse Retry in test helpers
3b29b84 
Part of #214
DifferentialOrange added a commit that referenced this issue Dec 16, 2022
@DifferentialOrange
make: clean cache for test
b93df00 
After this patch, "make test" behaves similar to "make test-*".

Part of #214
DifferentialOrange added a commit that referenced this issue Dec 16, 2022
@DifferentialOrange
feature: support graceful shutdown
cca3f97 
If connected to Tarantool 2.10 or newer and WatchersFeature is required,
after this patch connection supports server graceful shutdown [1]. In
this case, server will wait until all client requests will be finished
and client disconnects before going down (server also may go down by
timeout). Client reconnect will happen if connection options enable
reconnect.

1. https://www.tarantool.io/en/doc/latest/dev_guide/internals/iproto/graceful_shutdown/

Closes #214
DifferentialOrange added a commit that referenced this issue Dec 16, 2022
@DifferentialOrange
feature: support graceful shutdown
637be3b 
If connected to Tarantool 2.10 or newer and WatchersFeature is required,
after this patch connection supports server graceful shutdown [1]. In
this case, server will wait until all client requests will be finished
and client disconnects before going down (server also may go down by
timeout). Client reconnect will happen if connection options enable
reconnect.

1. https://www.tarantool.io/en/doc/latest/dev_guide/internals/iproto/graceful_shutdown/

Closes #214
DifferentialOrange added a commit that referenced this issue Dec 16, 2022
@DifferentialOrange
feature: support graceful shutdown
d8b8196 
If connected to Tarantool 2.10 or newer and WatchersFeature is required,
after this patch connection supports server graceful shutdown [1]. In
this case, server will wait until all client requests will be finished
and client disconnects before going down (server also may go down by
timeout). Client reconnect will happen if connection options enable
reconnect.

1. https://www.tarantool.io/en/doc/latest/dev_guide/internals/iproto/graceful_shutdown/

Closes #214
DifferentialOrange added a commit that referenced this issue Dec 20, 2022
@DifferentialOrange
feature: support graceful shutdown
68719cb 
If connected to Tarantool 2.10 or newer and WatchersFeature is required,
after this patch connection supports server graceful shutdown [1]. In
this case, server will wait until all client requests will be finished
and client disconnects before going down (server also may go down by
timeout). Client reconnect will happen if connection options enable
reconnect.

1. https://www.tarantool.io/en/doc/latest/dev_guide/internals/iproto/graceful_shutdown/

Closes #214
DifferentialOrange added a commit that referenced this issue Dec 20, 2022
@DifferentialOrange
feature: support graceful shutdown
47f524a 
If connected to Tarantool 2.10 or newer and WatchersFeature is required,
after this patch connection supports server graceful shutdown [1]. In
this case, server will wait until all client requests will be finished
and client disconnects before going down (server also may go down by
timeout). Client reconnect will happen if connection options enable
reconnect.

1. https://www.tarantool.io/en/doc/latest/dev_guide/internals/iproto/graceful_shutdown/

Closes #214
DifferentialOrange added a commit that referenced this issue Dec 21, 2022
@DifferentialOrange
feature: support graceful shutdown
f7d3f4e 
If connected to Tarantool 2.10 or newer and WatchersFeature is required,
after this patch connection supports server graceful shutdown [1]. In
this case, server will wait until all client requests will be finished
and client disconnects before going down (server also may go down by
timeout). Client reconnect will happen if connection options enable
reconnect.

1. https://www.tarantool.io/en/doc/latest/dev_guide/internals/iproto/graceful_shutdown/

Closes #214
DifferentialOrange added a commit that referenced this issue Dec 21, 2022
@DifferentialOrange
feature: support graceful shutdown
4760c32 
If connected to Tarantool 2.10 or newer and WatchersFeature is required,
after this patch connection supports server graceful shutdown [1]. In
this case, server will wait until all client requests will be finished
and client disconnects before going down (server also may go down by
timeout). Client reconnect will happen if connection options enable
reconnect.

1. https://www.tarantool.io/en/doc/latest/dev_guide/internals/iproto/graceful_shutdown/

Closes #214
DifferentialOrange added a commit that referenced this issue Dec 21, 2022
@DifferentialOrange
feature: support graceful shutdown
cd918fb 
If connected to Tarantool 2.10 or newer and WatchersFeature is required,
after this patch connection supports server graceful shutdown [1]. In
this case, server will wait until all client requests will be finished
and client disconnects before going down (server also may go down by
timeout). Client reconnect will happen if connection options enable
reconnect.

1. https://www.tarantool.io/en/doc/latest/dev_guide/internals/iproto/graceful_shutdown/

Closes #214
DifferentialOrange added a commit that referenced this issue Dec 21, 2022
@DifferentialOrange
feature: support graceful shutdown
10e7657 
If connected to Tarantool 2.10 or newer and WatchersFeature is required,
after this patch connection supports server graceful shutdown [1]. In
this case, server will wait until all client requests will be finished
and client disconnects before going down (server also may go down by
timeout). Client reconnect will happen if connection options enable
reconnect.

1. https://www.tarantool.io/en/doc/latest/dev_guide/internals/iproto/graceful_shutdown/

Closes #214
DifferentialOrange added a commit that referenced this issue Dec 21, 2022
@DifferentialOrange
feature: support graceful shutdown
ebc323c 
If connected to Tarantool 2.10 or newer and WatchersFeature is required,
after this patch connection supports server graceful shutdown [1]. In
this case, server will wait until all client requests will be finished
and client disconnects before going down (server also may go down by
timeout). Client reconnect will happen if connection options enable
reconnect.

1. https://www.tarantool.io/en/doc/latest/dev_guide/internals/iproto/graceful_shutdown/

Closes #214
DifferentialOrange added a commit that referenced this issue Dec 21, 2022
@DifferentialOrange
feature: support graceful shutdown
c43e268 
If connected to Tarantool 2.10 or newer and WatchersFeature is required,
after this patch connection supports server graceful shutdown [1]. In
this case, server will wait until all client requests will be finished
and client disconnects before going down (server also may go down by
timeout). Client reconnect will happen if connection options enable
reconnect.

1. https://www.tarantool.io/en/doc/latest/dev_guide/internals/iproto/graceful_shutdown/

Closes #214
DifferentialOrange added a commit that referenced this issue Dec 21, 2022
@DifferentialOrange
code health: reuse Retry in test helpers
ba6cbce 
Part of #214
DifferentialOrange added a commit that referenced this issue Dec 21, 2022
@DifferentialOrange
make: clean cache for test
cb26a63 
After this patch, "make test" behaves similar to "make test-*".

Part of #214
DifferentialOrange added a commit that referenced this issue Dec 21, 2022
@DifferentialOrange
feature: support graceful shutdown
e1a5390 
If connected to Tarantool 2.10 or newer and WatchersFeature is required,
after this patch connection supports server graceful shutdown [1]. In
this case, server will wait until all client requests will be finished
and client disconnects before going down (server also may go down by
timeout). Client reconnect will happen if connection options enable
reconnect.

1. https://www.tarantool.io/en/doc/latest/dev_guide/internals/iproto/graceful_shutdown/

Closes #214
DifferentialOrange added a commit that referenced this issue Dec 21, 2022
@DifferentialOrange
bug: fix lock on pool watcher Unregister
c956e11 
Fix was provided by @oleg-jukovec

Part of #214
DifferentialOrange added a commit that referenced this issue Dec 21, 2022
@DifferentialOrange
feature: support graceful shutdown
1d71195 
If connected to Tarantool 2.10 or newer and WatchersFeature is required,
after this patch connection supports server graceful shutdown [1]. In
this case, server will wait until all client requests will be finished
and client disconnects before going down (server also may go down by
timeout). Client reconnect will happen if connection options enable
reconnect. Beware that graceful shutdown event initialization is
asynchronous.

1. https://www.tarantool.io/en/doc/latest/dev_guide/internals/iproto/graceful_shutdown/

Closes #214
DifferentialOrange added a commit that referenced this issue Dec 21, 2022
@DifferentialOrange
bug: fix lock on pool watcher Unregister
2faaa7d 
Fix was provided by @oleg-jukovec

Part of #214
DifferentialOrange added a commit that referenced this issue Dec 21, 2022
@DifferentialOrange
feature: support graceful shutdown
aac4200 
If connected to Tarantool 2.10 or newer and WatchersFeature is required,
after this patch connection supports server graceful shutdown [1]. In
this case, server will wait until all client requests will be finished
and client disconnects before going down (server also may go down by
timeout). Client reconnect will happen if connection options enable
reconnect. Beware that graceful shutdown event initialization is
asynchronous.

1. https://www.tarantool.io/en/doc/latest/dev_guide/internals/iproto/graceful_shutdown/

Closes #214
DifferentialOrange added a commit that referenced this issue Dec 25, 2022
@DifferentialOrange
feature: support graceful shutdown
14eb7e7 
If connected to Tarantool 2.10 or newer and WatchersFeature is required,
after this patch connection supports server graceful shutdown [1]. In
this case, server will wait until all client requests will be finished
and client disconnects before going down (server also may go down by
timeout). Client reconnect will happen if connection options enable
reconnect. Beware that graceful shutdown event initialization is
asynchronous.

1. https://www.tarantool.io/en/doc/latest/dev_guide/internals/iproto/graceful_shutdown/

Closes #214
DifferentialOrange added a commit that referenced this issue Dec 25, 2022
@DifferentialOrange
feature: support graceful shutdown
fe07889 
If connected to Tarantool 2.10 or newer, after this patch a connection
supports server graceful shutdown [1]. In this case, server will wait
until all client requests will be finished and client disconnects before
going down (server also may go down by timeout). Client reconnect will
happen if connection options enable reconnect. Beware that graceful
shutdown event initialization is asynchronous.

1. https://www.tarantool.io/en/doc/latest/dev_guide/internals/iproto/graceful_shutdown/

Closes #214
DifferentialOrange added a commit that referenced this issue Dec 26, 2022
@DifferentialOrange
feature: support graceful shutdown
2f2d4a9 
If connected to Tarantool 2.10 or newer, after this patch a connection
supports server graceful shutdown [1]. In this case, server will wait
until all client requests will be finished and client disconnects before
going down (server also may go down by timeout). Client reconnect will
happen if connection options enable reconnect. Beware that graceful
shutdown event initialization is asynchronous.

1. https://www.tarantool.io/en/doc/latest/dev_guide/internals/iproto/graceful_shutdown/

Closes #214
oleg-jukovec pushed a commit that referenced this issue Dec 28, 2022
@DifferentialOrange @oleg-jukovec
code health: reuse Retry in test helpers
5f9eed5 
Part of #214
oleg-jukovec pushed a commit that referenced this issue Dec 28, 2022
@DifferentialOrange @oleg-jukovec
make: clean cache for test
decb45f 
After this patch, "make test" behaves similar to "make test-*".

Part of #214
oleg-jukovec pushed a commit that referenced this issue Dec 28, 2022
@DifferentialOrange @oleg-jukovec
feature: support graceful shutdown
4eb8ac8 
If connected to Tarantool 2.10 or newer, after this patch a connection
supports server graceful shutdown [1]. In this case, server will wait
until all client requests will be finished and client disconnects before
going down (server also may go down by timeout). Client reconnect will
happen if connection options enable reconnect. Beware that graceful
shutdown event initialization is asynchronous.

1. https://www.tarantool.io/en/doc/latest/dev_guide/internals/iproto/graceful_shutdown/

Closes #214
oleg-jukovec pushed a commit that referenced this issue Dec 28, 2022
@DifferentialOrange @oleg-jukovec
code health: reuse Retry in test helpers
f4f47ae 
Part of #214
oleg-jukovec pushed a commit that referenced this issue Dec 28, 2022
@DifferentialOrange @oleg-jukovec
make: clean cache for test
afce61b 
After this patch, "make test" behaves similar to "make test-*".

Part of #214
oleg-jukovec pushed a commit that referenced this issue Dec 28, 2022
@DifferentialOrange @oleg-jukovec
feature: support graceful shutdown
13b9f8e 
If connected to Tarantool 2.10 or newer, after this patch a connection
supports server graceful shutdown [1]. In this case, server will wait
until all client requests will be finished and client disconnects before
going down (server also may go down by timeout). Client reconnect will
happen if connection options enable reconnect. Beware that graceful
shutdown event initialization is asynchronous.

1. https://www.tarantool.io/en/doc/latest/dev_guide/internals/iproto/graceful_shutdown/

Closes #214
oleg-jukovec added a commit that referenced this issue Dec 28, 2022
@oleg-jukovec
Release 1.10.0
5aca571 
Overview

    The release improves compatibility with new Tarantool versions.

Breaking changes

    There are no breaking changes in the release.

New features

    Support iproto feature discovery (#120).

    Support errors extended information (#209).

    Support error type in MessagePack (#209).

    Support event subscriptin (#119).

    Support session settings (#215).

    Support pap-sha256 authorization method (Tarantool EE
    feature) (#243).

    Support graceful shutdown (#214).

Bugfixes

    Decimal package uses a test variable DecimalPrecision instead
    of a package-level variable decimalPrecision (#233).

    Flaky test TestClientRequestObjectsWithContext (#244).

    Flaky test multi/TestDisconnectAll (#234).
@oleg-jukovec oleg-jukovec mentioned this issue Dec 28, 2022
Merged
@ice-ares
Copy link

what about supporting graceful shutdown from the client? Especially in the connection pool. I.E. client called .Close() or context cancelled, but we still have pending requests

@oleg-jukovec what about that?

@oleg-jukovec oleg-jukovec mentioned this issue Dec 28, 2022
Closed
@oleg-jukovec
Copy link
Collaborator Author

oleg-jukovec commented Dec 28, 2022 •
edited
Loading

What about supporting graceful shutdown from the client?

Unfortunately, this is not in the product plan. First of all, because the request counter can be implemented on the client side.
Right now we are focused on features that cannot be done on the client side.

Especially in the connection pool. I.E. client called .Close()

I have opened a new issue:
#257

or context cancelled

This is a limitation of the IPHOTO protocol. We cannot cancel a request that has already been sent over network.
Therefore, if the request has already been sent, it is canceled only at the Go-language level.

oleg-jukovec added a commit that referenced this issue Dec 29, 2022
@oleg-jukovec
Release 1.10.0
a8da132 
Overview

    The release improves compatibility with new Tarantool versions.

Breaking changes

    There are no breaking changes in the release.

New features

    Support iproto feature discovery (#120).

    Support errors extended information (#209).

    Support error type in MessagePack (#209).

    Support event subscription (#119).

    Support session settings (#215).

    Support pap-sha256 authorization method (Tarantool EE
    feature) (#243).

    Support graceful shutdown (#214).

Bugfixes

    Decimal package uses a test variable DecimalPrecision instead
    of a package-level variable decimalPrecision (#233).

    Flaky test TestClientRequestObjectsWithContext (#244).

    Flaky test multi/TestDisconnectAll (#234).
oleg-jukovec added a commit that referenced this issue Dec 30, 2022
@oleg-jukovec
Release 1.10.0
0f59c42 
Overview

    The release improves compatibility with new Tarantool versions.

Breaking changes

    There are no breaking changes in the release.

New features

    Support iproto feature discovery (#120).

    Support errors extended information (#209).

    Support error type in MessagePack (#209).

    Support event subscription (#119).

    Support session settings (#215).

    Support pap-sha256 authorization method (Tarantool EE
    feature) (#243).

    Support graceful shutdown (#214).

Bugfixes

    Decimal package uses a test variable DecimalPrecision instead
    of a package-level variable decimalPrecision (#233).

    Flaky test TestClientRequestObjectsWithContext (#244).

    Flaky test multi/TestDisconnectAll (#234).
pull bot pushed a commit to kokizzu/go-tarantool that referenced this issue Jan 1, 2023
@oleg-jukovec
Release 1.10.0
0ffd926 
Overview

    The release improves compatibility with new Tarantool versions.

Breaking changes

    There are no breaking changes in the release.

New features

    Support iproto feature discovery (tarantool#120).

    Support errors extended information (tarantool#209).

    Support error type in MessagePack (tarantool#209).

    Support event subscription (tarantool#119).

    Support session settings (tarantool#215).

    Support pap-sha256 authorization method (Tarantool EE
    feature) (tarantool#243).

    Support graceful shutdown (tarantool#214).

Bugfixes

    Decimal package uses a test variable DecimalPrecision instead
    of a package-level variable decimalPrecision (tarantool#233).

    Flaky test TestClientRequestObjectsWithContext (tarantool#244).

    Flaky test multi/TestDisconnectAll (tarantool#234).
oleg-jukovec added a commit to tarantool/doc that referenced this issue Jan 13, 2023
@oleg-jukovec
Update go connectors comparison table
3d652b2 
Follows up tarantool/go-tarantool#209
Follows up tarantool/go-tarantool#214
Follows up tarantool/go-tarantool#215
Follows up tarantool/go-tarantool#246
@oleg-jukovec oleg-jukovec mentioned this issue Jan 13, 2023
Merged
oleg-jukovec added a commit to tarantool/doc that referenced this issue Jan 13, 2023
@oleg-jukovec
Update go connectors comparison table
80b5cb8 
Follows up tarantool/go-tarantool#119
Follows up tarantool/go-tarantool#120
Follows up tarantool/go-tarantool#209
Follows up tarantool/go-tarantool#214
Follows up tarantool/go-tarantool#215
Follows up tarantool/go-tarantool#246
veod32 pushed a commit to tarantool/doc that referenced this issue Mar 14, 2023
@oleg-jukovec
Update the comparison table on Go connectors
ba3dee4 
Follows up tarantool/go-tarantool#119
Follows up tarantool/go-tarantool#120
Follows up tarantool/go-tarantool#209
Follows up tarantool/go-tarantool#214
Follows up tarantool/go-tarantool#215
Follows up tarantool/go-tarantool#246
@oleg-jukovec oleg-jukovec mentioned this issue Mar 14, 2023
Closed
1 task
p7nov pushed a commit to tarantool/doc that referenced this issue Mar 24, 2023
@oleg-jukovec @p7nov
Update the comparison table on Go connectors
9a81527 
Follows up tarantool/go-tarantool#119
Follows up tarantool/go-tarantool#120
Follows up tarantool/go-tarantool#209
Follows up tarantool/go-tarantool#214
Follows up tarantool/go-tarantool#215
Follows up tarantool/go-tarantool#246
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DifferentialOrange DifferentialOrange

Labels
feature A new functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Graceful shutdown tarantool/go-tarantool
4 participants
@R-omk @DifferentialOrange @oleg-jukovec @ice-ares