bugfix: decimal uses a test variable #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d34ef40 to
620edb3
Compare
620edb3 to
9262f6b
Compare
To be honest, I don't have any ideas =) I just noticed the problem. |
DifferentialOrange
approved these changes
Nov 21, 2022
9262f6b to
a652a7c
Compare
The patch replaces usage of a test variable DecimalPrecision by a package-level variable decimalPrecision in the decimal package code.
a652a7c to
8c526f0
Compare
better0fdead
approved these changes
Nov 24, 2022
oleg-jukovec
added a commit
that referenced
this pull request
Dec 28, 2022
Overview
The release improves compatibility with new Tarantool versions.
Breaking changes
There are no breaking changes in the release.
New features
Support iproto feature discovery (#120).
Support errors extended information (#209).
Support error type in MessagePack (#209).
Support event subscriptin (#119).
Support session settings (#215).
Support pap-sha256 authorization method (Tarantool EE
feature) (#243).
Support graceful shutdown (#214).
Bugfixes
Decimal package uses a test variable DecimalPrecision instead
of a package-level variable decimalPrecision (#233).
Flaky test TestClientRequestObjectsWithContext (#244).
Flaky test multi/TestDisconnectAll (#234).
Merged
oleg-jukovec
added a commit
that referenced
this pull request
Dec 29, 2022
Overview
The release improves compatibility with new Tarantool versions.
Breaking changes
There are no breaking changes in the release.
New features
Support iproto feature discovery (#120).
Support errors extended information (#209).
Support error type in MessagePack (#209).
Support event subscription (#119).
Support session settings (#215).
Support pap-sha256 authorization method (Tarantool EE
feature) (#243).
Support graceful shutdown (#214).
Bugfixes
Decimal package uses a test variable DecimalPrecision instead
of a package-level variable decimalPrecision (#233).
Flaky test TestClientRequestObjectsWithContext (#244).
Flaky test multi/TestDisconnectAll (#234).
oleg-jukovec
added a commit
that referenced
this pull request
Dec 30, 2022
Overview
The release improves compatibility with new Tarantool versions.
Breaking changes
There are no breaking changes in the release.
New features
Support iproto feature discovery (#120).
Support errors extended information (#209).
Support error type in MessagePack (#209).
Support event subscription (#119).
Support session settings (#215).
Support pap-sha256 authorization method (Tarantool EE
feature) (#243).
Support graceful shutdown (#214).
Bugfixes
Decimal package uses a test variable DecimalPrecision instead
of a package-level variable decimalPrecision (#233).
Flaky test TestClientRequestObjectsWithContext (#244).
Flaky test multi/TestDisconnectAll (#234).
pull bot
pushed a commit
to kokizzu/go-tarantool
that referenced
this pull request
Jan 1, 2023
Overview
The release improves compatibility with new Tarantool versions.
Breaking changes
There are no breaking changes in the release.
New features
Support iproto feature discovery (tarantool#120).
Support errors extended information (tarantool#209).
Support error type in MessagePack (tarantool#209).
Support event subscription (tarantool#119).
Support session settings (tarantool#215).
Support pap-sha256 authorization method (Tarantool EE
feature) (tarantool#243).
Support graceful shutdown (tarantool#214).
Bugfixes
Decimal package uses a test variable DecimalPrecision instead
of a package-level variable decimalPrecision (tarantool#233).
Flaky test TestClientRequestObjectsWithContext (tarantool#244).
Flaky test multi/TestDisconnectAll (tarantool#234).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch replaces usage of a test variable DecimalPrecision by a package-level variable decimalPrecision in the decimal package code.
I didn't forget about (remove if it is not applicable):
See:
go-tarantool/decimal/decimal.go
Line 36 in 48cf0c7
go-tarantool/decimal/export_test.go
Line 16 in 48cf0c7