Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Marvell] platform renaming for innovium #19829

Merged
merged 1 commit into from
Nov 25, 2024
Merged

[Marvell] platform renaming for innovium #19829

merged 1 commit into from
Nov 25, 2024

Conversation

krismarvell
Copy link
Contributor

@krismarvell krismarvell commented Aug 6, 2024 •
edited
Loading

Why I did it

Renaming of platforms and asic types for marvell
This PR has dependencies on the below submodule PRs

Repo PR title State
sonic-swss [Marvell] platform renaming for innovium Merged
sonic-utilities platform renaming for innovium Merged
sonic-sairedis [Marvell] platform renaming for innovium Merged
sonic-mgmt Changes to support chip name change from innovium to marvell-teralynx Merged

How I did it

renamed platform folder names and asic types as below
platform/innovium renamed to platform/marvell-teralynx

How to verify

Verify marvell-teralynx builds going through, and verify the images in teralynx switches and verified linkup of interfaces

Work item tracking
  • Microsoft ADO (number only):

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

master

Description for the changelog

NA

Link to config_db schema for YANG module changes

NA

A picture of a cute animal (not mandatory but encouraged)

@krismarvell krismarvell requested a review from lguohan as a code owner August 6, 2024 01:28
@krismarvell krismarvell marked this pull request as draft August 6, 2024 01:28
@krismarvell krismarvell force-pushed the innovium_rename branch 4 times, most recently from af0c1c4 to ed35536 Compare August 12, 2024 07:19
@krismarvell krismarvell marked this pull request as ready for review August 29, 2024 05:26
@krismarvell
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Pull request contains merge conflicts.

@kbabujp kbabujp mentioned this pull request Aug 29, 2024
Merged
7 tasks
@rajneeshaec rajneeshaec mentioned this pull request Sep 2, 2024
Closed
7 tasks
@krismarvell krismarvell force-pushed the innovium_rename branch 2 times, most recently from 163cac8 to 5bfc28d Compare September 3, 2024 04:59
@krismarvell
Copy link
Contributor Author

/azpw ms_conflict

@krismarvell krismarvell mentioned this pull request Sep 5, 2024
Merged
@saiarcot895
Copy link
Contributor

@Blueve please help with the review for this

@liushilongbuaa @xumia please help with the changes to the pipeline yml files. Specifically, are there any other changes needed for the nightly official builds?

@krismarvell
Copy link
Contributor Author

@liushilongbuaa @xumia Can you pls checking if there are additional changes needed for the nightly pipeline builds with these changes ? @Blueve Can you pls help review ?

@liushilongbuaa
Copy link
Contributor

checking.

@saiarcot895
Copy link
Contributor

Would it be possible to keep the image name for marvell_prestera_arm64 and marvell_prestera_armhf the same as it is now? The platform string can be renamed, but if the image name is kept the same, that would be good for scripts/automation that use the existing name.

@krismarvell
Copy link
Contributor Author

krismarvell commented Oct 16, 2024 •
edited
Loading

@saiarcot895 it will be difficult to make the image name same as before due to two below reasons.

  1. the image names are closely tied with ONE_IMAGE definition in marvell platform and hence keeping the old image names vs platform string renames in code may end up in image build errors and may require unclean fix for the same.
  2. Also, for the platform users, we would like to add prestera as reference marker for this asic for clarity.
    The scripts/automation using the above platform image names, is that something i can make appropriate changes so as to work with this change ? Pls let me know

@krismarvell krismarvell force-pushed the innovium_rename branch 2 times, most recently from 673cb71 to 177ff0a Compare November 19, 2024 12:16
@krismarvell
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@krismarvell
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@krismarvell
Copy link
Contributor Author

@saiarcot895 have done a latest rebase with a conflict resolved. Request help with the merge.

@krismarvell
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@krismarvell
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@krismarvell
Copy link
Contributor Author

@lguohan Can you pls help merge this changeset

@lguohan lguohan merged commit b2113a5 into sonic-net:master Nov 25, 2024
22 checks passed
lguohan pushed a commit to sonic-net/sonic-mgmt that referenced this pull request Nov 25, 2024
@kbabujp
Changes to support chip name change from innovium to marvell-teralynx (…
37e533d 
…#14330)

Adding the changes to support chip name change from Innovium to marvell-teralynx

Summary:
The chip name for innvium is changed to marvell-teralynx.
Same need to be modified in sonic-mgmt where we do conditional checks for different scripts.

This PR has dependencies on the below sonic-buildimage PR
sonic-net/sonic-buildimage#19829
@krismarvell krismarvell mentioned this pull request Nov 27, 2024
Merged
11 tasks
lguohan pushed a commit that referenced this pull request Dec 2, 2024
@krismarvell
[ci]: Fix pipeline build platform name for marvell-teralynx (#20936)
a6b9e1a 
To Fix newly renamed marvell-teralynx pipeline build failures after #19829
@krismarvell krismarvell mentioned this pull request Dec 12, 2024
Merged
11 tasks
lguohan pushed a commit that referenced this pull request Dec 16, 2024
@krismarvell
[ci]: Fix the pipeline build path for renamed marvell-teralynx platfo…
d18ccbf 
…rm (#21149)

The pipeline build links are pointing to a wrong folder for marvell-teralynx platform after renaming PR (#19829)
VladimirKuk pushed a commit to Marvell-switching/sonic-buildimage that referenced this pull request Jan 21, 2025
@krismarvell @VladimirKuk
Rename platform/innovium to platform/marvell-teralynx (sonic-net#19829)
7fa6a00 
renamed platform folder names and asic types as below
platform/innovium renamed to platform/marvell-teralynx
VladimirKuk pushed a commit to Marvell-switching/sonic-buildimage that referenced this pull request Jan 21, 2025
@krismarvell @VladimirKuk
[ci]: Fix pipeline build platform name for marvell-teralynx (sonic-ne…
384e1ee 
…t#20936)

To Fix newly renamed marvell-teralynx pipeline build failures after sonic-net#19829
VladimirKuk pushed a commit to Marvell-switching/sonic-buildimage that referenced this pull request Jan 21, 2025
@krismarvell @VladimirKuk
[ci]: Fix the pipeline build path for renamed marvell-teralynx platfo…
c698151 
…rm (sonic-net#21149)

The pipeline build links are pointing to a wrong folder for marvell-teralynx platform after renaming PR (sonic-net#19829)
@rajneeshaec rajneeshaec mentioned this pull request Feb 26, 2025
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saiarcot895 saiarcot895 saiarcot895 approved these changes

@liushilongbuaa liushilongbuaa liushilongbuaa approved these changes

@lguohan lguohan Awaiting requested review from lguohan lguohan is a code owner

@xumia xumia Awaiting requested review from xumia

@Blueve Blueve Awaiting requested review from Blueve

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@krismarvell @mssonicbld @saiarcot895 @liushilongbuaa @lguohan