Changes to support asic name change from marvell to marvell-prestera #17171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
7 tasks
|
/azp run |
|
Commenter does not have sufficient privileges for PR 17171 in repo sonic-net/sonic-mgmt |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 17171 in repo sonic-net/sonic-mgmt |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 17171 in repo sonic-net/sonic-mgmt |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yxieca
reviewed
Feb 26, 2025
| @@ -880,7 +880,7 @@ platform_tests/broadcom: | |||
| skip: | |||
| reason: "Marvell devices does not support platform_tests/broadcom" | |||
| conditions: | |||
| - "'marvell' in asic_type" | |||
| - "'marvell' in asic_type or 'marvell-prestera' in asic_type" | |||
There was a problem hiding this comment.
"asic_type in ['marvell', 'marvell-prestera']" is the deterministic way?
the check above will include marvel-*
There was a problem hiding this comment.
Hi @yxieca
Marvell ASIC name is changed from “marvell” to “marvell-prestera” however we also have “marvell-teralynx”. If we use “marvell-*”, test cases will fail for marvell teralynx platforms
Thanks
Rajneesh
There was a problem hiding this comment.
That is the point. right?
'marvell' in asic_type already covered 'marvell-prestera' in asic_type" and it will pass return true for marvell-teralynx.
If your intention is to allow test on all 3 platforms, keeping the first condition is sufficient.
yxieca
reviewed
Feb 26, 2025
tests/common/plugins/conditional_mark/tests_mark_conditions_platform_tests.yaml
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yxieca
approved these changes
Feb 28, 2025
|
/azp run |
|
Commenter does not have sufficient privileges for PR 17171 in repo sonic-net/sonic-mgmt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Adding the changes to support chip name change from marvell to marvell-prestera
Summary:
Fixes # (issue)
The chip name for marvell is changed to marvell-prestera
Same need to be modified in sonic-mgmt where we do conditional checks for different scripts.
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
sonic-net/sonic-buildimage#19829
Supported testbed topology if it's a new test case?