-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Marvell] platform renaming for innovium #3252
Conversation
This seems to be a breaking change to me. Can you confirm if this can be merged and not break existing platform? |
@prsunny This PR wont break existing platform builds and also the functionalty of marvell(renamed as marvell-prestera) and innovium(renamed as marvell-teralynx) platforms. Also this has sonic-buildimage changes to enable respective platform builds in sonic master repo. Pls let me know if you see any specific concerns/breakages even with the additional changes in sonic-buildimage, sonic-sairedis and sonic-utilities PRs below. |
8193fc9
to
81222c3
Compare
@prsunny I see code coverage failing. Is there a way to bypass vstest ? If not, may need your help as to how to trace the code coverage errors. |
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
@krismarvell , we can merge this PR once you confirm its ready. Do you've an order of merge dependency? Which PR should be going first? |
@prsunny For the successful image build, i think it can be merged in any order and hence this swss change can be merged indepently. Pls let me know if you think otherwise. the sonic-swss submodule update into sonic-buildimage will happen subsequently ? |
submodule update is automated. It can happen in the next day itself. Is it going to break anything for this platform? |
@prsunny this merge is not going to break the build |
647c73d
to
8b0521b
Compare
Platform renaming, and bypassing coverage |
What I did asic type checks for innovium platforms renamed innovium to marvell-teralynx Why I did it asictype is being renamed in sonic-buildimage repo and hence respective platform checks needs changes in swss
What I did asic type checks for innovium platforms renamed innovium to marvell-teralynx Why I did it asictype is being renamed in sonic-buildimage repo and hence respective platform checks needs changes in swss
What I did asic type checks for innovium platforms renamed innovium to marvell-teralynx Why I did it asictype is being renamed in sonic-buildimage repo and hence respective platform checks needs changes in swss
What I did asic type checks for innovium platforms renamed innovium to marvell-teralynx Why I did it asictype is being renamed in sonic-buildimage repo and hence respective platform checks needs changes in swss
What I did asic type checks for innovium platforms renamed innovium to marvell-teralynx Why I did it asictype is being renamed in sonic-buildimage repo and hence respective platform checks needs changes in swss
What I did asic type checks for innovium platforms renamed innovium to marvell-teralynx Why I did it asictype is being renamed in sonic-buildimage repo and hence respective platform checks needs changes in swss
What I did
asic type checks for innovium platforms renamed
Why I did it
asictype is being renamed in sonic-buildimage repo and hence respective platform checks needs changes in swss
How I verified it
Run sonic-ptf on ACL and PFC modules to make sure the change does not impact existing functionality
Details if related