Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move construction methods to Polyhedron_base5 #33123

Closed
kliem opened this issue Jan 5, 2022 · 14 comments
Closed

Move construction methods to Polyhedron_base5 #33123

kliem opened this issue Jan 5, 2022 · 14 comments

Comments

@kliem
Copy link
Contributor

kliem commented Jan 5, 2022

Part of #32651.

We move polytopal constructions to Polyhedron_base5. We also group them according to their input.

Depends on #32788

CC: @mkoeppe

Component: geometry

Author: Jonathan Kliem

Branch/Commit: 8c25b61

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/33123

@kliem kliem added this to the sage-9.6 milestone Jan 5, 2022
@kliem
Copy link
Contributor Author

kliem commented Jan 5, 2022

Branch: public/33123

@kliem
Copy link
Contributor Author

kliem commented Jan 5, 2022

New commits:

1bc44c9move polytopal construction to Polyhedron_base5

@kliem
Copy link
Contributor Author

kliem commented Jan 5, 2022

Commit: 1bc44c9

@mkoeppe
Copy link
Contributor

mkoeppe commented Jan 6, 2022

comment:2

file base5 missing

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 6, 2022

Changed commit from 1bc44c9 to 3f32909

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 6, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

3f32909add base5.py

@mkoeppe
Copy link
Contributor

mkoeppe commented Jan 24, 2022

Reviewer: Matthias Koeppe

@kliem
Copy link
Contributor Author

kliem commented Jan 25, 2022

comment:6

Thank you.

@vbraun
Copy link
Member

vbraun commented Feb 12, 2022

comment:7

Merge failure on top of:

7fa1231b5b Trac #33121: PARI/GP for elliptic curve discrete logarithms (elllog) and Weil pairings (ellweilpairing)

63a49bea94 Trac #33119: Remove deprecated things in geometry/polyhedron for sage-9.6

7c5436cc8c Trac #32999: Remove imports from sage.libs.all

5abb9e8404 Trac #32976: LLL, min, max, short_vectors for IntegralLattice

1e1263eb0f Trac #32801: Clean the use of weights in generic_graph.py - part 3

7d01de50a8 Trac #32800: Clean the use of weights in generic_graph.py - part 2

4bad770833 Trac #20343: Adding sage/plot/tikzpicture.py

51f7b32 Trac #19951: Remove occurrences of trait_names

b41fb2f Trac #33296: tox.ini: Add -recommended package factor

db7554f Trac #33277: build/pkgs/_recommended/dependencies

5d2a381 Trac #33196: tox.ini: Add centos-stream-8, centos-stream-9, remove defunct centos-6

4fc783e Trac #33085: adjust dochtml label so doctests pass when html doc is not built/installed

45706f8 Trac #33033: Prepare sage.doctest for namespace packages

55fd5ed Trac #33027: zombie maxima process - if invoked from a script

b34c0d5 Trac #31529: texlive: Add spkg-configure.m4 and system package information; remove install script

c4e4a63 Trac #31415: GH Actions workflow that builds documentation on each push

9cc853b Trac #33107: Generic cholesky() fails on the trivial matrix

88a98d5 Trac #33103: gitpod integration using Docker images from portability testing workflow

d4466d8 Trac #33102: some details in shuffle and multizeta

09de266 Trac #33098: Add more void packages to distros/void.txt

73dd8d1 Trac #33096: src/tox.ini (relint): Exclude editor temp files etc.

a0d0888 Trac #33095: again some details in Dyck words

4fa191a Trac #33071: Update pillow to 8.4

733ed25 Trac #33070: Package upgrades for Python 3.10 support

e4f3f1d Trac #33069: Remove spkg speaklater

18ba1d8 Trac #33064: sage_docbuild: fails when cache cannot be saved

467c32c Trac #33049: Update scipy to 1.7.3

2cf334f Trac #33048: Update setuptools to 59.8.0

3a4cc16 Trac #33045: ffmpeg tests time out

8fb89a3 Trac #33039: Random doctest failure in continued_fraction_gosper

236856d Trac #33026: make BinaryQF.solve_integer() work for square discriminants

2ad7305 Trac #33015: Random failure in number_field_element.pyx

c45f12e Trac #33009: Move is_prism and is_bipyramid to combinatorial polyhedron

87011e9 Trac #33008: Polyhedron_base.facet_adjacency_matrix: Do not use face_lattice

46cc022 Trac #33007: Remove imports from sage.interfaces.all

57fe9e6 Trac #33005: Add feature for pdftocairo

69d9945 Trac #32993: add pictures to line.py documentation

3834fde Trac #32788: Permanently get rid of bare except: statements

0207af8 Trac #32209: Allow evaluation of morphisms of schemes on points over different rings

206ff0b Trac #33269: fix for build/pkgs/tox/distros/gentoo.txt

6d154b6 Trac #33226: Support giac-1.7.0.45 in doctests

d5d2e23 Trac #33187: Allow gcc/gfortran 12

59c0620 Trac #33140: GH Actions (macOS): Fix filtering of experimental packages

0669c95 Trac #32211: Upgrade FLINT to 2.8.4, arb to 2.22.1

508ea2d Trac #33284: Fix macro name clash introduced in #25633

b511685 Trac #32989: Remove imports from sage.misc.all

9c6afb9 Trac #32505: Finitely presented graded modules over graded connected algebras

226937d Updated SageMath version to 9.6.beta0

merge was not clean: conflicts in src/sage/geometry/polyhedron/base.py

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 12, 2022

Dependencies: #32788

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 12, 2022

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

0113b72code style again
6c08ce1remove blank except in GIAC call
04a1f01fix distinction between two calls
9905930remove code duplication
d3df701#32788 : ensure bare except: statements will not reappear
e92b905mark polymake_expect import as optional
f463e49comment before
9522357Merge branch 'develop.9.5.beta6' into HEAD
de4faf6Merge branch 'u/tmonteil/except_fix_branch' in 9.5.rc1
8c25b61Merge #32788

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 12, 2022

Changed commit from 3f32909 to 8c25b61

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 12, 2022

comment:11

Waiting for the patchbot

@vbraun
Copy link
Member

vbraun commented Feb 16, 2022

Changed branch from public/33123 to 8c25b61

@vbraun vbraun closed this as completed in 7f8b268 Feb 16, 2022
mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 12, 2023
mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants