Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade FLINT to 2.8.4, arb to 2.22.1 #32211

Closed
mkoeppe opened this issue Jul 16, 2021 · 62 comments
Closed

Upgrade FLINT to 2.8.4, arb to 2.22.1 #32211

mkoeppe opened this issue Jul 16, 2021 · 62 comments
Labels
c: packages: standard p: critical / 2 t: enhancement
Milestone
sage-9.6

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 16, 2021

FLINT 2.8.1 and FLINT 2.8.2 announced, then FLINT 2.8.3,
then FLINT 2.8.4:

Arb release history:

Depends on #33189

CC: @slel

Component: packages: standard

Keywords: upgrade, arb, flint

Author: Jonathan Kliem, Matthias Koeppe

Branch/Commit: 45f4984

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/32211
@mkoeppe mkoeppe added this to the sage-9.4 milestone Jul 16, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 16, 2021

Branch: u/mkoeppe/test_ticket__upgrade_flint_to_2_8_0

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 16, 2021

New commits:

6d14c45build/pkgs/flint: Use 2.8.0-rc2

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 16, 2021

Reviewer: https://github.com/mkoeppe/sage/actions/runs/1038241361

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 16, 2021

Commit: 6d14c45

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 16, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

ac46936build/pkgs/flint/spkg-install.in: Use cmake

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 16, 2021

Changed commit from 6d14c45 to ac46936

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 17, 2021

Changed commit from ac46936 to 9ea2e5c

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 17, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

9ea2e5cbuild/pkgs/arb/patches: Add https://github.com/fredrik-johansson/arb/commit/b6c8032e2da1b19eb7c5a5f5c2f3372643e3d170

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 17, 2021

Changed reviewer from https://github.com/mkoeppe/sage/actions/runs/1038241361 to https://github.com/mkoeppe/sage/actions/runs/1039613405

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 17, 2021

comment:6

After switching to the cmake build system:

Failure on ubuntu-trusty-standard (where Sage rejects system ntl), likely because FLINT accepts system NTL:

-- Detecting CXX compile features - done
-- Found GMP: /usr/include/x86_64-linux-gnu (Required is at least version "6.0.0") 
-- Found MPFR: /usr/include (Required is at least version "1.0.0") 
-- Found NTL: /usr/lib/libntl.so  
-- Found PythonInterp: /usr/bin/python (found version "2.7.6") 
-- Found CBLAS: /usr/include  
...
lib/libflint.so.16.1.0: undefined reference to `_ntl_gscompare(_ntl_gbigint_body*, long)'
lib/libflint.so.16.1.0: undefined reference to `_ntl_gmod(_ntl_gbigint_body*, _ntl_gbigint_body*, _ntl_gbigint_body**)'
lib/libflint.so.16.1.0: undefined reference to `_ntl_gfree(_ntl_gbigint_body*)'
lib/libflint.so.16.1.0: undefined reference to `_ntl_gsetlength(_ntl_gbigint_body**, long)'
lib/libflint.so.16.1.0: undefined reference to `mpfr_rootn_ui'
lib/libflint.so.16.1.0: undefined reference to `NTL::TerminalError(char const*)'
collect2: error: ld returned 1 exit status
make[5]: *** [bin/test-t-umul_ppmm] Error 1

(ubuntu-trusty-minimal, i.e., without installation of system ntl, is OK)

Likewise ubuntu-xenial, debian-jessie, debian-stretch, etc.

@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Jul 19, 2021
@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe mkoeppe changed the title Test ticket: Upgrade FLINT to 2.8.0 Upgrade FLINT to 2.8.0, arb to 2.20.0 Aug 2, 2021
@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe mkoeppe changed the title Upgrade FLINT to 2.8.0, arb to 2.20.0 Upgrade FLINT to 2.8.0, arb to 2.21.0 Sep 25, 2021
@antonio-rojas
Copy link
Contributor

Changed dependencies from #32175 to #32175 #32567

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe mkoeppe changed the title Upgrade FLINT to 2.8.0, arb to 2.21.0 Upgrade FLINT to 2.8.1, arb to 2.21.0 Oct 1, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 2, 2021

Changed reviewer from https://github.com/mkoeppe/sage/actions/runs/1039613405 to none

@slel

This comment has been minimized.

Sign in to view
@slel slel changed the title Upgrade FLINT to 2.8.1, arb to 2.21.0 Upgrade FLINT to 2.8.2, arb to 2.21.0 Oct 22, 2021
@dimpase
Copy link
Member

dimpase commented Nov 3, 2021

comment:14

Flint 2.8.3 is out, please update.

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe mkoeppe changed the title Upgrade FLINT to 2.8.2, arb to 2.21.0 Upgrade FLINT to 2.8.3, arb to 2.21.0 Nov 7, 2021
@slel

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 2, 2022

Changed branch from u/gh-kliem/flint_2_8_4 to u/mkoeppe/flint_2_8_4

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 2, 2022

Changed branch from u/mkoeppe/flint_2_8_4 to u/gh-kliem/flint_2_8_4

@mkoeppe mkoeppe changed the title Upgrade FLINT to 2.8.4, arb to 2.21.0 Upgrade FLINT to 2.8.4, arb to 2.22.1 Feb 2, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 2, 2022

Changed reviewer from https://github.com/kliem/sage/pull/49/checks to none

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 3, 2022

Changed branch from u/gh-kliem/flint_2_8_4 to u/mkoeppe/flint_2_8_4

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 3, 2022

Changed commit from da45eb1 to 45f4984

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 3, 2022

New commits:

b6c8b76update flint to 2.8.4
f9357e9build/pkgs/arb: Update to 2.22.1
45f4984build/pkgs/arb/patches/arb-flint-2.8-compatibility-b6c8032e2da1b19eb7c5a5f5c2f3372643e3d170.patch: Remove

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 3, 2022

Changed dependencies from #32175 #32567, #32907 to none

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 3, 2022

Author: Jonathan Kliem, Matthias Koeppe

@mkoeppe

This comment has been minimized.

Sign in to view
@dimpase
Copy link
Member

dimpase commented Feb 4, 2022

comment:43

I see doctest errors (numerical noise) in e.g. here

File "src/sage/rings/real_arb.pyx", line 3509, in sage.rings.real_arb.RealBall.erf
Failed example:
    RBF(1/2).erf()
Expected:
    [0.520499877813047 +/- 6.10e-16]
Got:
    [0.520499877813047 +/- 5.93e-16]

(this is on Debian 11,x86_64)

@dimpase
Copy link
Member

dimpase commented Feb 4, 2022

comment:44

#33189 is needed here, so that comment:43 no longer applies.

@dimpase
Copy link
Member

dimpase commented Feb 4, 2022

Dependencies: #33189

@dimpase
Copy link
Member

dimpase commented Feb 4, 2022

comment:45

lgtm

@dimpase
Copy link
Member

dimpase commented Feb 4, 2022

Reviewer: Dima Pasechnik

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 4, 2022

comment:46

Thanks.

@vbraun
Copy link
Member

vbraun commented Feb 7, 2022

comment:47

See https://github.com/vbraun/sage/runs/5086538238

@dimpase
Copy link
Member

dimpase commented Feb 7, 2022

comment:48

Volker, you did not merge the dependency, #33189, that's why you got errors, e.g. here:
https://github.com/vbraun/sage/blob/7b26bb58475d9bc707bc9ed7d2a63351f2f4686c/src/sage/rings/real_arb.pyx#L3509

It should be

sage: RBF(1/2).erf() # abs tol 1e-16

and not

sage: RBF(1/2).erf()

as in the branch you're testing.

@dimpase
Copy link
Member

dimpase commented Feb 7, 2022

comment:49

When I added #33189 and set this to positive review, #33189 was already marked as merged,so I don't really understand how it was tested without it in the end.

@vbraun
Copy link
Member

vbraun commented Feb 12, 2022

Changed branch from u/mkoeppe/flint_2_8_4 to 45f4984

@vbraun vbraun closed this as completed in 0669c95 Feb 12, 2022
@antonio-rojas antonio-rojas mentioned this issue Oct 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: packages: standard p: critical / 2 t: enhancement
Projects
None yet
Milestone
sage-9.6
Development

No branches or pull requests
7 participants
@kiwifb @vbraun @dimpase @slel @mkoeppe @antonio-rojas @kliem