Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tests pass with arb 2.22 #33189

Closed
antonio-rojas opened this issue Jan 16, 2022 · 16 comments
Closed

Make tests pass with arb 2.22 #33189

antonio-rojas opened this issue Jan 16, 2022 · 16 comments

Comments

@antonio-rojas
Copy link
Contributor

By adding abs tol as in #32567 and #32905.

CC: @dimpase @mezzarobba @mkoeppe @slel @kiwifb

Component: packages: standard

Author: Antonio Rojas

Branch/Commit: 53532dd

Reviewer: Dima Pasechnik, Gonzalo Tornaría

Issue created by migration from https://trac.sagemath.org/ticket/33189

@antonio-rojas antonio-rojas added this to the sage-9.5 milestone Jan 16, 2022
@antonio-rojas
Copy link
Contributor Author

@antonio-rojas
Copy link
Contributor Author

Author: Antonio Rojas

@antonio-rojas
Copy link
Contributor Author

New commits:

24cc94bAdd abs tol to some arb tests

@antonio-rojas

This comment has been minimized.

@antonio-rojas
Copy link
Contributor Author

Commit: 24cc94b

@dimpase
Copy link
Member

dimpase commented Jan 16, 2022

comment:3

the following chunk:

@@ -3578,12 +3578,12 @@ cdef class RealBall(RingElement):
 
         EXAMPLES::
 
-            sage: RBF(1).Ci()  # abs tol 1e-16
+            sage: RBF(1).Ci()  # abs tol 1e-15
             [0.337403922900968 +/- 3.25e-16]
 
         TESTS::
 
-            sage: RBF(Ci(1))  # abs tol 1e-16
+            sage: RBF(Ci(1))  # abs tol 1e-15
             [0.337403922900968 +/- 3.25e-16]
         """
         cdef RealBall res = self._new()

looks suspect, as adding 1e-15 to the ball shifts it so much that the resulting
two balls don't intersect any more. 5e-15 would be still OK, though.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 16, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

53532ddDecrease abs tol

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 16, 2022

Changed commit from 24cc94b to 53532dd

@dimpase
Copy link
Member

dimpase commented Jan 16, 2022

comment:5

I didn't actually check that it still passes such a decrease.

@dimpase
Copy link
Member

dimpase commented Jan 17, 2022

Reviewer: Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Jan 17, 2022

comment:6

I suppose it's OK.

@tornaria
Copy link
Contributor

comment:7

Works ok for me, tested on void linux (glibc 64 and 32 bit, musl 64 bit).

@slel

This comment has been minimized.

@slel
Copy link
Member

slel commented Jan 22, 2022

Changed reviewer from Dima Pasechnik to Dima Pasechnik, Gonzalo Tornaría

@slel
Copy link
Member

slel commented Jan 30, 2022

comment:9

Setting milestone to 9.6 now that 9.5 is out.

@slel slel modified the milestones: sage-9.5, sage-9.6 Jan 30, 2022
@vbraun
Copy link
Member

vbraun commented Jan 31, 2022

Changed branch from u/arojas/make_tests_pass_with_arb_2_22 to 53532dd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants