-
-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make tests pass with arb 2.22 #33189
Comments
Author: Antonio Rojas |
New commits:
|
This comment has been minimized.
This comment has been minimized.
Commit: |
comment:3
the following chunk: @@ -3578,12 +3578,12 @@ cdef class RealBall(RingElement):
EXAMPLES::
- sage: RBF(1).Ci() # abs tol 1e-16
+ sage: RBF(1).Ci() # abs tol 1e-15
[0.337403922900968 +/- 3.25e-16]
TESTS::
- sage: RBF(Ci(1)) # abs tol 1e-16
+ sage: RBF(Ci(1)) # abs tol 1e-15
[0.337403922900968 +/- 3.25e-16]
"""
cdef RealBall res = self._new() looks suspect, as adding 1e-15 to the ball shifts it so much that the resulting |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:5
I didn't actually check that it still passes such a decrease. |
Reviewer: Dima Pasechnik |
comment:6
I suppose it's OK. |
comment:7
Works ok for me, tested on void linux (glibc 64 and 32 bit, musl 64 bit). |
This comment has been minimized.
This comment has been minimized.
Changed reviewer from Dima Pasechnik to Dima Pasechnik, Gonzalo Tornaría |
comment:9
Setting milestone to 9.6 now that 9.5 is out. |
Changed branch from u/arojas/make_tests_pass_with_arb_2_22 to |
By adding
abs tol
as in #32567 and #32905.CC: @dimpase @mezzarobba @mkoeppe @slel @kiwifb
Component: packages: standard
Author: Antonio Rojas
Branch/Commit:
53532dd
Reviewer: Dima Pasechnik, Gonzalo Tornaría
Issue created by migration from https://trac.sagemath.org/ticket/33189
The text was updated successfully, but these errors were encountered: