Fix macro name clash introduced in #25633

[pfasante]

#25633 breaks the cygwin build

[ 74/529] gcc -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -ggdb -O2 -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector-strong --param=ssp-buffer-size=4 -DOPENSSL_NO_SSL3=1 -fdebug-prefix-map=/pub/devel/python/python38/python38-3.8.12-1.x86_64/build=/usr/src/debug/python38-3.8.12-1 -fdebug-prefix-map=/pub/devel/python/python38/python38-3.8.12-1.x86_64/src/Python-3.8.12=/usr/src/debug/python38-3.8.12-1 -ggdb -O2 -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector-strong --param=ssp-buffer-size=4 -DOPENSSL_NO_SSL3=1 -fdebug-prefix-map=/pub/devel/python/python38/python38-3.8.12-1.x86_64/build=/usr/src/debug/python38-3.8.12-1 -fdebug-prefix-map=/pub/devel/python/python38/python38-3.8.12-1.x86_64/src/Python-3.8.12=/usr/src/debug/python38-3.8.12-1 -g -O2 -I./sage/cpython -I/opt/sage-3c8073266a16294562cd0273556664c883917216/lib/python3.8/site-packages/cysignals -I/cygdrive/d/a/sage/sage/pkgs/sagemath-standard -I/usr/include/python3.8 -I/opt/sage-3c8073266a16294562cd0273556664c883917216/lib/python3.8/site-packages/numpy/core/include -Ibuild/cythonized -I/opt/sage-3c8073266a16294562cd0273556664c883917216/include -I/usr/include/python3.8 -c build/cythonized/sage/crypto/sbox.c -o build/temp.cygwin-3.3.4-x86_64-3.8/build/cythonized/sage/crypto/sbox.o -fno-strict-aliasing -DCYTHON_CLINE_IN_TRACEBACK=1 -std=gnu99
gcc -shared -Wl,--enable-auto-image-base -L/opt/sage-3c8073266a16294562cd0273556664c883917216/lib -Wl,-rpath,/opt/sage-3c8073266a16294562cd0273556664c883917216/lib -g -O2 build/temp.cygwin-3.3.4-x86_64-3.8/build/cythonized/sage/cpython/wrapperdescr.o -L/opt/sage-3c8073266a16294562cd0273556664c883917216/lib/python3.8/config -L/usr/lib -lpython3.8 -o build/lib.cygwin-3.3.4-x86_64-3.8/sage/cpython/wrapperdescr.cpython-38-x86_64-cygwin.dll
In file included from /usr/include/python3.8/unicodeobject.h:58,
                 from /usr/include/python3.8/Python.h:97,
                 from build/cythonized/sage/crypto/sbox.c:45:
build/cythonized/sage/crypto/sbox.c:1642:13: error: expected identifier or ‘(’ before numeric constant
 1642 |   PyObject *_S;
      |             ^~
In file included from /usr/include/python3.8/pytime.h:6,
                 from /usr/include/python3.8/Python.h:85,
                 from build/cythonized/sage/crypto/sbox.c:45:
build/cythonized/sage/crypto/sbox.c: In function ‘__pyx_pf_4sage_6crypto_4sbox_4SBox___init__’:
build/cythonized/sage/crypto/sbox.c:4577:30: error: expected identifier before numeric constant
 4577 |   __Pyx_DECREF(__pyx_v_self->_S);
      |                              ^~

​https://github.com/mkoeppe/sage/runs/5054706036?check_suite_focus=true

This is likely from a clash with an unfortunately named macro from a system header file

(see ​https://eigen.tuxfamily.org/bz/show_bug.cgi?id=658)

CC: @mkoeppe @tscrim

Component: cython

Author: Friedrich Wiemer

Branch/Commit: a2e1b28

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/33284

[pfasante]

Branch: u/asante/fix_macro_name_clash_introduced_in__25633

[pfasante]

Last 10 new commits:

cb7a8e6	Merge branch 'develop' into t/25633/public/crypto/speedup_sbox-25633
d4d2e83	fix deprecation warning for FreeModule's vector_space
56952f5	adjust remaining doctests to change in interpolation_polynomial
3b788ef	document changes in interpolation_polynomial
91ba2d3	add another sanity doctest for interpolation_polynomial
cb0ff10	fix NOTE documentation
388b459	use trac macro for link to ticket
9f79692	remove unnecessary brackets around trac macro
af15831	Merge branch of ticket #25633
a2e1b28	rename internal S-box list to resolve name clash

[pfasante]

Commit: a2e1b28

[mkoeppe]

Reviewer: https://github.com/mkoeppe/sage/actions/runs/1792451901

[mkoeppe]

comment:6

This fixes the problem, as can be seen in https://github.com/mkoeppe/sage/runs/5080930073

[mkoeppe]

Changed reviewer from https://github.com/mkoeppe/sage/actions/runs/1792451901 to Matthias Koeppe

[tobiasdiez]

comment:8

The linter fails on this one with

sage/crypto/sbox.pyx:10 python3: Python3 incompatible code
Hint: # ifilter, imap, izip           # __metaclass__
Hint: # update raise statements       # except Exception, var
Hint: # six is no longer allowed

10>    from six import integer_types

[vbraun]

Changed branch from u/asante/fix_macro_name_clash_introduced_in__25633 to a2e1b28