Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support giac-1.7.0.45 in doctests #33226

Closed
orlitzky opened this issue Jan 24, 2022 · 7 comments
Closed

Support giac-1.7.0.45 in doctests #33226

orlitzky opened this issue Jan 24, 2022 · 7 comments

Comments

@orlitzky
Copy link
Contributor

**********************************************************************
File "src/sage/functions/min_max.py", line 236, in sage.functions.min_max.MaxSy\
mbolic._evalf_
Failed example:
    r
Expected:
    sqrt(2) - cos(1)
Got:
    0.873911256505000
**********************************************************************
File "src/sage/functions/min_max.py", line 238, in sage.functions.min_max.MaxSy\
mbolic._evalf_
Failed example:
    r.n()
Expected:
    0.873911256504955
Got:
    0.873911256505000
**********************************************************************

The second one is easy, but the first probably just has to be dropped. I recall another
failure like this recently where giac had become more cautious about what it would integrate.

Component: symbolics

Author: Michael Orlitzky

Branch/Commit: 33ea2ad

Reviewer: Gonzalo Tornaría

Issue created by migration from https://trac.sagemath.org/ticket/33226

@orlitzky orlitzky added this to the sage-9.6 milestone Jan 24, 2022
@orlitzky
Copy link
Contributor Author

Commit: 33ea2ad

@orlitzky
Copy link
Contributor Author

New commits:

33ea2adTrac #33226: update doctests for giac-1.7.0.45.

@orlitzky
Copy link
Contributor Author

Author: Michael Orlitzky

@orlitzky
Copy link
Contributor Author

Branch: u/mjo/ticket/33226

@tornaria
Copy link
Contributor

tornaria commented Feb 2, 2022

Reviewer: Gonzalo Tornaría

@tornaria
Copy link
Contributor

tornaria commented Feb 2, 2022

comment:3

LGTM, tested with system giac-1.7.0-45 in void linux.

@vbraun
Copy link
Member

vbraun commented Feb 12, 2022

Changed branch from u/mjo/ticket/33226 to 33ea2ad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants