Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic cholesky() fails on the trivial matrix #33107

Closed
orlitzky opened this issue Jan 2, 2022 · 13 comments
Closed

Generic cholesky() fails on the trivial matrix #33107

orlitzky opened this issue Jan 2, 2022 · 13 comments

Comments

@orlitzky
Copy link
Contributor

orlitzky commented Jan 2, 2022

sage: A = matrix(QQ,[])
sage: A.cholesky()
...
IndexError: matrix index out of range

If we simply return A itself in this case, the definition of the decomposition is satisfied.

Component: linear algebra

Author: Michael Orlitzky

Branch/Commit: 64d9028

Reviewer: Markus Wageringel

Issue created by migration from https://trac.sagemath.org/ticket/33107

@orlitzky orlitzky added this to the sage-9.5 milestone Jan 2, 2022
@orlitzky
Copy link
Contributor Author

orlitzky commented Jan 2, 2022

Branch: u/mjo/ticket/33107

@orlitzky
Copy link
Contributor Author

orlitzky commented Jan 2, 2022

Author: Michael Orlitzky

@orlitzky
Copy link
Contributor Author

orlitzky commented Jan 2, 2022

New commits:

08bbd3cTrac #33107: cholesky() for trivial matrices.

@orlitzky
Copy link
Contributor Author

orlitzky commented Jan 2, 2022

Commit: 08bbd3c

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 2, 2022

Changed commit from 08bbd3c to 89c46c6

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 2, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

89c46c6Trac #33107: cholesky() for trivial matrices.

@mwageringel
Copy link
Contributor

comment:3
sage: matrix(QQ, [[1]]).cholesky().is_immutable()
True

Usually, .cholesky() returns an immutable matrix. Should we do that in the 0×0 case as well, for consistency? For example, the subdivisions could be mutated, otherwise.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 3, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

64d9028Trac #33107: return immutable trivial Cholesky factors.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 3, 2022

Changed commit from 89c46c6 to 64d9028

@mwageringel
Copy link
Contributor

Reviewer: Markus Wageringel

@mwageringel
Copy link
Contributor

comment:5

Thanks.

@slel
Copy link
Member

slel commented Jan 30, 2022

comment:6

Setting milestone to 9.6 now that 9.5 is out.

@slel slel modified the milestones: sage-9.5, sage-9.6 Jan 30, 2022
@vbraun
Copy link
Member

vbraun commented Feb 12, 2022

Changed branch from u/mjo/ticket/33107 to 64d9028

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants