Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port "Pangeo Forge Recipes" documentation section to use beam-refactor approach #483

Closed
8 of 9 tasks
derekocallaghan opened this issue Jan 27, 2023 · 12 comments
Closed
8 of 9 tasks
Assignees
Labels
beam refactor documentation Improvements or additions to documentation release blocker

Comments

@derekocallaghan
Copy link
Contributor

derekocallaghan commented Jan 27, 2023

The current documentation (#445) describes the Beam approach in the Introduction Tutorial section. The Pangeo Forge Recipes section will also need to be ported to replace e.g. XarrayZarrRecipe references with the recommended Beam equivalent.

I guess the final API is still a work in progress (e.g. see #473). If it's useful, I can add a new/update an existing Recipe Tutorial as this may help settle the approach recommended to recipe authors. We could the update the Recipes User Guide, API Reference etc afterwards.

I have a local CCMP recipe that includes some custom processing (#453), which I can use to create a new recipe tutorial.

The objective is to have an accurate (if reduced) version of the documentation by Feb 26th 2023. The following sections will be ported:

@norlandrhagen
Copy link
Contributor

Hey there @derekocallaghan, I would love to help out on porting over some of the recipe tutorials. Do you have any you prefer to work on or have already started on?

@derekocallaghan
Copy link
Contributor Author

derekocallaghan commented Feb 2, 2023

Hi @norlandrhagen, I've just created #487 that contains an initial port of the NetCDF Zarr Multi-Variable Sequential Recipe: NOAA World Ocean Atlas notebook to use the beam-refactor approach. Although it contains references to the Xarray-to-Zarr Sequential Recipe: NOAA OISST notebook, I haven't ported this yet as it contains functionality which may no longer be provided by the beam-refactor branch. I'm going to look at this next.

In the meantime, the ported NOAA World Ocean Atlas notebook in #487 may be useful as an example for porting other tutorial notebooks. There are currently five tutorial notebooks, so if you wanted to look at any of the following that'd be great:

It's possible these may take a number of iterations depending on API changes. I guess we can coordinate in this which notebooks are being worked on to avoid duplication.

derekocallaghan added a commit to derekocallaghan/pangeo-forge-recipes that referenced this issue Feb 2, 2023
derekocallaghan added a commit to derekocallaghan/pangeo-forge-recipes that referenced this issue Feb 2, 2023
@derekocallaghan
Copy link
Contributor Author

Hi @rabernat, I'm looking into porting the Xarray-to-Zarr Sequential Recipe: NOAA OISST notebook to use the Beam approach. Some of the steps are currently no longer fully relevant as they use functionality from pangeo_forge_recipes.recipes.xarray_zarr such as open_chunk() e.g.:

Do we still want to have steps similar to these in the Beam version of the notebook, or replace them with steps that look at the output Zarr instead?

@cisaacstern
Copy link
Member

Per conversation today during Coordination meeting, we've agreed to cut out the sections referenced above, which are no longer relevant in the context of beam-refactor.

@norlandrhagen
Copy link
Contributor

@derekocallaghan here is the TerraClimate recipe.

derekocallaghan added a commit to derekocallaghan/pangeo-forge-recipes that referenced this issue Feb 15, 2023
@derekocallaghan
Copy link
Contributor Author

An initial port of the Xarray-to-Zarr Sequential Recipe: NOAA OISST notebook has been created (#487).

@derekocallaghan
Copy link
Contributor Author

As there are a few sections to port, I've added a task list to this issue description to coordinate activity.

derekocallaghan added a commit to derekocallaghan/pangeo-forge-recipes that referenced this issue Feb 17, 2023
derekocallaghan added a commit to derekocallaghan/pangeo-forge-recipes that referenced this issue Feb 17, 2023
derekocallaghan added a commit to derekocallaghan/pangeo-forge-recipes that referenced this issue Feb 17, 2023
derekocallaghan added a commit to derekocallaghan/pangeo-forge-recipes that referenced this issue Feb 27, 2023
@derekocallaghan
Copy link
Contributor Author

I'm currently updating the remaining documentation to use the updated content from the tutorial notebooks (#487).

derekocallaghan added a commit to derekocallaghan/pangeo-forge-recipes that referenced this issue Mar 3, 2023
derekocallaghan added a commit to derekocallaghan/pangeo-forge-recipes that referenced this issue Mar 7, 2023
derekocallaghan added a commit to derekocallaghan/pangeo-forge-recipes that referenced this issue Mar 14, 2023
derekocallaghan added a commit to derekocallaghan/pangeo-forge-recipes that referenced this issue Mar 14, 2023
rabernat pushed a commit that referenced this issue Mar 14, 2023
* WIP "Recipes" (#483)

* Full draft of Beam port of "Recipes User Guide" (#483)

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Updated following review comments, and some minor additional edits to Recipes (#483)

* Updated following review comments, and restored link to OPenDAP notebook (#483)

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@cisaacstern
Copy link
Member

Notes from Coordination Meeting today:

  • Terraclimate blocked by open bug report (@cisaacstern link after meeting)
  • Open separate issue for migrating tutorials from notebooks -> scripts (with CI testing)

Note: Latter is not a release blocker.

@derekocallaghan
Copy link
Contributor Author

Notes from Coordination Meeting today:

* Terraclimate blocked by open bug report (@cisaacstern link after meeting)

* Open separate issue for migrating tutorials from notebooks -> scripts (with CI testing)

Note: Latter is not a release blocker.

Thanks @cisaacstern, apologies I couldn't make the last couple of meetings. I can help out with some of the notebook -> script migration.

@cisaacstern
Copy link
Member

#490 is now in! I'll take one more spin through the docs this afternoon, and then merge beam-refactor 🚀 .

@cisaacstern
Copy link
Member

Having skimmed the docs, my conclusion is that while there are certainly many opportunities for clarification and greater depth, there are no glaring inaccuracies, so I'm going to call this issue closed, and move on to releasing beam-refactor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beam refactor documentation Improvements or additions to documentation release blocker
Projects
None yet
Development

No branches or pull requests

3 participants