-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port "Pangeo Forge Recipes" documentation section to use beam-refactor
approach
#483
Comments
Hey there @derekocallaghan, I would love to help out on porting over some of the recipe tutorials. Do you have any you prefer to work on or have already started on? |
Hi @norlandrhagen, I've just created #487 that contains an initial port of the NetCDF Zarr Multi-Variable Sequential Recipe: NOAA World Ocean Atlas notebook to use the In the meantime, the ported NOAA World Ocean Atlas notebook in #487 may be useful as an example for porting other tutorial notebooks. There are currently five tutorial notebooks, so if you wanted to look at any of the following that'd be great: It's possible these may take a number of iterations depending on API changes. I guess we can coordinate in this which notebooks are being worked on to avoid duplication. |
Hi @rabernat, I'm looking into porting the Xarray-to-Zarr Sequential Recipe: NOAA OISST notebook to use the Beam approach. Some of the steps are currently no longer fully relevant as they use functionality from Do we still want to have steps similar to these in the Beam version of the notebook, or replace them with steps that look at the output Zarr instead? |
Per conversation today during Coordination meeting, we've agreed to cut out the sections referenced above, which are no longer relevant in the context of beam-refactor. |
@derekocallaghan here is the TerraClimate recipe. |
An initial port of the Xarray-to-Zarr Sequential Recipe: NOAA OISST notebook has been created (#487). |
As there are a few sections to port, I've added a task list to this issue description to coordinate activity. |
I'm currently updating the remaining documentation to use the updated content from the tutorial notebooks (#487). |
* WIP "Recipes" (#483) * Full draft of Beam port of "Recipes User Guide" (#483) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updated following review comments, and some minor additional edits to Recipes (#483) * Updated following review comments, and restored link to OPenDAP notebook (#483) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Notes from Coordination Meeting today:
Note: Latter is not a release blocker. |
Thanks @cisaacstern, apologies I couldn't make the last couple of meetings. I can help out with some of the notebook -> script migration. |
#490 is now in! I'll take one more spin through the docs this afternoon, and then merge |
Having skimmed the docs, my conclusion is that while there are certainly many opportunities for clarification and greater depth, there are no glaring inaccuracies, so I'm going to call this issue closed, and move on to releasing |
The current documentation (#445) describes the Beam approach in the Introduction Tutorial section. The Pangeo Forge Recipes section will also need to be ported to replace e.g.
XarrayZarrRecipe
references with the recommended Beam equivalent.I guess the final API is still a work in progress (e.g. see #473). If it's useful, I can add a new/update an existing Recipe Tutorial as this may help settle the approach recommended to recipe authors. We could the update the Recipes User Guide, API Reference etc afterwards.
I have a local CCMP recipe that includes some custom processing (#453), which I can use to create a new recipe tutorial.
The objective is to have an accurate (if reduced) version of the documentation by Feb 26th 2023. The following sections will be ported:
Recipes User Guide (Port Recipes User Guide to
beam-refactor
#499)Recipe Tutorials:
API Reference: check docstrings are accurate
Development
The text was updated successfully, but these errors were encountered: