Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port of Terraclimate example to beam-refactor #490

Merged

Conversation

norlandrhagen
Copy link
Contributor

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@derekocallaghan
Copy link
Contributor

Hi @norlandrhagen, this looks good and is a lot easier to read now without the previous Prefect output.

So far, the only thing I've noticed is that soil_clim and the corresponding plot aren't visible at: https://pangeo-forge--490.org.readthedocs.build/en/490/pangeo_forge_recipes/tutorials/xarray_zarr/terraclimate.html#check-and-plot-target

Here's the previous non-Beam version with expected output: https://pangeo-forge.readthedocs.io/en/latest/pangeo_forge_recipes/tutorials/xarray_zarr/terraclimate.html#check-and-plot-target

@norlandrhagen
Copy link
Contributor Author

Thanks for the review @derekocallaghan! I'll fix it today.

@norlandrhagen
Copy link
Contributor Author

Hey there @derekocallaghan,

When running this recipe I'm getting a killed kernel after about 16 minutes. Did you run into any similar memory issues with the other recipes?

The Kernel crashed while executing code in the the current cell or a previous cell

@derekocallaghan
Copy link
Contributor

Hey there @derekocallaghan,

When running this recipe I'm getting a killed kernel after about 16 minutes. Did you run into any similar memory issues with the other recipes?

The Kernel crashed while executing code in the the current cell or a previous cell

Hi @norlandrhagen, I didn't have any similar kernel issues with the other recipes. At first I thought it might be related to the number of products being processed (I had to ensure pruning with some of the others) but looking at the new vs old notebooks above, it looks like you're using the same chunk spec as the old.

Does it happen when running/debugging the pipeline outside of Jupyter?

@cisaacstern
Copy link
Member

@norlandrhagen, #521 is nearly done, so I've merged that work here, in hopes of being able to run the terraclimate tutorial (which was previously blocked by #517).

In my first attempt to run this notebook, I am still seeing a killed kernel on the cell which attempts to run the pipeline.

I'll take a closer look again at this tomorrow morning.

@cisaacstern
Copy link
Member

This is the last major item before merging beam-refactor.

@norlandrhagen, I'm working on this right now! Should have something soon.

@cisaacstern
Copy link
Member

Ok! IMHO this is good to go. I narrowed it down to two variables to make it more manageable to run. To get beam-refactor merged today, I'm going to merge this now. Happy to look at follow-on issues/PRs if anyone notices anything I overlooked.

@cisaacstern cisaacstern merged commit b73cc39 into pangeo-forge:beam-refactor Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants