-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port of Terraclimate example to beam-refactor #490
Port of Terraclimate example to beam-refactor #490
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Hi @norlandrhagen, this looks good and is a lot easier to read now without the previous Prefect output. So far, the only thing I've noticed is that Here's the previous non-Beam version with expected output: https://pangeo-forge.readthedocs.io/en/latest/pangeo_forge_recipes/tutorials/xarray_zarr/terraclimate.html#check-and-plot-target |
Thanks for the review @derekocallaghan! I'll fix it today. |
Hey there @derekocallaghan, When running this recipe I'm getting a killed kernel after about 16 minutes. Did you run into any similar memory issues with the other recipes?
|
Hi @norlandrhagen, I didn't have any similar kernel issues with the other recipes. At first I thought it might be related to the number of products being processed (I had to ensure pruning with some of the others) but looking at the new vs old notebooks above, it looks like you're using the same chunk spec as the old. Does it happen when running/debugging the pipeline outside of Jupyter? |
@norlandrhagen, #521 is nearly done, so I've merged that work here, in hopes of being able to run the terraclimate tutorial (which was previously blocked by #517). In my first attempt to run this notebook, I am still seeing a killed kernel on the cell which attempts to run the pipeline. I'll take a closer look again at this tomorrow morning. |
06724fc
to
23b235c
Compare
This is the last major item before merging @norlandrhagen, I'm working on this right now! Should have something soon. |
Ok! IMHO this is good to go. I narrowed it down to two variables to make it more manageable to run. To get |
#483