-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port tutorial notebooks to use Beam #487
Port tutorial notebooks to use Beam #487
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
I'm going to use this PR for any tutorial notebooks that I port rather than a single PR per notebook. It probably makes more sense to review them together. |
Hi @cisaacstern, this PR is ready for review now, involving porting three of the original notebooks, with one excluded. I removed references to The HDF Reference Recipe for CMIP6 notebook hasn't been ported yet as I assume it's dependent on #486. @norlandrhagen is this okay with you? The TerraClimate notebook port is covered by #490. I'll create separate PRs for the remaining tasklist in #483. |
Hi @cisaacstern, if the notebook changes are okay with you, it might be easier to merge this before merging the latest |
Hi @rabernat and @cisaacstern, if you're free, can you take a look at these notebook changes? If you're happy with them, I'll work on the remaining documentation tasks in #483. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@derekocallaghan these look great to me! The illustrations of how to add preprocessors are very clear, and helped me understand how easy that is do with beam-refactor
. Thanks so much, good to merge IMO!
Psyched to see this PR land! Thanks @derekocallaghan! |
This PR will be used to port tutorial notebooks to
beam-refactor
:The first is an initial port of the NetCDF Zarr Multi-Variable Sequential Recipe: NOAA World Ocean Atlas notebook to use the
beam-refactor
approach:intro_tutorial_part2
target_path
toStoreToZarr
. See [Beam-Refactor] Edits tointro_tutorial_part[*]
#485 for discussion on this point as it may be subject to change.beam-refactor
branch. I'm going to look at this next. In the meantime, this current notebook may be useful as an example for porting other tutorial notebooks (@norlandrhagen).Partly fixes #483