Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beam documentation #445

Merged
merged 25 commits into from
Jan 18, 2023
Merged

Conversation

rabernat
Copy link
Contributor

@rabernat rabernat commented Dec 5, 2022

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@derekocallaghan
Copy link
Contributor

@rabernat
Copy link
Contributor Author

rabernat commented Dec 8, 2022

Thanks @derekocallaghan! That would be awesome!

The pangeo-forge-recipes/beam-refactor branch is where the latest code lives. beam-documentation is this PR, which is made against beam-refactor.

Screen Shot 2022-12-08 at 7 56 26 AM

Have a look at the notebook from this PR if you want to get a feel for how beam recipes work.

@derekocallaghan
Copy link
Contributor

Thanks @rabernat, I'll try out that branch. I'd had a look through that notebook already (and also https://pangeo-forge--445.org.readthedocs.build/en/445/introduction_tutorial/intro_tutorial_part2.html#)

I'll let you know how I get on

@derekocallaghan
Copy link
Contributor

Hi @rabernat, I've created a couple of issues to track work related to porting the EOOffshore recipes to use the beam_refactor branch, which involves writing custom PTransforms. Here's the current status:

  • CCMP v0.2.1.NRT recipe: a custom PTransform has been added to compute wind speed and direction for selected grid coordinates, and the expected pruned output Zarr is successfully generated.
  • CMEMS ASCAT REP and NRT recipes: I'll create two custom PTransforms here, the first similar to that used by the CCMP recipe, while the second will sort the collection using the updated time coordinates.

As discussed in the call earlier this week, I'm currently using pangeo_forge_recipes.transforms._add_keys() to wrap the preprocessing transforms. I think it could be useful to expose this in the public API to reduce some of the code written by recipe authors, i.e. where they provide custom functions operating on e.g. Dataset parameters.

If it helps, I can look at completing the above transforms and recipes and writing some corresponding tutorial notebook-based documentation describing how custom transforms may be provided, similar to what you've done in the OISST notebook. I probably won't get to complete this until early-mid January if that's okay.

@cisaacstern
Copy link
Member

If it helps, I can look at completing the above transforms and recipes and writing some corresponding tutorial notebook-based documentation describing how custom transforms may be provided

This would be incredibly valuable, of course on whatever timeline works well for you.

@rabernat
Copy link
Contributor Author

I'm going to merge this and we can continue to build on it.

@rabernat rabernat marked this pull request as ready for review January 17, 2023 13:28
@rabernat rabernat merged commit 81a9ce5 into pangeo-forge:beam-refactor Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants