Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update opendap tutorial #500

Merged

Conversation

rabernat
Copy link
Contributor

Addresses one of the outstanding tutorials from #483.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@derekocallaghan derekocallaghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The notebook looks good @rabernat. It might be good to add a sentence to "Now we put together the necessary PTransforms" that highlights the use of StoreToZarr.target_chunks re: subsetting. Although it's not quite the same as the XarrayZarrRecipe.subset_inputs functionality, this extra text would be a port of the previous notebook's "This tutorial introduces a new option we have not seen before: subset_inputs={"time": 30}."

@norlandrhagen
Copy link
Contributor

#516

Added a sentence that mentions the use of target_chunks in the pipeline construction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beam refactor documentation Improvements or additions to documentation release blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants