[chore] fix CI #37177
Merged
[chore] fix CI #37177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
approved these changes
Jan 13, 2025
crobert-1
approved these changes
Jan 13, 2025
songy23
approved these changes
Jan 14, 2025
joker-star-l
approved these changes
Jan 14, 2025
This was referenced Jan 14, 2025
MovieStoreGuy
approved these changes
Jan 14, 2025
andrzej-stencel
approved these changes
Jan 14, 2025
odubajDT
approved these changes
Jan 14, 2025
This was referenced Jan 14, 2025
evan-bradley
approved these changes
Jan 14, 2025
|
CI is pain |
c099f98 to
862daf8
Compare
1 task
TylerHelmuth
added a commit
that referenced
this pull request
Jan 14, 2025
Undo the extenstion grouping changes from #37177 as they didnt actually help. I think these sudo tests are the root cause of this week's CI issues. Yesterday a change (#36941) was merged to stop skipping the sudo tests and the result is that the sudo tests now run. When I run these tests locally I sometimes get prompted to enter a password. I think this is what is happening in the runner as well - we are being prompted to approve sudo access. Testing if reverting these integration tests solves our issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix lint issue caused by #36912
This reverts commit 778d8f7.
@adrielp @niwoerner I can't explain why, but it seems that after #36838 the extension integration tests never complete. You can see in https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/workflows/build-and-test.yml?query=branch%3Amain that we haven't got an integration test suite to pass since merging the new receiver. Reverting to unblock CI.