[receiver/gitlab] add tracing via webhook skeleton #36838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrielp
reviewed
Dec 15, 2024
adrielp
reviewed
Dec 15, 2024
adrielp
reviewed
Dec 16, 2024
adrielp
reviewed
Dec 16, 2024
adrielp
reviewed
Dec 16, 2024
adrielp
reviewed
Dec 16, 2024
adrielp
approved these changes
Dec 27, 2024
atoulme
reviewed
Jan 8, 2025
| } | ||
|
|
||
| // Simple healthcheck endpoint. | ||
| func (gtr *gitlabTracesReceiver) handleHealthCheck(w http.ResponseWriter, _ *http.Request) { |
There was a problem hiding this comment.
Good idea to read the request so that the http connection can be reused. Not urgent to do this pr
There was a problem hiding this comment.
That's a good catch, thank you! I will handle this in one of the subsequent PRs
atoulme
approved these changes
Jan 8, 2025
Closed
TylerHelmuth
added a commit
to TylerHelmuth/opentelemetry-collector-contrib
that referenced
this pull request
Jan 14, 2025
…metry#36838)" This reverts commit 778d8f7.
TylerHelmuth
added a commit
to TylerHelmuth/opentelemetry-collector-contrib
that referenced
this pull request
Jan 14, 2025
…metry#36838)" This reverts commit 778d8f7.
Merged
codeboten
pushed a commit
that referenced
this pull request
Jan 14, 2025
Fix lint issue caused by #36912 This reverts commit 778d8f7. @adrielp @niwoerner I can't explain why, but it seems that after #36838 the extension integration tests never complete. You can see in https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/workflows/build-and-test.yml?query=branch%3Amain that we haven't got an integration test suite to pass since merging the new receiver. Reverting to unblock CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the structure and trace skeleton for a new and already accepted Gitlabreceiver. (thanks @atoulme for sponsoring this!)
The Gitlabreceiver aligns very closely with the Githubreceiver and this PR mostly mirrors the change from this PR: #36632
I'm working together with @adrielp on building out the Gitlabreceiver. More PRs to introduce metrics and actual tracing functionality are about to follow with subsequent PRs.
Link to tracking issue
#35207
Testing
Added basic tests and built the component to test that the health check endpoint, when tracing is enabled, operates correctly.
Documentation
Docs how to configure the Gitlabreceiver via webhooks have been added. While the Gitlabreceiver can be configured after this PR, it will not actually do anything since it is under development and just the skeleton PR.