Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/doris] Send json lines to doris rather than json array #36912

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

joker-star-l
Copy link
Contributor

Description

Send json lines to doris rather than json array.

Link to tracking issue

Fixes #36896

Testing

unit test

Documentation

@joker-star-l joker-star-l requested review from atoulme and a team as code owners December 20, 2024 17:04
@joker-star-l joker-star-l changed the title [exporter/doris] [exporter/doris] Send json lines to doris rather than json array Dec 20, 2024
@joker-star-l
Copy link
Contributor Author

@atoulme Is there any problem with this pr?

@joker-star-l
Copy link
Contributor Author

Hi @atoulme , is this pr ready to merge?

@atoulme atoulme added the ready to merge Code review completed; ready to merge by maintainers label Jan 6, 2025
@atoulme
Copy link
Contributor

atoulme commented Jan 6, 2025

sure is. Marked ready to merge.

@TylerHelmuth TylerHelmuth merged commit 667e81e into open-telemetry:main Jan 13, 2025
173 of 174 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 13, 2025
@TylerHelmuth TylerHelmuth mentioned this pull request Jan 14, 2025
codeboten pushed a commit that referenced this pull request Jan 14, 2025
Fix lint issue caused by
#36912

This reverts commit
778d8f7.

@adrielp @niwoerner I can't explain why, but it seems that after
#36838
the extension integration tests never complete. You can see in
https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/workflows/build-and-test.yml?query=branch%3Amain
that we haven't got an integration test suite to pass since merging the
new receiver. Reverting to unblock CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter/doris ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DorisExporter marshal all data to single json array lead to stream load request too small
4 participants