[chore]: do not skip Sudo integration tests #36941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
approved these changes
Dec 25, 2024
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
non stale |
MovieStoreGuy
approved these changes
Jan 12, 2025
AkhigbeEromo
pushed a commit
to sematext/opentelemetry-collector-contrib
that referenced
this pull request
Jan 13, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Reusing the `GOTEST_INTEGRATION_OPT` was skipping Sudo tests `-skip Sudo` <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#36920 (comment) <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.--> Co-authored-by: Sean Marciniak <30928402+MovieStoreGuy@users.noreply.github.com>
TylerHelmuth
added a commit
to TylerHelmuth/opentelemetry-collector-contrib
that referenced
this pull request
Jan 14, 2025
TylerHelmuth
added a commit
that referenced
this pull request
Jan 14, 2025
Undo the extenstion grouping changes from #37177 as they didnt actually help. I think these sudo tests are the root cause of this week's CI issues. Yesterday a change (#36941) was merged to stop skipping the sudo tests and the result is that the sudo tests now run. When I run these tests locally I sometimes get prompted to enter a password. I think this is what is happening in the runner as well - we are being prompted to approve sudo access. Testing if reverting these integration tests solves our issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reusing the
GOTEST_INTEGRATION_OPTwas skipping Sudo tests-skip SudoLink to tracking issue
Fixes #36920 (comment)
Testing
Documentation