Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] [dorisexporter] fix lint error #37188

Closed
wants to merge 1 commit into from

Conversation

axw
Copy link
Contributor

@axw axw commented Jan 14, 2025

Description

Fix lint error, e.g. see https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/12761302791/job/35568099940?pr=37187

Error: dorisexporter/exporter_common.go:127:6: var-naming: func toJsonLines should be toJSONLines (revive)
func toJsonLines[T dLog | dTrace | metric](data []*T) ([]byte, error) {

Link to tracking issue

N/A

Testing

make lint

Documentation

N/A

See
https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/12761302791/job/35568099940?pr=37187

> Error: dorisexporter/exporter_common.go:127:6: var-naming: func toJsonLines should be toJSONLines (revive)
> func toJsonLines[T dLog | dTrace | metric](data []*T) ([]byte, error) {
@joker-star-l
Copy link
Contributor

same wth #37177?

@axw
Copy link
Contributor Author

axw commented Jan 14, 2025

Indeed, I missed that, thanks!

@axw axw closed this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants