Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 2.0.0 #1243

Merged
merged 1 commit into from
May 27, 2024
Merged

Bump version to 2.0.0 #1243

merged 1 commit into from
May 27, 2024

Conversation

hosekadam
Copy link
Member

@hosekadam hosekadam commented May 27, 2024

What's Changed

Breaking Changes 🛠

Enhancements 🎉

Bug Fixes 🐛

Test Coverage Enhancements 🔧

New Contributors

Full Changelog: v1.7.1...v2.0.0

@hosekadam hosekadam added the tests/skip This PR does not require integration tests to be run. label May 27, 2024
@has-bot
Copy link
Member

has-bot commented May 27, 2024

This PR does not require integration tests to be run.


Comment generated by an automation.

Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.74%. Comparing base (bb263d7) to head (3fb3939).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1243   +/-   ##
=======================================
  Coverage   95.74%   95.74%           
=======================================
  Files          55       55           
  Lines        4752     4752           
  Branches      834      834           
=======================================
  Hits         4550     4550           
  Misses        116      116           
  Partials       86       86           
Flag Coverage Δ
centos-linux-7 90.93% <100.00%> (ø)
centos-linux-8 91.86% <100.00%> (ø)
centos-linux-9 91.91% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hosekadam hosekadam requested a review from Venefilyn May 27, 2024 11:08
@Venefilyn
Copy link
Member

Rollback task using "Convert" instead of "Rollback" by @r0x0d in #1130

We need a Jira issue for this if it's in the release notes

Check if rollback failed when handling InhibitorFound exception by @hosekadam in #1224

Same with this one

Return a list instead of string for disablerepo command by @r0x0d in #1237

And this

Add debug logs to host-metering by @r0x0d in
#1141

And this

Comment on lines 125 to 172
* Mon May 27 2024 Adam Hosek <ahosek@redhat.com> 2.0.0
- Remove deprecated CLI arguments
- Remove deprecated latest kernel check env variable
- Remove deprecated convert2rhel unsupported version env variable
- Remove `--disable-submgr` arg
- Rename incomplete rollback envvar
- Remove `-v|--variant` arg
- Port RestorablePackage and ChangedRPMPackagesController
- Remove backup controller partition
- Update RHSM custom facts during analysis
- Remove ppc64 architecture from data
- Add debug logs to host-metering
- Add post conversion stages for Action Framework
- Set consistent task prefix for pre-conversion
- Migrate post conversion transaction function
- Improve efi error check for PART_ENTRY_NUMBER
- Unify parsing of the system release string
- Drop support for 8.6 EUS conversions
- Improve detection of RHSM credentials in subscription check
- Update report to include post conversion actions
- Satellite package backup failure fix
- Drop internet connection check and its dependencies
- Don't report on skipping dbus check
- Modify exit code for conversion when inhibitor is found
- Add RHEL 9 version support up to 9.10
- Allow converting to RHEL 7 ELS
- Exit with 1 when rollback fails
- Fix empty error message in Yum transaction failure
- Disable RHEL repos when performing checks
- Update the Red Hat package signing key
- Install subscription-manager using package manager
- Change result of the c2r version check to OVERRIDABLE
- Restore disabled repos during conversion in rollback
- Rollback task using "Convert" instead of "Rollback"
- Override yum config exclude list
- Fix an error message referring to a non-existing --organization option
- Fix RHSM facts filepath in a log message
- Remove leftover reposdir from package updates action
- Require username and password to be specified
- Fix check for reposdir in RestorablePackage class
- Add the libreport-plugin-mantisbt to excluded list
- Always backup redhat.repo
- Fix cornercase with userpass and keyorg
- Fix report duplication after analysis
- Fix regression in installing removed packages during rollback
- Check if rollback failed when handling InhibitorFound exception
- Skip versionlock file in backup system actions
- Raise when RestorablePackage fails to restore
- Return a list instead of string for disablerepo command
- Fix bug with duplicate packages check when running with Satellite offline
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd reword all the breaking changes and have them near the top

Copy link
Member Author

@hosekadam hosekadam May 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Venefilyn Like having Breaking change: in the beginning? And I think all of them are on the top, I haven't changed the order

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep!

@Venefilyn Venefilyn added the skip/changelog If it should be excluded from changelog or Release notes. Such as infra, reverted PRs, etc. label May 27, 2024
@hosekadam hosekadam force-pushed the bump-version-to-2.0.0 branch 2 times, most recently from 746507b to 2cdae06 Compare May 27, 2024 11:25
@hosekadam
Copy link
Member Author

Updated!

@r0x0d
Copy link
Member

r0x0d commented May 27, 2024

Rollback task using "Convert" instead of "Rollback" by @r0x0d in #1130

We need a Jira issue for this if it's in the release notes

Check if rollback failed when handling InhibitorFound exception by @hosekadam in #1224

Same with this one

Return a list instead of string for disablerepo command by @r0x0d in #1237

And this

Add debug logs to host-metering by @r0x0d in
#1141

And this

Let me create at least the placeholder jira so we can add them here

@hosekadam hosekadam force-pushed the bump-version-to-2.0.0 branch from 2cdae06 to 3fb3939 Compare May 27, 2024 13:07
@hosekadam
Copy link
Member Author

Updated the names and added the missing Jira thanks to @r0x0d

@Venefilyn Venefilyn merged commit 0638a22 into oamg:main May 27, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog If it should be excluded from changelog or Release notes. Such as infra, reverted PRs, etc. tests/skip This PR does not require integration tests to be run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants