-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHELC-1515] Fix the enabled repository check after the conversion #1192
Conversation
9d9e03b
to
e6872b6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1192 +/- ##
=======================================
Coverage 95.54% 95.54%
=======================================
Files 53 53
Lines 4642 4642
Branches 815 815
=======================================
Hits 4435 4435
Misses 129 129
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
e6872b6
to
15df91f
Compare
/packit test --labels tier0 |
c4039fc
to
baa58d1
Compare
/packit test --labels tier0 |
baa58d1
to
c4039fc
Compare
tests/integration/common/checks-after-conversion/test_enabled_repositories.py
Outdated
Show resolved
Hide resolved
/packit test --labels tier0 |
9c3c798
to
21dc7e5
Compare
/packit test --labels tier0 |
1 similar comment
/packit test --labels tier0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, I like the code reduction.
Just a few minor notes + the new test did not get triggered at all.
Also, please update the pytest.ini with the updated and new markers.
tests/integration/tier0/destructive/conversion-method/test_custom_repos.py
Show resolved
Hide resolved
tests/integration/tier0/destructive/conversion-method/test_rhsm_eus.py
Outdated
Show resolved
Hide resolved
@pytest.mark.test_rhsm_eus_account_conversion | ||
def test_rhsm_non_eus_account(convert2rhel): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pytest.mark.test_rhsm_eus_account_conversion | |
def test_rhsm_non_eus_account(convert2rhel): | |
@pytest.mark.test_rhsm_non_eus_account | |
def test_rhsm_non_eus_account(convert2rhel): |
Copy&Paste error.
Additionally, this test did not even run, given the lack of metadata in main.fmf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verify that Convert2RHEL is working properly when EUS repositories are not available for conversions | ||
to RHEL EUS minor versions (8.6, ...) and the --eus option is provided. The regular repositories | ||
should be enabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verify that Convert2RHEL is working properly when EUS repositories are not available for conversions | |
to RHEL EUS minor versions (8.6, ...) and the --eus option is provided. The regular repositories | |
should be enabled. | |
Verify that Convert2RHEL is working properly when EUS repositories are not available for conversions (the account does not have the EUS SKU available) | |
to RHEL EUS minor versions (8.6, ...) and the --eus option is provided. The regular repositories | |
should be enabled as a fallback option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
21dc7e5
to
7ef3374
Compare
/packit test --labels tier0 |
/packit test |
7ef3374
to
a26d8b5
Compare
We found several problems with the enabled repository check. This PR should fix those plus some minor code improvement changes. Reference ticket: https://issues.redhat.com/browse/RHELC-1515 Co-authored-by: Rodolfo Olivieri <rodolfo.olivieri3@gmail.com>
a26d8b5
to
bf88a36
Compare
/packit test --labels tier0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
We found several problems with the enabled repository check. This PR should fix those plus some minor code improvement changes.
Jira Issues:
Checklist
[RHELC-1515]
is part of the PR titleRelease Pending
if relevant