Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHELC-1521] Always backup redhat.repo #1220

Merged
merged 1 commit into from
May 15, 2024

Conversation

hosekadam
Copy link
Member

After discussion on tech cabal, the exception for not backing up the redhat.repo file is not needed anymore, and we can back up this file.

This fact will help in case of downloading backup of pkg when system is connected to satellite. At that moment, there can be only redhat.repo in reposdir.

  • condition checking if the filename is redhat.repo was removed
  • unit tests testing this were removed

Jira Issues:

Checklist

  • PR has been tested manually in a VM (either author or reviewer)
  • Jira issue has been made public if possible
  • [RHELC-] is part of the PR title
  • GitHub label has been added to help with Release notes
  • PR title explains the change from the user's point of view
  • Code and tests are documented properly
  • The commits are squashed to as few commits as possible (without losing data)
  • When merged: Jira issue has been updated to Release Pending if relevant

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.46%. Comparing base (39adc46) to head (2e27175).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1220      +/-   ##
==========================================
- Coverage   95.47%   95.46%   -0.01%     
==========================================
  Files          54       54              
  Lines        4682     4679       -3     
  Branches      824      823       -1     
==========================================
- Hits         4470     4467       -3     
  Misses        131      131              
  Partials       81       81              
Flag Coverage Δ
centos-linux-7 90.66% <ø> (-0.01%) ⬇️
centos-linux-8 91.58% <ø> (-0.01%) ⬇️
centos-linux-9 91.63% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hosekadam hosekadam requested review from pr-watson and Venefilyn May 14, 2024 12:29
Copy link
Contributor

@pr-watson pr-watson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@r0x0d r0x0d added kind/feature New feature or request tests/tier0 PR ready to run the essential test suit. Equivalent to `/packit test --labels tier0`. labels May 14, 2024
@has-bot
Copy link
Member

has-bot commented May 14, 2024

/packit test --labels tier0


Comment generated by an automation.

@r0x0d r0x0d added kind/bug-fix A bug has been fixed and removed kind/feature New feature or request labels May 14, 2024
@Venefilyn Venefilyn merged commit 9f97a65 into oamg:main May 15, 2024
45 of 48 checks passed
@hosekadam hosekadam mentioned this pull request May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix A bug has been fixed merge-after-tests-ok tests/tier0 PR ready to run the essential test suit. Equivalent to `/packit test --labels tier0`.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants