[RHELC-1528] Fix empty error message in Yum transaction failure #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Venefilyn
reviewed
May 10, 2024
r0x0d
reviewed
May 13, 2024
r0x0d
reviewed
May 13, 2024
Co-authored-by: Rodolfo Olivieri <rodolfo.olivieri3@gmail.com>
6cc51cb to
994e8ea
Compare
|
/packit test --labels tier0 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1214 +/- ##
=======================================
Coverage 95.47% 95.47%
=======================================
Files 54 54
Lines 4682 4682
Branches 824 824
=======================================
Hits 4470 4470
Misses 131 131
Partials 81 81
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
danmyway
approved these changes
May 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves an issue where the error result from the YumBaseError exception would not be displayed in the diagnosis of the Error - FAILED_TO_VALIDATE_TRANSACTION for yum transcations. The issue was that the type of the error was of YumBaseError so when a .join was used on it the output would be blank. This PR extracts the actual value from the YumBaseError class and properly displays it with the Error result. There are also updates to the unit tests for both yum and dnf transcation failures so we assert the proper content is in the Error result
Jira Issues:
Checklist
[RHELC-]is part of the PR titleRelease Pendingif relevant