Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHELC-1503] Fix RHSM facts filepath in a log message #1183

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

bocekm
Copy link
Member

@bocekm bocekm commented Apr 17, 2024

The message said convert2rhel.fact while it should be convert2rhel.facts.

Jira Issues:

Checklist

  • PR has been tested manually in a VM (either author or reviewer)
  • Jira issue has been made public if possible
  • [RHELC-] is part of the PR title
  • GitHub label has been added to help with Release notes
  • PR title explains the change from the user's point of view
  • Code and tests are documented properly
  • The commits are squashed to as few commits as possible (without losing data)
  • When merged: Jira issue has been updated to Release Pending if relevant

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.36%. Comparing base (1991bca) to head (e6e6e35).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1183   +/-   ##
=======================================
  Coverage   95.36%   95.36%           
=======================================
  Files          53       53           
  Lines        4619     4619           
  Branches      809      809           
=======================================
  Hits         4405     4405           
  Misses        137      137           
  Partials       77       77           
Flag Coverage Δ
centos-linux-7 90.45% <ø> (ø)
centos-linux-8 91.43% <ø> (ø)
centos-linux-9 91.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r0x0d r0x0d added kind/bug-fix A bug has been fixed tests/sanity PR ready to run the sanity test suit. Equivalent to `/packit test --labels sanity`. labels Apr 17, 2024
@has-bot
Copy link
Member

has-bot commented Apr 17, 2024

/packit test --labels sanity


Comment generated by an automation.

@Venefilyn
Copy link
Member

@bocekm Can you create a Jira bug issue for this?

@bocekm bocekm changed the title Fix RHSM facts filepath in a log message [RHELC-1503] Fix RHSM facts filepath in a log message Apr 18, 2024
@bocekm
Copy link
Member Author

bocekm commented Apr 18, 2024

@SpyTec, done.

@Venefilyn
Copy link
Member

/packit test --labels sanity

@r0x0d r0x0d force-pushed the fix-path-to-facts-in-a-log-msg branch from 7071f2b to 83d1856 Compare April 23, 2024 14:26
bocekm and others added 2 commits April 23, 2024 11:27
The message said convert2rhel.fact while it should be
convert2rhel.facts.
Some integration tests were using expecting the old message format, this
commit fixes it.
@r0x0d r0x0d force-pushed the fix-path-to-facts-in-a-log-msg branch from 83d1856 to e6e6e35 Compare April 23, 2024 14:28
@r0x0d
Copy link
Member

r0x0d commented Apr 23, 2024

/packit test --labels sanity

@r0x0d r0x0d merged commit 21a763e into oamg:main Apr 23, 2024
25 checks passed
@hosekadam hosekadam mentioned this pull request May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix A bug has been fixed tests/sanity PR ready to run the sanity test suit. Equivalent to `/packit test --labels sanity`.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants