Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shuffle gpu serde #28

Open
wants to merge 25 commits into
base: 0625
Choose a base branch
from
Open

Conversation

wjxiz1992
Copy link
Collaborator

shuffle optimization

firestarman and others added 25 commits May 14, 2024 14:42
---------

Signed-off-by: Firestarman <firestarmanllc@gmail.com>
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
…uffle-gpu-serde

Signed-off-by: Firestarman <firestarmanllc@gmail.com>
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
* Add GpuBucketingUtils shim to Spark 4.0.0

* Signing off

Signed-off-by: Raza Jafri <rjafri@nvidia.com>

---------

Signed-off-by: Raza Jafri <rjafri@nvidia.com>
* Improve the diagnostics for 'conv' fallback explain

Signed-off-by: Jihoon Son <ghoonson@gmail.com>

* don't use nil

Signed-off-by: Jihoon Son <ghoonson@gmail.com>

* the bases should not be an empty string in the error message when the user input is not

Signed-off-by: Jihoon Son <ghoonson@gmail.com>

* more user-friendly message

* Update sql-plugin/src/main/scala/org/apache/spark/sql/rapids/stringFunctions.scala

Co-authored-by: Gera Shegalov <gshegalov@nvidia.com>

---------

Signed-off-by: Jihoon Son <ghoonson@gmail.com>
Co-authored-by: Gera Shegalov <gshegalov@nvidia.com>
* Disable ANSI mode for window function tests.

Fixes NVIDIA#11019.

Window function tests fail on Spark 4.0 because of NVIDIA#5114 (and NVIDIA#5120 broadly),
because spark-rapids does not support SUM, COUNT, and certain other aggregations
in ANSI mode.

This commit disables ANSI mode tests for the failing window function tests. These may be
revisited, once error/overflow checking is available for ANSI mode in spark-rapids.

Signed-off-by: MithunR <mithunr@nvidia.com>

* Switch from @ansi_mode_disabled to @disable_ansi_mode.

---------

Signed-off-by: MithunR <mithunr@nvidia.com>
…o-date (NVIDIA#10997)

* wip

Signed-off-by: Haoyang Li <haoyangl@nvidia.com>

* fix json suite

Signed-off-by: Haoyang Li <haoyangl@nvidia.com>

* wip

Signed-off-by: Haoyang Li <haoyangl@nvidia.com>

* update

Signed-off-by: Haoyang Li <haoyangl@nvidia.com>

* Remove all utc config and clean up

Signed-off-by: Haoyang Li <haoyangl@nvidia.com>

* hardcode timezone to LA in ci

Signed-off-by: Haoyang Li <haoyangl@nvidia.com>

* remove concat

Signed-off-by: Haoyang Li <haoyangl@nvidia.com>

* remove spark timezone settings and only keep java timezone settings

Signed-off-by: Haoyang Li <haoyangl@nvidia.com>

* remove unintensional comment

Signed-off-by: Haoyang Li <haoyangl@nvidia.com>

* delete a comment

Signed-off-by: Haoyang Li <haoyangl@nvidia.com>

* set timezone to utc for two suites to avoid fallback

Signed-off-by: Haoyang Li <haoyangl@nvidia.com>

* style

Signed-off-by: Haoyang Li <haoyangl@nvidia.com>

* after all

Signed-off-by: Haoyang Li <haoyangl@nvidia.com>

* add cast string to timestamp back to exclude after upmerge

Signed-off-by: Haoyang Li <haoyangl@nvidia.com>

---------

Signed-off-by: Haoyang Li <haoyangl@nvidia.com>
Signed-off-by: Haoyang Li <haoyangl@nvidia.com>
…DIA#11066)

* Replaced spark3xx-common references to spark-shared

* Signing off

Signed-off-by: Raza Jafri <rjafri@nvidia.com>

* addressed review comments

* addressed review comments

* removed todo as per review comment

* Moving dependency to the related module because it was causing an error while running code coverage

* Addressed review comments

* Regenerated 2.13 poms

---------

Signed-off-by: Raza Jafri <rjafri@nvidia.com>
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
* Fixed array_tests

* Signing off

Signed-off-by: Raza Jafri <rjafri@nvidia.com>

* Disable ANSI for failing tests

---------

Signed-off-by: Raza Jafri <rjafri@nvidia.com>
* add a heristic to skip agg pass

Signed-off-by: Hongbin Ma (Mahone) <mahongbin@apache.org>

* commit doc change

Signed-off-by: Hongbin Ma (Mahone) <mahongbin@apache.org>

* refine naming

Signed-off-by: Hongbin Ma (Mahone) <mahongbin@apache.org>

* fix only reduction case

Signed-off-by: Hongbin Ma (Mahone) <mahongbin@apache.org>

* fix compile

Signed-off-by: Hongbin Ma (Mahone) <mahongbin@apache.org>

* fix

Signed-off-by: Hongbin Ma (Mahone) <mahongbin@apache.org>

* clean

Signed-off-by: Hongbin Ma (Mahone) <mahongbin@apache.org>

* fix doc

Signed-off-by: Hongbin Ma (Mahone) <mahongbin@apache.org>

* reduce premergeci2

Signed-off-by: Hongbin Ma (Mahone) <mahongbin@apache.org>

* reduce premergeci2, 2

Signed-off-by: Hongbin Ma (Mahone) <mahongbin@apache.org>

* use test_parallel to workaround flaky array test

Signed-off-by: Hongbin Ma (Mahone) <mahongbin@apache.org>

* address review comment

Signed-off-by: Hongbin Ma (Mahone) <mahongbin@apache.org>

* remove comma

Signed-off-by: Hongbin Ma (Mahone) <mahongbin@apache.org>

* workaround for  ci_scala213

Signed-off-by: Hongbin Ma (Mahone) <mahongbin@apache.org>

* disable agg ratio heruistic by default

Signed-off-by: Hongbin Ma (Mahone) <mahongbin@apache.org>

* fix doc

Signed-off-by: Hongbin Ma (Mahone) <mahongbin@apache.org>

---------

Signed-off-by: Hongbin Ma (Mahone) <mahongbin@apache.org>
…ttern in rlike. (NVIDIA#11088)

* Remove bracket when necessary in PrefixRange patten in Regex rewrite

Signed-off-by: Haoyang Li <haoyangl@nvidia.com>

* add pytest cases

Signed-off-by: Haoyang Li <haoyangl@nvidia.com>

* fix scala 2.13 build

Signed-off-by: Haoyang Li <haoyangl@nvidia.com>

---------

Signed-off-by: Haoyang Li <haoyangl@nvidia.com>
)

Signed-off-by: xieshuaihu <xieshuaihu@gmail.com>
* Spark 4: Handle ANSI mode in sort_test.py

Fixes NVIDIA#11027.

With ANSI mode enabled (like the default in Spark 4), one sees that some
tests in `sort_test.py` fail, because they expect ANSI mode to be off.

This commit disables running those tests with ANSI enabled, and add a
separate test for ANSI on/off.

Signed-off-by: MithunR <mithunr@nvidia.com>

* Refactored not to use disable_ansi_mode.

These tests need not be revisited.  They test all combinations of ANSI mode,
including overflow failures.

Signed-off-by: MithunR <mithunr@nvidia.com>

---------

Signed-off-by: MithunR <mithunr@nvidia.com>
* Introduce lore id

* Introduce lore id

* Fix type

* Fix type

* Conf

* style

* part

* Dump

* Introduce lore framework

* Add tests.

* Rename test case

Signed-off-by: liurenjie1024 <liurenjie2008@gmail.com>

* Fix AQE test

* Fix style

* Use args to display lore info.

* Fix build break

* Fix path in loreinfo

* Remove path

* Fix comments

* Update configs

* Fix comments

* Fix config

---------

Signed-off-by: liurenjie1024 <liurenjie2008@gmail.com>
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants