Fix some test issues in Spark UT and keep RapidsTestSettings update-to-date #10997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Haoyang Li <haoyangl@nvidia.com>
|
build |
Signed-off-by: Haoyang Li <haoyangl@nvidia.com>
|
build |
binmahone
reviewed
Jun 13, 2024
tests/src/test/spark330/scala/org/apache/spark/sql/rapids/utils/RapidsTestsTrait.scala
Show resolved
Hide resolved
Signed-off-by: Haoyang Li <haoyangl@nvidia.com>
|
Premerge failed because the tests still think timezone is UTC, maybe caused by some settings in CI. Hardcoded to LA and trying again. |
|
build |
Signed-off-by: Haoyang Li <haoyangl@nvidia.com>
|
build |
Signed-off-by: Haoyang Li <haoyangl@nvidia.com>
|
build |
Signed-off-by: Haoyang Li <haoyangl@nvidia.com>
Signed-off-by: Haoyang Li <haoyangl@nvidia.com>
Signed-off-by: Haoyang Li <haoyangl@nvidia.com>
|
After removing UTC config, I found the new added UT cases passed by falling back to CPU. So, I think we may not need to copy them out. |
|
Hi @GaryShen2008 , what’s your java version? The new added cases can pass under older Java version but fail on newer ones. |
binmahone
reviewed
Jun 18, 2024
| override def beforeAll(): Unit = { | ||
| super.beforeAll() | ||
| // Set timezone to UTC to avoid fallback, so that tests run on GPU to detect bugs | ||
| TimeZone.setDefault(TimeZone.getTimeZone("UTC")) |
There was a problem hiding this comment.
set it back in AfterAll()?
binmahone
reviewed
Jun 18, 2024
| override def beforeAll(): Unit = { | ||
| super.beforeAll() | ||
| // Set timezone to UTC to avoid fallback, so that tests run on GPU to detect bugs | ||
| TimeZone.setDefault(TimeZone.getTimeZone("UTC")) |
There was a problem hiding this comment.
set it back in AfterAll()?
|
build |
Signed-off-by: Haoyang Li <haoyangl@nvidia.com>
|
build |
|
LGTM |
binmahone
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #10771 #10773 #10775
This PR: