Spark 4: Handle ANSI mode in sort_test.py #11099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes NVIDIA#11027. With ANSI mode enabled (like the default in Spark 4), one sees that some tests in `sort_test.py` fail, because they expect ANSI mode to be off. This commit disables running those tests with ANSI enabled, and add a separate test for ANSI on/off. Signed-off-by: MithunR <mithunr@nvidia.com>
|
Build |
jlowe
reviewed
Jun 27, 2024
jlowe
reviewed
Jun 28, 2024
These tests need not be revisited. They test all combinations of ANSI mode, including overflow failures. Signed-off-by: MithunR <mithunr@nvidia.com>
jlowe
approved these changes
Jul 1, 2024
|
build |
wjxiz1992
added a commit
to nvliyuan/yuali-spark-rapids
that referenced
this pull request
Jul 5, 2024
* Fix match error in RapidsShuffleIterator.scala [scala2.13] (NVIDIA#11115) Signed-off-by: xieshuaihu <xieshuaihu@gmail.com> * Spark 4: Handle ANSI mode in sort_test.py (NVIDIA#11099) * Spark 4: Handle ANSI mode in sort_test.py Fixes NVIDIA#11027. With ANSI mode enabled (like the default in Spark 4), one sees that some tests in `sort_test.py` fail, because they expect ANSI mode to be off. This commit disables running those tests with ANSI enabled, and add a separate test for ANSI on/off. Signed-off-by: MithunR <mithunr@nvidia.com> * Refactored not to use disable_ansi_mode. These tests need not be revisited. They test all combinations of ANSI mode, including overflow failures. Signed-off-by: MithunR <mithunr@nvidia.com> --------- Signed-off-by: MithunR <mithunr@nvidia.com> * Introduce LORE framework. (NVIDIA#11084) * Introduce lore id * Introduce lore id * Fix type * Fix type * Conf * style * part * Dump * Introduce lore framework * Add tests. * Rename test case Signed-off-by: liurenjie1024 <liurenjie2008@gmail.com> * Fix AQE test * Fix style * Use args to display lore info. * Fix build break * Fix path in loreinfo * Remove path * Fix comments * Update configs * Fix comments * Fix config --------- Signed-off-by: liurenjie1024 <liurenjie2008@gmail.com> * Support minBy on GPU Signed-off-by: Firestarman <firestarmanllc@gmail.com> --------- Signed-off-by: xieshuaihu <xieshuaihu@gmail.com> Signed-off-by: MithunR <mithunr@nvidia.com> Signed-off-by: liurenjie1024 <liurenjie2008@gmail.com> Signed-off-by: Firestarman <firestarmanllc@gmail.com> Co-authored-by: xieshuaihu <xieshuaihu@gmail.com> Co-authored-by: MithunR <mithunr@nvidia.com> Co-authored-by: Renjie Liu <liurenjie2008@gmail.com> Co-authored-by: Firestarman <firestarmanllc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11027.
With ANSI mode enabled (like the default in Spark 4), one sees that some tests in
sort_test.pyfail, because they expect ANSI mode to be off.This commit disables running those tests with ANSI enabled, and add a separate test for ANSI on/off.