Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support regex patterns with brackets when rewriting to PrefixRange pattern in rlike. #11088

Merged

Conversation

thirtiseven
Copy link
Collaborator

Closes #11087

This PR supports regex patterns with brackets when rewriting to PrefixRange pattern in rlike. After this PR, patterns like ((abc))([0-9]{3}) and (abc[0-9]{3}) can be optimized by regex rewrite.

Signed-off-by: Haoyang Li <haoyangl@nvidia.com>
@thirtiseven thirtiseven self-assigned this Jun 24, 2024
@gerashegalov
Copy link
Collaborator

Please add new cases to pytests

Signed-off-by: Haoyang Li <haoyangl@nvidia.com>
@sameerz sameerz added the feature request New feature or request label Jun 25, 2024
@thirtiseven
Copy link
Collaborator Author

build

Signed-off-by: Haoyang Li <haoyangl@nvidia.com>
@thirtiseven
Copy link
Collaborator Author

build

Copy link
Collaborator

@gerashegalov gerashegalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thirtiseven thirtiseven merged commit 2498204 into NVIDIA:branch-24.08 Jun 29, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Support regex pattern with brackets when rewrite to PrefixRange patten in rlike
3 participants