Exclude a case based on JDK version in Spark UT #11083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Haoyang Li <haoyangl@nvidia.com>
|
tests passed on jdk17 pipeline |
|
LGTM |
|
build |
binmahone
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10801
Closes #10889
This PR supports excluding a case based on JDK version in Spark UT and excluding "SPARK-24788: RelationalGroupedDataset.toString with unresolved exprs should not fail" on JDK 17 only.
Also cleaned up some code.
For this case in 330 limit jdk version is enough, we can add support for excluding a case based on Scala version easily if needed.