Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Fluent UI Insights EP06 to README #29051

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Sep 1, 2023

New Behavior

Episode 06 is on README 🎉

@layershifter layershifter requested a review from a team as a code owner September 1, 2023 09:10
@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 1, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0b54a92:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
InfoButton mount 12 13 5000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 626 626 5000
Button mount 314 326 5000
Field mount 1109 1133 5000
FluentProvider mount 691 675 5000
FluentProviderWithTheme mount 79 82 10
FluentProviderWithTheme virtual-rerender 66 67 10
FluentProviderWithTheme virtual-rerender-with-unmount 74 69 10
InfoButton mount 12 13 5000 Possible regression
MakeStyles mount 865 872 50000
Persona mount 1780 1715 5000
SpinButton mount 1392 1378 5000

@fabricteam
Copy link
Collaborator

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-northstar)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
TreeWith60ListItems.default 90 83 1.08:1 analysis
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AttachmentMinimalPerf.default 88 77 1.14:1
AvatarMinimalPerf.default 121 108 1.12:1
ImageMinimalPerf.default 238 219 1.09:1
ProviderMinimalPerf.default 207 194 1.07:1
ChatMinimalPerf.default 438 415 1.06:1
ListNestedPerf.default 333 318 1.05:1
TextAreaMinimalPerf.default 289 275 1.05:1
ChatWithPopoverPerf.default 192 185 1.04:1
ListWith60ListItems.default 362 349 1.04:1
RefMinimalPerf.default 113 109 1.04:1
BoxMinimalPerf.default 197 191 1.03:1
FlexMinimalPerf.default 156 152 1.03:1
FormMinimalPerf.default 224 218 1.03:1
MenuButtonMinimalPerf.default 960 936 1.03:1
PortalMinimalPerf.default 89 86 1.03:1
RadioGroupMinimalPerf.default 270 263 1.03:1
ReactionMinimalPerf.default 216 210 1.03:1
AccordionMinimalPerf.default 82 80 1.02:1
ButtonMinimalPerf.default 84 82 1.02:1
ChatDuplicateMessagesPerf.default 154 151 1.02:1
DialogMinimalPerf.default 453 443 1.02:1
DropdownMinimalPerf.default 1427 1400 1.02:1
GridMinimalPerf.default 195 191 1.02:1
LoaderMinimalPerf.default 189 185 1.02:1
MenuMinimalPerf.default 493 485 1.02:1
ProviderMergeThemesPerf.default 655 643 1.02:1
SplitButtonMinimalPerf.default 2276 2231 1.02:1
TooltipMinimalPerf.default 1309 1280 1.02:1
TreeMinimalPerf.default 481 471 1.02:1
HeaderSlotsPerf.default 472 468 1.01:1
LabelMinimalPerf.default 220 218 1.01:1
PopupMinimalPerf.default 346 344 1.01:1
DatepickerMinimalPerf.default 3610 3597 1:1
HeaderMinimalPerf.default 204 203 1:1
LayoutMinimalPerf.default 205 204 1:1
ListMinimalPerf.default 308 307 1:1
ToolbarMinimalPerf.default 535 537 1:1
AnimationMinimalPerf.default 301 305 0.99:1
ButtonSlotsPerf.default 303 306 0.99:1
CarouselMinimalPerf.default 263 267 0.99:1
CheckboxMinimalPerf.default 1118 1126 0.99:1
DropdownManyItemsPerf.default 379 384 0.99:1
EmbedMinimalPerf.default 1857 1868 0.99:1
InputMinimalPerf.default 545 551 0.99:1
ItemLayoutMinimalPerf.default 707 713 0.99:1
TableMinimalPerf.default 234 237 0.99:1
TextMinimalPerf.default 193 195 0.99:1
CustomToolbarPrototype.default 1464 1483 0.99:1
AlertMinimalPerf.default 161 165 0.98:1
ButtonOverridesMissPerf.default 628 638 0.98:1
StatusMinimalPerf.default 385 391 0.98:1
TableManyItemsPerf.default 1103 1128 0.98:1
AttachmentSlotsPerf.default 625 645 0.97:1
SegmentMinimalPerf.default 188 193 0.97:1
SkeletonMinimalPerf.default 194 199 0.97:1
IconMinimalPerf.default 385 396 0.97:1
DividerMinimalPerf.default 205 213 0.96:1
RosterPerf.default 1565 1635 0.96:1
ListCommonPerf.default 382 403 0.95:1
CardMinimalPerf.default 301 319 0.94:1
VideoMinimalPerf.default 409 434 0.94:1
SliderMinimalPerf.default 719 778 0.92:1

@fabricteam
Copy link
Collaborator

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext
510 B
330 B
global-context
createContextSelector
537 B
342 B
priority-overflow
createOverflowManager
4.162 kB
1.735 kB
react-accordion
Accordion (including children components)
91.384 kB
27.926 kB
react-alert
Alert
84.549 kB
23.128 kB
react-avatar
Avatar
49.738 kB
15.631 kB
react-avatar
AvatarGroup
18.584 kB
7.448 kB
react-avatar
AvatarGroupItem
64.39 kB
19.977 kB
react-badge
Badge
25.793 kB
8.348 kB
react-badge
CounterBadge
26.694 kB
8.658 kB
react-badge
PresenceBadge
24.75 kB
8.96 kB
react-button
Button
39.658 kB
10.79 kB
react-button
CompoundButton
47.013 kB
12.284 kB
react-button
MenuButton
44.085 kB
12.041 kB
react-button
SplitButton
52.111 kB
13.612 kB
react-button
ToggleButton
56.746 kB
12.698 kB
react-card
Card - All
91.249 kB
26.409 kB
react-card
Card
86.038 kB
24.868 kB
react-card
CardFooter
11.951 kB
5.031 kB
react-card
CardHeader
14.237 kB
5.798 kB
react-card
CardPreview
12.903 kB
5.408 kB
react-checkbox
Checkbox
35.614 kB
11.771 kB
react-combobox
Combobox (including child components)
90.383 kB
29.52 kB
react-combobox
Dropdown (including child components)
88.738 kB
29.167 kB
react-components
react-components: Button, FluentProvider & webLightTheme
69.517 kB
19.64 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
208.067 kB
59.345 kB
react-components
react-components: FluentProvider & webLightTheme
40.713 kB
13.509 kB
react-datepicker-compat
DatePicker Compat
211.173 kB
58.752 kB
react-dialog
Dialog (including children components)
89.917 kB
27.447 kB
react-divider
Divider
19.704 kB
7.38 kB
react-field
Field
21.036 kB
8.091 kB
react-image
Image
14.62 kB
5.869 kB
react-infobutton
InfoButton
129.184 kB
40.661 kB
react-infobutton
InfoLabel
132.909 kB
41.852 kB
react-input
Input
25.955 kB
8.81 kB
react-jsx-runtime
Classic Pragma
1.072 kB
544 B
react-jsx-runtime
JSX Dev Runtime
2.775 kB
1.29 kB
react-jsx-runtime
JSX Runtime
3.293 kB
1.529 kB
react-label
Label
13.036 kB
5.405 kB
react-link
Link
15.902 kB
6.506 kB
react-menu
Menu (including children components)
139.369 kB
42.976 kB
react-menu
Menu (including selectable components)
142.105 kB
43.507 kB
react-overflow
hooks only
12.594 kB
4.702 kB
react-persona
Persona
56.629 kB
17.505 kB
react-popover
Popover
118.438 kB
37.318 kB
react-portal
Portal
12.362 kB
4.543 kB
react-portal-compat
PortalCompatProvider
6.541 kB
2.227 kB
react-positioning
usePositioning
25.245 kB
9.141 kB
react-progress
ProgressBar
16.409 kB
6.58 kB
react-provider
FluentProvider
21.258 kB
7.937 kB
react-radio
Radio
29.318 kB
9.699 kB
react-radio
RadioGroup
14.344 kB
5.942 kB
react-select
Select
27.324 kB
9.773 kB
react-slider
Slider
36.849 kB
12.171 kB
react-spinbutton
SpinButton
35.53 kB
11.367 kB
react-spinner
Spinner
22.292 kB
8.113 kB
react-switch
Switch
31.885 kB
10.356 kB
react-table
DataGrid
156.473 kB
43.597 kB
react-table
Table (Primitives only)
42.52 kB
13.286 kB
react-table
Table as DataGrid
129.333 kB
34.77 kB
react-table
Table (Selection only)
74.617 kB
20.089 kB
react-table
Table (Sort only)
73.248 kB
19.685 kB
react-tags-preview
InteractionTag
13.85 kB
5.626 kB
react-tags-preview
Tag
29.604 kB
9.567 kB
react-tags-preview
TagGroup
72.493 kB
21.628 kB
react-text
Text - Default
15.644 kB
6.223 kB
react-text
Text - Wrappers
18.817 kB
6.546 kB
react-textarea
Textarea
30.005 kB
10.156 kB
react-theme
Single theme token import
69 B
89 B
react-theme
Teams: all themes
34.611 kB
7.295 kB
react-theme
Teams: Light theme
19.282 kB
5.486 kB
react-toast
Toast (including Toaster)
90.782 kB
27.171 kB
react-tooltip
Tooltip
51.154 kB
18.06 kB
react-utilities
SSRProvider
180 B
159 B
🤖 This report was generated against 3f805b9bca38c866d56233f1b89868465b9d3bb0

@size-auditor
Copy link

size-auditor bot commented Sep 1, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 3f805b9bca38c866d56233f1b89868465b9d3bb0 (build)

@fabricteam
Copy link
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 630 602 5000
Breadcrumb mount 1626 1604 1000
Checkbox mount 1665 1648 5000
CheckboxBase mount 1441 1445 5000
ChoiceGroup mount 2910 2976 5000
ComboBox mount 660 643 1000
CommandBar mount 6074 6144 1000
ContextualMenu mount 11659 11863 1000
DefaultButton mount 763 745 5000
DetailsRow mount 2116 2161 5000
DetailsRowFast mount 2125 2168 5000
DetailsRowNoStyles mount 1956 2002 5000
Dialog mount 2554 2670 1000
DocumentCardTitle mount 226 227 1000
Dropdown mount 1932 1907 5000
FocusTrapZone mount 1075 1112 5000
FocusZone mount 1058 1033 5000
GroupedList mount 40686 40624 2
GroupedList virtual-rerender 19640 19288 2
GroupedList virtual-rerender-with-unmount 49909 49418 2
GroupedListV2 mount 218 216 2
GroupedListV2 virtual-rerender 198 202 2
GroupedListV2 virtual-rerender-with-unmount 215 219 2
IconButton mount 1088 1062 5000
Label mount 335 332 5000
Layer mount 2762 2660 5000
Link mount 374 386 5000
MenuButton mount 935 919 5000
MessageBar mount 20882 20900 5000
Nav mount 1941 1909 1000
OverflowSet mount 775 736 5000
Panel mount 1772 1739 1000
Persona mount 709 732 1000
Pivot mount 840 863 1000
PrimaryButton mount 841 852 5000
Rating mount 4612 4692 5000
SearchBox mount 889 894 5000
Shimmer mount 1859 1817 5000
Slider mount 1297 1288 5000
SpinButton mount 2813 2846 5000
Spinner mount 366 370 5000
SplitButton mount 1778 1801 5000
Stack mount 394 391 5000
StackWithIntrinsicChildren mount 836 835 5000
StackWithTextChildren mount 2560 2533 5000
SwatchColorPicker mount 6031 5955 5000
TagPicker mount 1424 1441 5000
Text mount 372 369 5000
TextField mount 920 926 5000
ThemeProvider mount 833 831 5000
ThemeProvider virtual-rerender 581 577 5000
ThemeProvider virtual-rerender-with-unmount 1261 1244 5000
Toggle mount 606 609 5000
buttonNative mount 187 189 5000

@layershifter layershifter merged commit 405ee3c into microsoft:master Sep 1, 2023
@layershifter layershifter deleted the docs/ep06-to-readme branch September 1, 2023 11:04
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Sep 3, 2023
* master:
  refactor(react-drawer): change DrawerHeaderTitle slot creation while keeping the same API (microsoft#29042)
  test(react-drawer): add render tests for drawer subcomponents (microsoft#29043)
  Grouped vertical bar chart - Component tests (microsoft#29031)
  docs: add Fluent UI Insights EP06 to README (microsoft#29051)
  chore: use swc-plugin-de-indent-template-literal for consoles (microsoft#29040)
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Sep 3, 2023
* master:
  refactor(react-drawer): change DrawerHeaderTitle slot creation while keeping the same API (microsoft#29042)
  test(react-drawer): add render tests for drawer subcomponents (microsoft#29043)
  Grouped vertical bar chart - Component tests (microsoft#29031)
  docs: add Fluent UI Insights EP06 to README (microsoft#29051)
  chore: use swc-plugin-de-indent-template-literal for consoles (microsoft#29040)
  chore: adds swc-plugin-de-indent-template-literal (microsoft#29037)
  feat(react-jsx-runtime): v9 packages to use importSource (microsoft#28959)
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Sep 3, 2023
* master: (32 commits)
  refactor(react-drawer): change DrawerHeaderTitle slot creation while keeping the same API (microsoft#29042)
  test(react-drawer): add render tests for drawer subcomponents (microsoft#29043)
  Grouped vertical bar chart - Component tests (microsoft#29031)
  docs: add Fluent UI Insights EP06 to README (microsoft#29051)
  chore: use swc-plugin-de-indent-template-literal for consoles (microsoft#29040)
  chore: adds swc-plugin-de-indent-template-literal (microsoft#29037)
  feat(react-jsx-runtime): v9 packages to use importSource (microsoft#28959)
  chore: update swc build dependencies (microsoft#28989)
  fix(react-tags-preview): add hover/pressed style for windows high contrast (microsoft#29035)
  chore(react-tags-preview): use InteractionTag for TagGroup's stories (microsoft#29024)
  chore(react-tags-preview): use makeResetStyles for base styles (microsoft#29022)
  chore: fix codesandbox export for preview component by making @fluentui/react-components required dependency (microsoft#29016)
  applying package updates
  feat(react-motion): create useReducedMotion and apply to useMotion to skip animations (microsoft#29014)
  ReAdd: Keytips: Align keytipData with visible instance for dupes (microsoft#28992)
  feat(react-drawer): add motion to Drawer (microsoft#28999)
  fix(react-utilities): avoid calling requestAnimationFrame when in SSR (microsoft#29015)
  fix(ssr-tests-v9): use correct path for ssr-tests-v9 stories (microsoft#29025)
  chore: updates devcontainer to use v16-bookworm image (microsoft#28997)
  feat(docsite): add Application Insights telemetry (microsoft#28709)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants