Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-tags-preview): add hover/pressed style for windows high contrast #29035

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

YuanboXue-Amber
Copy link
Contributor

Add hover/pressed style for windows high contrast on Tag/InteractionTag:

Hover dismiss icon on Tag:

before after
Screenshot 2023-08-31 at 13 42 44 Screenshot 2023-08-31 at 13 42 30

Hover InteractionTagPrimary:

before after
Screenshot 2023-08-31 at 13 31 46 Screenshot 2023-08-31 at 13 36 48

Hover InteractionTagSecondary:

before after
Screenshot 2023-08-31 at 13 31 50 Screenshot 2023-08-31 at 13 37 06

@YuanboXue-Amber YuanboXue-Amber marked this pull request as ready for review August 31, 2023 11:46
@YuanboXue-Amber YuanboXue-Amber requested review from a team as code owners August 31, 2023 11:46
@YuanboXue-Amber YuanboXue-Amber enabled auto-merge (squash) August 31, 2023 11:57
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 87273cf:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-tags-preview
Tag
26.681 kB
8.419 kB
26.92 kB
8.476 kB
239 B
57 B
react-tags-preview
TagGroup
69.626 kB
20.485 kB
69.684 kB
20.498 kB
58 B
13 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-tags-preview
InteractionTag
11.24 kB
4.54 kB
🤖 This report was generated against e051b031c0b823f03c252ed59e329ade794b0686

@size-auditor
Copy link

size-auditor bot commented Aug 31, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: e051b031c0b823f03c252ed59e329ade794b0686 (build)

@YuanboXue-Amber YuanboXue-Amber merged commit 1ed23ee into microsoft:master Aug 31, 2023
@fabricteam
Copy link
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Sep 3, 2023
* master: (32 commits)
  refactor(react-drawer): change DrawerHeaderTitle slot creation while keeping the same API (microsoft#29042)
  test(react-drawer): add render tests for drawer subcomponents (microsoft#29043)
  Grouped vertical bar chart - Component tests (microsoft#29031)
  docs: add Fluent UI Insights EP06 to README (microsoft#29051)
  chore: use swc-plugin-de-indent-template-literal for consoles (microsoft#29040)
  chore: adds swc-plugin-de-indent-template-literal (microsoft#29037)
  feat(react-jsx-runtime): v9 packages to use importSource (microsoft#28959)
  chore: update swc build dependencies (microsoft#28989)
  fix(react-tags-preview): add hover/pressed style for windows high contrast (microsoft#29035)
  chore(react-tags-preview): use InteractionTag for TagGroup's stories (microsoft#29024)
  chore(react-tags-preview): use makeResetStyles for base styles (microsoft#29022)
  chore: fix codesandbox export for preview component by making @fluentui/react-components required dependency (microsoft#29016)
  applying package updates
  feat(react-motion): create useReducedMotion and apply to useMotion to skip animations (microsoft#29014)
  ReAdd: Keytips: Align keytipData with visible instance for dupes (microsoft#28992)
  feat(react-drawer): add motion to Drawer (microsoft#28999)
  fix(react-utilities): avoid calling requestAnimationFrame when in SSR (microsoft#29015)
  fix(ssr-tests-v9): use correct path for ssr-tests-v9 stories (microsoft#29025)
  chore: updates devcontainer to use v16-bookworm image (microsoft#28997)
  feat(docsite): add Application Insights telemetry (microsoft#28709)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants