Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updates devcontainer to use v16-bookworm image #28997

Conversation

bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented Aug 28, 2023

Previous Behavior

New Behavior

Upgrades devcontainer configuration to use the latest debian stable release bookworm

Related Issue(s)

  • Fixes #

@bsunderhus bsunderhus self-assigned this Aug 28, 2023
@github-actions github-actions bot added this to the August Project Cycle Q4 2023 milestone Aug 28, 2023
@bsunderhus bsunderhus marked this pull request as ready for review August 28, 2023 11:53
@bsunderhus bsunderhus requested a review from a team as a code owner August 28, 2023 11:53
@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 600 602 5000
Button mount 313 317 5000
Field mount 1132 1150 5000
FluentProvider mount 685 683 5000
FluentProviderWithTheme mount 82 75 10
FluentProviderWithTheme virtual-rerender 70 71 10
FluentProviderWithTheme virtual-rerender-with-unmount 74 79 10
InfoButton mount 9 17 5000
MakeStyles mount 874 867 50000
Persona mount 1716 1696 5000
SpinButton mount 1324 1342 5000

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5b5a675:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ImageMinimalPerf.default 229 203 1.13:1
TreeWith60ListItems.default 87 77 1.13:1
CardMinimalPerf.default 324 292 1.11:1
DividerMinimalPerf.default 215 198 1.09:1
AnimationMinimalPerf.default 311 289 1.08:1
ChatDuplicateMessagesPerf.default 153 142 1.08:1
LayoutMinimalPerf.default 209 195 1.07:1
SegmentMinimalPerf.default 204 190 1.07:1
FormMinimalPerf.default 226 214 1.06:1
LoaderMinimalPerf.default 198 186 1.06:1
ProviderMinimalPerf.default 207 196 1.06:1
SkeletonMinimalPerf.default 200 188 1.06:1
BoxMinimalPerf.default 203 193 1.05:1
CarouselMinimalPerf.default 273 260 1.05:1
ButtonOverridesMissPerf.default 653 628 1.04:1
GridMinimalPerf.default 192 184 1.04:1
DropdownManyItemsPerf.default 389 379 1.03:1
LabelMinimalPerf.default 231 225 1.03:1
ListMinimalPerf.default 317 307 1.03:1
ListWith60ListItems.default 382 372 1.03:1
IconMinimalPerf.default 383 372 1.03:1
TableManyItemsPerf.default 1152 1121 1.03:1
AvatarMinimalPerf.default 111 109 1.02:1
HeaderMinimalPerf.default 205 200 1.02:1
ListNestedPerf.default 332 325 1.02:1
MenuMinimalPerf.default 500 489 1.02:1
ProviderMergeThemesPerf.default 673 661 1.02:1
SplitButtonMinimalPerf.default 2261 2207 1.02:1
TextAreaMinimalPerf.default 297 291 1.02:1
AccordionMinimalPerf.default 83 82 1.01:1
ButtonSlotsPerf.default 319 315 1.01:1
DatepickerMinimalPerf.default 3569 3537 1.01:1
ItemLayoutMinimalPerf.default 725 717 1.01:1
MenuButtonMinimalPerf.default 960 952 1.01:1
PortalMinimalPerf.default 86 85 1.01:1
RefMinimalPerf.default 108 107 1.01:1
TableMinimalPerf.default 230 228 1.01:1
CustomToolbarPrototype.default 1494 1481 1.01:1
TooltipMinimalPerf.default 1263 1246 1.01:1
TreeMinimalPerf.default 490 483 1.01:1
AttachmentSlotsPerf.default 643 645 1:1
DialogMinimalPerf.default 440 442 1:1
DropdownMinimalPerf.default 1430 1432 1:1
EmbedMinimalPerf.default 1877 1870 1:1
InputMinimalPerf.default 541 540 1:1
RadioGroupMinimalPerf.default 267 266 1:1
SliderMinimalPerf.default 728 727 1:1
TextMinimalPerf.default 186 186 1:1
ToolbarMinimalPerf.default 540 538 1:1
AlertMinimalPerf.default 152 154 0.99:1
ButtonMinimalPerf.default 84 85 0.99:1
CheckboxMinimalPerf.default 1139 1147 0.99:1
FlexMinimalPerf.default 159 161 0.99:1
RosterPerf.default 1550 1561 0.99:1
PopupMinimalPerf.default 346 349 0.99:1
StatusMinimalPerf.default 396 400 0.99:1
VideoMinimalPerf.default 425 429 0.99:1
AttachmentMinimalPerf.default 80 82 0.98:1
HeaderSlotsPerf.default 458 465 0.98:1
ChatWithPopoverPerf.default 194 200 0.97:1
ChatMinimalPerf.default 430 446 0.96:1
ReactionMinimalPerf.default 219 230 0.95:1
ListCommonPerf.default 376 399 0.94:1

@fabricteam
Copy link
Collaborator

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext
510 B
330 B
global-context
createContextSelector
537 B
342 B
priority-overflow
createOverflowManager
4.162 kB
1.735 kB
react-accordion
Accordion (including children components)
88.688 kB
26.917 kB
react-alert
Alert
81.668 kB
21.964 kB
react-avatar
Avatar
47.01 kB
14.502 kB
react-avatar
AvatarGroup
16.116 kB
6.431 kB
react-avatar
AvatarGroupItem
61.789 kB
18.912 kB
react-badge
Badge
23.183 kB
7.254 kB
react-badge
CounterBadge
24.084 kB
7.553 kB
react-badge
PresenceBadge
22.14 kB
7.867 kB
react-button
Button
36.91 kB
9.685 kB
react-button
CompoundButton
44.259 kB
11.167 kB
react-button
MenuButton
41.296 kB
10.933 kB
react-button
SplitButton
49.331 kB
12.486 kB
react-button
ToggleButton
53.956 kB
11.582 kB
react-card
Card - All
88.334 kB
25.252 kB
react-card
Card
83.177 kB
23.742 kB
react-card
CardFooter
9.338 kB
3.932 kB
react-card
CardHeader
11.589 kB
4.707 kB
react-card
CardPreview
10.297 kB
4.317 kB
react-checkbox
Checkbox
32.872 kB
10.652 kB
react-combobox
Combobox (including child components)
87.101 kB
28.273 kB
react-combobox
Dropdown (including child components)
85.555 kB
27.926 kB
react-components
react-components: Button, FluentProvider & webLightTheme
66.446 kB
18.441 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
203.68 kB
57.903 kB
react-components
react-components: FluentProvider & webLightTheme
37.787 kB
12.387 kB
react-datepicker-compat
DatePicker Compat
207.356 kB
57.486 kB
react-dialog
Dialog (including children components)
86.738 kB
26.341 kB
react-divider
Divider
17.098 kB
6.303 kB
react-field
Field
18.295 kB
6.978 kB
react-image
Image
12.029 kB
4.783 kB
react-infobutton
InfoButton
125.612 kB
39.404 kB
react-infobutton
InfoLabel
129.283 kB
40.575 kB
react-input
Input
23.237 kB
7.688 kB
react-jsx-runtime
Classic Pragma
1.049 kB
531 B
react-jsx-runtime
JSX Dev Runtime
2.752 kB
1.277 kB
react-jsx-runtime
JSX Runtime
3.27 kB
1.519 kB
react-label
Label
10.423 kB
4.31 kB
react-link
Link
13.254 kB
5.397 kB
react-menu
Menu (including children components)
135.721 kB
41.662 kB
react-menu
Menu (including selectable components)
138.407 kB
42.17 kB
react-overflow
hooks only
12.419 kB
4.687 kB
react-persona
Persona
53.905 kB
16.371 kB
react-popover
Popover
114.883 kB
36.034 kB
react-portal
Portal
12.255 kB
4.504 kB
react-portal-compat
PortalCompatProvider
6.48 kB
2.203 kB
react-positioning
usePositioning
25.137 kB
9.109 kB
react-progress
ProgressBar
13.718 kB
5.476 kB
react-provider
FluentProvider
18.332 kB
6.817 kB
react-radio
Radio
26.617 kB
8.601 kB
react-radio
RadioGroup
11.622 kB
4.833 kB
react-select
Select
24.599 kB
8.651 kB
react-slider
Slider
34.134 kB
11.039 kB
react-spinbutton
SpinButton
32.773 kB
10.216 kB
react-spinner
Spinner
19.668 kB
7.024 kB
react-switch
Switch
29.092 kB
9.217 kB
react-table
DataGrid
152.991 kB
42.325 kB
react-table
Table (Primitives only)
39.638 kB
12.129 kB
react-table
Table as DataGrid
126.247 kB
33.617 kB
react-table
Table (Selection only)
71.617 kB
18.915 kB
react-table
Table (Sort only)
70.236 kB
18.516 kB
react-tags-preview
InteractionTag
11.031 kB
4.528 kB
react-tags-preview
Tag
28.65 kB
9.018 kB
react-tags-preview
TagGroup
69.607 kB
20.482 kB
react-text
Text - Default
13.043 kB
5.129 kB
react-text
Text - Wrappers
16.215 kB
5.447 kB
react-textarea
Textarea
27.302 kB
9.047 kB
react-theme
Single theme token import
69 B
89 B
react-theme
Teams: all themes
34.611 kB
7.295 kB
react-theme
Teams: Light theme
19.282 kB
5.486 kB
react-toast
Toast (including Toaster)
87.69 kB
26.037 kB
react-tooltip
Tooltip
48.1 kB
16.875 kB
react-utilities
SSRProvider
180 B
159 B
🤖 This report was generated against 2147e3d60a21ff7ded34b27a19f3d5313533e910

@fabricteam
Copy link
Collaborator

🕵 FluentUIV0 No visual regressions between this PR and main

@size-auditor
Copy link

size-auditor bot commented Aug 28, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 2147e3d60a21ff7ded34b27a19f3d5313533e910 (build)

@fabricteam
Copy link
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 629 623 5000
Breadcrumb mount 1662 1701 1000
Checkbox mount 1713 1682 5000
CheckboxBase mount 1503 1564 5000
ChoiceGroup mount 2945 2957 5000
ComboBox mount 646 652 1000
CommandBar mount 6214 6201 1000
ContextualMenu mount 13838 13834 1000
DefaultButton mount 764 744 5000
DetailsRow mount 2203 2146 5000
DetailsRowFast mount 2147 2152 5000
DetailsRowNoStyles mount 1966 2006 5000
Dialog mount 2680 2661 1000
DocumentCardTitle mount 216 222 1000
Dropdown mount 1974 2002 5000
FocusTrapZone mount 1135 1145 5000
FocusZone mount 1040 1056 5000
GroupedList mount 41331 41335 2
GroupedList virtual-rerender 19620 19916 2
GroupedList virtual-rerender-with-unmount 50567 50508 2
GroupedListV2 mount 230 223 2
GroupedListV2 virtual-rerender 207 211 2
GroupedListV2 virtual-rerender-with-unmount 237 228 2
IconButton mount 1099 1080 5000
Label mount 323 336 5000
Layer mount 2647 2756 5000
Link mount 384 398 5000
MenuButton mount 937 941 5000
MessageBar mount 21366 21370 5000
Nav mount 1937 1922 1000
OverflowSet mount 788 777 5000
Panel mount 2060 1771 1000
Persona mount 750 729 1000
Pivot mount 868 870 1000
PrimaryButton mount 821 838 5000
Rating mount 4667 4633 5000
SearchBox mount 922 943 5000
Shimmer mount 1880 1880 5000
Slider mount 1342 1339 5000
SpinButton mount 2874 2888 5000
Spinner mount 387 394 5000
SplitButton mount 1806 1862 5000
Stack mount 405 407 5000
StackWithIntrinsicChildren mount 847 855 5000
StackWithTextChildren mount 2637 2627 5000
SwatchColorPicker mount 6127 6072 5000
TagPicker mount 1459 1456 5000
Text mount 388 366 5000
TextField mount 905 954 5000
ThemeProvider mount 827 815 5000
ThemeProvider virtual-rerender 585 579 5000
ThemeProvider virtual-rerender-with-unmount 1250 1258 5000
Toggle mount 610 611 5000
buttonNative mount 197 189 5000

@bsunderhus bsunderhus merged commit 414fbc7 into microsoft:master Aug 30, 2023
@bsunderhus bsunderhus deleted the devcontainer/chore--updates-devcontainer-to-v16-bookworm branch August 30, 2023 12:46
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Sep 3, 2023
* master: (32 commits)
  refactor(react-drawer): change DrawerHeaderTitle slot creation while keeping the same API (microsoft#29042)
  test(react-drawer): add render tests for drawer subcomponents (microsoft#29043)
  Grouped vertical bar chart - Component tests (microsoft#29031)
  docs: add Fluent UI Insights EP06 to README (microsoft#29051)
  chore: use swc-plugin-de-indent-template-literal for consoles (microsoft#29040)
  chore: adds swc-plugin-de-indent-template-literal (microsoft#29037)
  feat(react-jsx-runtime): v9 packages to use importSource (microsoft#28959)
  chore: update swc build dependencies (microsoft#28989)
  fix(react-tags-preview): add hover/pressed style for windows high contrast (microsoft#29035)
  chore(react-tags-preview): use InteractionTag for TagGroup's stories (microsoft#29024)
  chore(react-tags-preview): use makeResetStyles for base styles (microsoft#29022)
  chore: fix codesandbox export for preview component by making @fluentui/react-components required dependency (microsoft#29016)
  applying package updates
  feat(react-motion): create useReducedMotion and apply to useMotion to skip animations (microsoft#29014)
  ReAdd: Keytips: Align keytipData with visible instance for dupes (microsoft#28992)
  feat(react-drawer): add motion to Drawer (microsoft#28999)
  fix(react-utilities): avoid calling requestAnimationFrame when in SSR (microsoft#29015)
  fix(ssr-tests-v9): use correct path for ssr-tests-v9 stories (microsoft#29025)
  chore: updates devcontainer to use v16-bookworm image (microsoft#28997)
  feat(docsite): add Application Insights telemetry (microsoft#28709)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants