Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(react-tags-preview): use makeResetStyles for base styles #29022

Merged
merged 3 commits into from
Aug 31, 2023

Conversation

YuanboXue-Amber
Copy link
Contributor

move base styles to makeResetStyles

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 30, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8a3e2fa:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 30, 2023

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-tags-preview
InteractionTag
11.031 kB
4.528 kB
11.24 kB
4.54 kB
209 B
12 B
react-tags-preview
Tag
27.792 kB
8.768 kB
26.681 kB
8.419 kB
-1.111 kB
-349 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-tags-preview
TagGroup
69.626 kB
20.485 kB
🤖 This report was generated against 78473de156263c35a0baacf992463d6854ff3c7a

@size-auditor
Copy link

size-auditor bot commented Aug 30, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 78473de156263c35a0baacf992463d6854ff3c7a (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 30, 2023

🕵 fluentuiv9 No visual regressions between this PR and main

@YuanboXue-Amber
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@YuanboXue-Amber YuanboXue-Amber marked this pull request as ready for review August 30, 2023 12:23
@YuanboXue-Amber YuanboXue-Amber requested review from a team as code owners August 30, 2023 12:23
@YuanboXue-Amber YuanboXue-Amber merged commit e051b03 into microsoft:master Aug 31, 2023
@YuanboXue-Amber YuanboXue-Amber deleted the tag-reset branch August 31, 2023 08:46
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Sep 3, 2023
* master: (32 commits)
  refactor(react-drawer): change DrawerHeaderTitle slot creation while keeping the same API (microsoft#29042)
  test(react-drawer): add render tests for drawer subcomponents (microsoft#29043)
  Grouped vertical bar chart - Component tests (microsoft#29031)
  docs: add Fluent UI Insights EP06 to README (microsoft#29051)
  chore: use swc-plugin-de-indent-template-literal for consoles (microsoft#29040)
  chore: adds swc-plugin-de-indent-template-literal (microsoft#29037)
  feat(react-jsx-runtime): v9 packages to use importSource (microsoft#28959)
  chore: update swc build dependencies (microsoft#28989)
  fix(react-tags-preview): add hover/pressed style for windows high contrast (microsoft#29035)
  chore(react-tags-preview): use InteractionTag for TagGroup's stories (microsoft#29024)
  chore(react-tags-preview): use makeResetStyles for base styles (microsoft#29022)
  chore: fix codesandbox export for preview component by making @fluentui/react-components required dependency (microsoft#29016)
  applying package updates
  feat(react-motion): create useReducedMotion and apply to useMotion to skip animations (microsoft#29014)
  ReAdd: Keytips: Align keytipData with visible instance for dupes (microsoft#28992)
  feat(react-drawer): add motion to Drawer (microsoft#28999)
  fix(react-utilities): avoid calling requestAnimationFrame when in SSR (microsoft#29015)
  fix(ssr-tests-v9): use correct path for ssr-tests-v9 stories (microsoft#29025)
  chore: updates devcontainer to use v16-bookworm image (microsoft#28997)
  feat(docsite): add Application Insights telemetry (microsoft#28709)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants