Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docsite): add Application Insights telemetry #28709

Merged
merged 2 commits into from
Aug 30, 2023
Merged

feat(docsite): add Application Insights telemetry #28709

merged 2 commits into from
Aug 30, 2023

Conversation

tudorpopams
Copy link
Contributor

Previous Behavior

We had no telemetry on the React v9 docsite.

New Behavior

Added Azure Application Insights telemetry.

@tudorpopams tudorpopams requested review from a team as code owners August 2, 2023 08:26
@tudorpopams tudorpopams self-assigned this Aug 2, 2023
@fabricteam
Copy link
Collaborator

fabricteam commented Aug 2, 2023 •
edited
Loading

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme virtual-rerender-with-unmount 76 70 10 Possible regression
InfoButton mount 16 10 5000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 624 622 5000
Button mount 313 317 5000
Field mount 1119 1143 5000
FluentProvider mount 689 694 5000
FluentProviderWithTheme mount 77 84 10
FluentProviderWithTheme virtual-rerender 69 65 10
FluentProviderWithTheme virtual-rerender-with-unmount 76 70 10 Possible regression
InfoButton mount 16 10 5000 Possible regression
MakeStyles mount 860 841 50000
Persona mount 1733 1716 5000
SpinButton mount 1381 1348 5000

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 2, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 58a8338:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 2, 2023 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
HeaderMinimalPerf.default 219 192 1.14:1
AccordionMinimalPerf.default 87 80 1.09:1
IconMinimalPerf.default 399 369 1.08:1
AvatarMinimalPerf.default 110 103 1.07:1
BoxMinimalPerf.default 201 188 1.07:1
HeaderSlotsPerf.default 477 447 1.07:1
SegmentMinimalPerf.default 200 187 1.07:1
AlertMinimalPerf.default 164 154 1.06:1
AnimationMinimalPerf.default 307 290 1.06:1
LayoutMinimalPerf.default 201 190 1.06:1
RefMinimalPerf.default 112 106 1.06:1
ToolbarMinimalPerf.default 548 519 1.06:1
ListMinimalPerf.default 310 299 1.04:1
TableMinimalPerf.default 249 239 1.04:1
TreeMinimalPerf.default 493 476 1.04:1
DropdownManyItemsPerf.default 391 381 1.03:1
GridMinimalPerf.default 194 189 1.03:1
ItemLayoutMinimalPerf.default 711 690 1.03:1
ProviderMergeThemesPerf.default 675 658 1.03:1
RadioGroupMinimalPerf.default 265 257 1.03:1
TextAreaMinimalPerf.default 286 278 1.03:1
CheckboxMinimalPerf.default 1139 1119 1.02:1
FormMinimalPerf.default 227 223 1.02:1
ImageMinimalPerf.default 233 228 1.02:1
ListNestedPerf.default 319 313 1.02:1
MenuMinimalPerf.default 504 494 1.02:1
PopupMinimalPerf.default 348 341 1.02:1
TableManyItemsPerf.default 1106 1088 1.02:1
CardMinimalPerf.default 306 304 1.01:1
CarouselMinimalPerf.default 256 254 1.01:1
ChatDuplicateMessagesPerf.default 149 147 1.01:1
DatepickerMinimalPerf.default 3605 3563 1.01:1
DividerMinimalPerf.default 203 201 1.01:1
FlexMinimalPerf.default 153 152 1.01:1
ProviderMinimalPerf.default 198 196 1.01:1
SkeletonMinimalPerf.default 198 196 1.01:1
StatusMinimalPerf.default 401 397 1.01:1
TooltipMinimalPerf.default 1271 1260 1.01:1
AttachmentMinimalPerf.default 82 82 1:1
ChatMinimalPerf.default 425 423 1:1
EmbedMinimalPerf.default 1878 1876 1:1
ListCommonPerf.default 386 387 1:1
ListWith60ListItems.default 357 356 1:1
MenuButtonMinimalPerf.default 939 942 1:1
ReactionMinimalPerf.default 218 218 1:1
SplitButtonMinimalPerf.default 2222 2217 1:1
TextMinimalPerf.default 187 187 1:1
ButtonOverridesMissPerf.default 647 651 0.99:1
ChatWithPopoverPerf.default 185 186 0.99:1
DialogMinimalPerf.default 447 453 0.99:1
DropdownMinimalPerf.default 1404 1431 0.98:1
LabelMinimalPerf.default 209 213 0.98:1
PortalMinimalPerf.default 78 80 0.98:1
CustomToolbarPrototype.default 1470 1493 0.98:1
AttachmentSlotsPerf.default 636 656 0.97:1
ButtonSlotsPerf.default 306 315 0.97:1
InputMinimalPerf.default 531 549 0.97:1
RosterPerf.default 1498 1564 0.96:1
VideoMinimalPerf.default 418 435 0.96:1
TreeWith60ListItems.default 83 87 0.95:1
SliderMinimalPerf.default 718 762 0.94:1
LoaderMinimalPerf.default 181 195 0.93:1
ButtonMinimalPerf.default 93 102 0.91:1

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 2, 2023 •
edited
Loading

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 2, 2023 •
edited
Loading

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext		 510 B
330 B
global-context
createContextSelector		 537 B
342 B
priority-overflow
createOverflowManager		 4.162 kB
1.735 kB
react-accordion
Accordion (including children components)		 88.688 kB
26.917 kB
react-alert
Alert		 81.668 kB
21.964 kB
react-avatar
Avatar		 47.01 kB
14.502 kB
react-avatar
AvatarGroup		 16.116 kB
6.431 kB
react-avatar
AvatarGroupItem		 61.789 kB
18.912 kB
react-badge
Badge		 23.183 kB
7.254 kB
react-badge
CounterBadge		 24.084 kB
7.553 kB
react-badge
PresenceBadge		 22.14 kB
7.867 kB
react-button
Button		 36.91 kB
9.685 kB
react-button
CompoundButton		 44.259 kB
11.167 kB
react-button
MenuButton		 41.296 kB
10.933 kB
react-button
SplitButton		 49.331 kB
12.486 kB
react-button
ToggleButton		 53.956 kB
11.582 kB
react-card
Card - All		 88.334 kB
25.252 kB
react-card
Card		 83.177 kB
23.742 kB
react-card
CardFooter		 9.338 kB
3.932 kB
react-card
CardHeader		 11.589 kB
4.707 kB
react-card
CardPreview		 10.297 kB
4.317 kB
react-checkbox
Checkbox		 32.872 kB
10.652 kB
react-combobox
Combobox (including child components)		 87.101 kB
28.273 kB
react-combobox
Dropdown (including child components)		 85.555 kB
27.926 kB
react-components
react-components: Button, FluentProvider & webLightTheme		 66.446 kB
18.441 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 203.68 kB
57.903 kB
react-components
react-components: FluentProvider & webLightTheme		 37.787 kB
12.387 kB
react-datepicker-compat
DatePicker Compat		 207.356 kB
57.486 kB
react-dialog
Dialog (including children components)		 86.738 kB
26.341 kB
react-divider
Divider		 17.098 kB
6.303 kB
react-field
Field		 18.295 kB
6.978 kB
react-image
Image		 12.029 kB
4.783 kB
react-infobutton
InfoButton		 125.612 kB
39.404 kB
react-infobutton
InfoLabel		 129.283 kB
40.575 kB
react-input
Input		 23.237 kB
7.688 kB
react-jsx-runtime
Classic Pragma		 1.049 kB
531 B
react-jsx-runtime
JSX Dev Runtime		 2.752 kB
1.277 kB
react-jsx-runtime
JSX Runtime		 3.27 kB
1.519 kB
react-label
Label		 10.423 kB
4.31 kB
react-link
Link		 13.254 kB
5.397 kB
react-menu
Menu (including children components)		 135.721 kB
41.662 kB
react-menu
Menu (including selectable components)		 138.407 kB
42.17 kB
react-overflow
hooks only		 12.419 kB
4.687 kB
react-persona
Persona		 53.905 kB
16.371 kB
react-popover
Popover		 114.883 kB
36.034 kB
react-portal
Portal		 12.255 kB
4.504 kB
react-portal-compat
PortalCompatProvider		 6.48 kB
2.203 kB
react-positioning
usePositioning		 25.137 kB
9.109 kB
react-progress
ProgressBar		 13.718 kB
5.476 kB
react-provider
FluentProvider		 18.332 kB
6.817 kB
react-radio
Radio		 26.617 kB
8.601 kB
react-radio
RadioGroup		 11.622 kB
4.833 kB
react-select
Select		 24.599 kB
8.651 kB
react-slider
Slider		 34.134 kB
11.039 kB
react-spinbutton
SpinButton		 32.773 kB
10.216 kB
react-spinner
Spinner		 19.668 kB
7.024 kB
react-switch
Switch		 29.092 kB
9.217 kB
react-table
DataGrid		 152.991 kB
42.325 kB
react-table
Table (Primitives only)		 39.638 kB
12.129 kB
react-table
Table as DataGrid		 126.247 kB
33.617 kB
react-table
Table (Selection only)		 71.617 kB
18.915 kB
react-table
Table (Sort only)		 70.236 kB
18.516 kB
react-tags-preview
InteractionTag		 11.031 kB
4.528 kB
react-tags-preview
Tag		 28.65 kB
9.018 kB
react-tags-preview
TagGroup		 69.607 kB
20.482 kB
react-text
Text - Default		 13.043 kB
5.129 kB
react-text
Text - Wrappers		 16.215 kB
5.447 kB
react-textarea
Textarea		 27.302 kB
9.047 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 34.611 kB
7.295 kB
react-theme
Teams: Light theme		 19.282 kB
5.486 kB
react-toast
Toast (including Toaster)		 87.69 kB
26.037 kB
react-tooltip
Tooltip		 48.1 kB
16.875 kB
react-utilities
SSRProvider		 180 B
159 B
🤖 This report was generated against 2147e3d60a21ff7ded34b27a19f3d5313533e910

@size-auditor
Copy link

size-auditor bot commented Aug 2, 2023 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 2147e3d60a21ff7ded34b27a19f3d5313533e910 (build)

@tudorpopams tudorpopams force-pushed the feat/docsite-telemetry branch from 0461908 to 8782042 Compare August 2, 2023 08:45
@fabricteam
Copy link
Collaborator

fabricteam commented Aug 2, 2023 •
edited
Loading

🕵 fluentuiv9 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 2, 2023 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 636 634 5000
Breadcrumb mount 1678 1678 1000
Checkbox mount 1698 1679 5000
CheckboxBase mount 1486 1493 5000
ChoiceGroup mount 2981 2978 5000
ComboBox mount 663 654 1000
CommandBar mount 6201 6259 1000
ContextualMenu mount 13841 13924 1000
DefaultButton mount 755 743 5000
DetailsRow mount 2184 2195 5000
DetailsRowFast mount 2162 2222 5000
DetailsRowNoStyles mount 2008 1979 5000
Dialog mount 2788 2631 1000
DocumentCardTitle mount 221 223 1000
Dropdown mount 1951 1992 5000
FocusTrapZone mount 1099 1110 5000
FocusZone mount 1081 1028 5000
GroupedList mount 36850 40950 2
GroupedList virtual-rerender 19817 19707 2
GroupedList virtual-rerender-with-unmount 50338 50325 2
GroupedListV2 mount 227 227 2
GroupedListV2 virtual-rerender 217 206 2
GroupedListV2 virtual-rerender-with-unmount 220 229 2
IconButton mount 1096 1080 5000
Label mount 351 334 5000
Layer mount 2777 2742 5000
Link mount 399 379 5000
MenuButton mount 944 959 5000
MessageBar mount 21391 21679 5000
Nav mount 1957 1904 1000
OverflowSet mount 809 782 5000
Panel mount 1835 1804 1000
Persona mount 747 749 1000
Pivot mount 888 878 1000
PrimaryButton mount 845 840 5000
Rating mount 4619 4601 5000
SearchBox mount 923 931 5000
Shimmer mount 1880 1839 5000
Slider mount 1328 1327 5000
SpinButton mount 2872 2907 5000
Spinner mount 384 399 5000
SplitButton mount 1796 1790 5000
Stack mount 395 415 5000
StackWithIntrinsicChildren mount 862 882 5000
StackWithTextChildren mount 2618 2631 5000
SwatchColorPicker mount 6122 6122 5000
TagPicker mount 1416 1464 5000
Text mount 364 368 5000
TextField mount 940 920 5000
ThemeProvider mount 833 825 5000
ThemeProvider virtual-rerender 589 587 5000
ThemeProvider virtual-rerender-with-unmount 1285 1255 5000
Toggle mount 622 611 5000
buttonNative mount 189 187 5000

@github-actions github-actions bot added this to the August Project Cycle Q4 2023 milestone Aug 2, 2023
@tudorpopams tudorpopams requested a review from marcosmoura August 2, 2023 12:13
@tudorpopams tudorpopams force-pushed the feat/docsite-telemetry branch from 8782042 to ae27e74 Compare August 2, 2023 12:20
@tudorpopams tudorpopams force-pushed the feat/docsite-telemetry branch 3 times, most recently from c1fd841 to 03dc112 Compare August 10, 2023 14:48
@tudorpopams tudorpopams force-pushed the feat/docsite-telemetry branch 4 times, most recently from 1e14918 to 4d5d588 Compare August 23, 2023 15:34
@tudorpopams tudorpopams force-pushed the feat/docsite-telemetry branch from 4d5d588 to 58a8338 Compare August 28, 2023 13:15
@fabricteam
Copy link
Collaborator

🕵 fluentuiv8 No visual regressions between this PR and main

@tudorpopams tudorpopams merged commit 78473de into microsoft:master Aug 30, 2023
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Sep 3, 2023
@marcosmoura
Merge branch 'master' into feat/drawer-motion
58b1e52 
* master: (32 commits)
  refactor(react-drawer): change DrawerHeaderTitle slot creation while keeping the same API (microsoft#29042)
  test(react-drawer): add render tests for drawer subcomponents (microsoft#29043)
  Grouped vertical bar chart - Component tests (microsoft#29031)
  docs: add Fluent UI Insights EP06 to README (microsoft#29051)
  chore: use swc-plugin-de-indent-template-literal for consoles (microsoft#29040)
  chore: adds swc-plugin-de-indent-template-literal (microsoft#29037)
  feat(react-jsx-runtime): v9 packages to use importSource (microsoft#28959)
  chore: update swc build dependencies (microsoft#28989)
  fix(react-tags-preview): add hover/pressed style for windows high contrast (microsoft#29035)
  chore(react-tags-preview): use InteractionTag for TagGroup's stories (microsoft#29024)
  chore(react-tags-preview): use makeResetStyles for base styles (microsoft#29022)
  chore: fix codesandbox export for preview component by making @fluentui/react-components required dependency (microsoft#29016)
  applying package updates
  feat(react-motion): create useReducedMotion and apply to useMotion to skip animations (microsoft#29014)
  ReAdd: Keytips: Align keytipData with visible instance for dupes (microsoft#28992)
  feat(react-drawer): add motion to Drawer (microsoft#28999)
  fix(react-utilities): avoid calling requestAnimationFrame when in SSR (microsoft#29015)
  fix(ssr-tests-v9): use correct path for ssr-tests-v9 stories (microsoft#29025)
  chore: updates devcontainer to use v16-bookworm image (microsoft#28997)
  feat(docsite): add Application Insights telemetry (microsoft#28709)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosmoura marcosmoura marcosmoura approved these changes

Assignees

@tudorpopams tudorpopams

Labels
None yet
Projects
None yet
Milestone
August Project Cycle Q4 2023
Development

Successfully merging this pull request may close these issues.
3 participants
@tudorpopams @fabricteam @marcosmoura