🔃 [Magento Community Engineering] Community Contributions - 2.4-devel…

…op latest changes Accepted Community Pull Requests: - #29829: [MFTF] add new AdminOpenWebConfigurationPageActionGroup (by @Usik2203) - #29821: [MFTF] use AdminOpenCreateNewCMSPageActionGroup for navigation to create new cms page (by @Usik2203) - #29832: [MFTF] use ActionGroup for navigation to checkout page (by @Usik2203) - #29830: [MFTF] add new AdminOpenAdminThreeDSecurePageActionGroup (by @Usik2203) - #29828: [MFTF] add new AdminOpenGeneralConfigurationPageActionGroup (by @Usik2203) - #29820: [MFTF] Added new ActionGroup for clicking AddToCart button (by @Usik2203) - #25244: #25192 fixed (by @vishalverma279) - #28343: Added missing aclResource attribute to Backend Header AdminNotification Toolbar Block (by @denysbabenko) - #27129: Improve performance of "in" condition on some version of MySQl (by @kandy) - #27269: #26288 Throw an exception when a customer does not exist requests password reset (by @Bal2018) Fixed GitHub Issues: - #29846: [Issue] [MFTF] add new AdminOpenWebConfigurationPageActionGroup (reported by @m2-assistant[bot]) has been fixed in #29829 by @Usik2203 in 2.4-develop branch Related commits: 1. 66184fd 2. 81ef092 3. d76e664 - #29824: [Issue] [MFTF] use AdminOpenCreateNewCMSPageActionGroup for navigation to create new cms page (reported by @m2-assistant[bot]) has been fixed in #29821 by @Usik2203 in 2.4-develop branch Related commits: 1. 6e7914f 2. e23ab45 3. 7aa7f6e - #29843: [Issue] [MFTF] use ActionGroup for navigation to checkout page (reported by @m2-assistant[bot]) has been fixed in #29832 by @Usik2203 in 2.4-develop branch Related commits: 1. 45f834c 2. ce4caae 3. 9ae704d - #29845: [Issue] [MFTF] add new AdminOpenAdminThreeDSecurePageActionGroup (reported by @m2-assistant[bot]) has been fixed in #29830 by @Usik2203 in 2.4-develop branch Related commits: 1. 3cfa6aa 2. c0241d4 - #29847: [Issue] [MFTF] add new AdminOpenGeneralConfigurationPageActionGroup (reported by @m2-assistant[bot]) has been fixed in #29828 by @Usik2203 in 2.4-develop branch Related commits: 1. ef7b93b 2. a77b364 - #29823: [Issue] [MFTF] Added new ActionGroup for clicking AddToCart button (reported by @m2-assistant[bot]) has been fixed in #29820 by @Usik2203 in 2.4-develop branch Related commits: 1. 8e6cb13 2. 0eff627 - #25192: DHL Shipping (reported by @insaurabh) has been fixed in #25244 by @vishalverma279 in 2.4-develop branch Related commits: 1. 4ac223b 2. a220df1 3. ab97e97 4. cef3fe7 - #29067: [Issue] Added missing aclResource attribute to Backend Header AdminNotification Toolbar Block (reported by @m2-assistant[bot]) has been fixed in #28343 by @denysbabenko in 2.4-develop branch Related commits: 1. 7ad6cdf 2. cff0e98 3. 9694e2a 4. 3d3c5c4 5. 407fb74 6. e495a51 7. 274103d 8. 44963c2 9. 205c088 10. 0bbc990 11. 0649a6f 12. 8ad66e1 - #25199: Catalog Category Indexing takes very long on MariaDB 10.3 with many products (reported by @amenk) has been fixed in #27129 by @kandy in 2.4-develop branch Related commits: 1. f70f1d2 2. 27e1c6e 3. 4a22091 4. a36c9a9 5. 1515252 6. f2bba37 7. e099ad1 8. 00f1377 9. 6587c57 10. fd21e1f 11. e17a4b6 12. 9e1b438 13. 503f0bd 14. 912cfd8 15. 05e0e15 16. 18f7d85 17. 12d3ebf 18. 88f10c5 19. b7722a1 20. d7fdd07 - #26288: missing Throw in copy pasted code (reported by @angelomaragna) has been fixed in #27269 by @Bal2018 in 2.4-develop branch Related commits: 1. de530f7 2. f44add2 3. 1bd7d1e 4. 5d11fdc 5. 4595009 6. d30e5e2 7. 000c822 8. 239037a 9. baf892e 10. c3855c8 11. bcc29ed
magento · Sep 4, 2020 · 5d8908c · 5d8908c
2 parents ddf3c62 + d1f0447
commit 5d8908c
Show file tree

Hide file tree

Showing 91 changed files with 884 additions and 410 deletions.
diff --git a/app/code/Magento/AdminNotification/Test/Mftf/Section/AdminNotificationToolbarSection.xml b/app/code/Magento/AdminNotification/Test/Mftf/Section/AdminNotificationToolbarSection.xml
@@ -0,0 +1,15 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ /**
+  * Copyright © Magento, Inc. All rights reserved.
+  * See COPYING.txt for license details.
+  */
+-->
+
+<sections xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+          xsi:noNamespaceSchemaLocation="urn:magento:mftf:Page/etc/SectionObject.xsd">
+    <section name="AdminNotificationToolbarSection">
+        <element name="notification" type="block" selector=".notifications-wrapper.admin__action-dropdown-wrap"/>
+        <element name="notificationCounter" type="block" selector=".notifications-action.admin__action-dropdown .notifications-counter"/>
+    </section>
+</sections>
diff --git a/...e/Magento/AdminNotification/Test/Mftf/Test/AdminSystemNotificationToolbarBlockAclTest.xml b/...e/Magento/AdminNotification/Test/Mftf/Test/AdminSystemNotificationToolbarBlockAclTest.xml
@@ -0,0 +1,64 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ /**
+  * Copyright © Magento, Inc. All rights reserved.
+  * See COPYING.txt for license details.
+  */
+-->
+
+<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+       xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
+    <test name="AdminSystemNotificationToolbarBlockAclTest">
+        <annotations>
+            <features value="AdminNotification"/>
+            <stories value="Acl notification toolbar"/>
+            <title value="Admin system notification toolbar block acl test"/>
+            <description value="Admin should not see system notification toolbar block if acl not restricted"/>
+            <severity value="MAJOR"/>
+            <testCaseId value="MC-36011"/>
+            <group value="menu"/>
+        </annotations>
+        <before>
+            <actionGroup ref="AdminLoginActionGroup" stepKey="LoginAsAdmin"/>
+
+            <actionGroup ref="AdminFillUserRoleRequiredDataActionGroup" stepKey="fillUserRoleRequiredData">
+                <argument name="User" value="adminRole"/>
+                <argument name="restrictedRole" value="Stores"/>
+            </actionGroup>
+            <actionGroup ref="AdminUserClickRoleResourceTabActionGroup" stepKey="goToRoleResourcesTab" />
+            <actionGroup ref="AdminAddRestrictedRoleActionGroup" stepKey="addRestrictedRoleStores">
+                <argument name="User" value="adminRole"/>
+                <argument name="restrictedRole" value="Products"/>
+            </actionGroup>
+            <actionGroup ref="AdminUserSaveRoleActionGroup" stepKey="saveUserRole" />
+
+            <actionGroup ref="AdminCreateUserActionGroup" stepKey="createAdminUser">
+                <argument name="role" value="adminRole"/>
+                <argument name="User" value="admin2"/>
+            </actionGroup>
+
+            <actionGroup ref="AdminLogoutActionGroup" stepKey="logoutOfAdmin"/>
+        </before>
+        <after>
+            <actionGroup ref="AdminLogoutActionGroup" stepKey="logoutAsSaleRoleUser"/>
+            <actionGroup ref="AdminLoginActionGroup" stepKey="loginAsAdmin"/>
+            <!--Delete created data-->
+            <actionGroup ref="AdminUserOpenAdminRolesPageActionGroup" stepKey="navigateToUserRoleGrid"/>
+            <actionGroup ref="AdminDeleteRoleActionGroup" stepKey="deleteUserRole">
+                <argument name="role" value="adminRole"/>
+            </actionGroup>
+            <actionGroup ref="AdminOpenAdminUsersPageActionGroup" stepKey="goToAllUsersPage"/>
+            <actionGroup ref="AdminDeleteNewUserActionGroup" stepKey="deleteUser">
+                <argument name="userName" value="{{admin2.username}}"/>
+            </actionGroup>
+        </after>
+
+        <actionGroup ref="AdminLoginActionGroup" stepKey="loginAsNewUser">
+            <argument name="username" value="{{admin2.username}}"/>
+            <argument name="password" value="{{admin2.password}}"/>
+        </actionGroup>
+
+        <waitForPageLoad stepKey="waitBeforePageLoad"/>
+        <dontSeeElement selector="{{AdminNotificationToolbarSection.notification}}" stepKey="doNotSeeNotificationBellIcon"/>
+    </test>
+</tests>
diff --git a/app/code/Magento/AdminNotification/view/adminhtml/layout/default.xml b/app/code/Magento/AdminNotification/view/adminhtml/layout/default.xml
@@ -20,7 +20,11 @@
                    template="Magento_AdminNotification::notification/window.phtml"/>
         </referenceContainer>
         <referenceContainer name="header">
-            <block class="Magento\AdminNotification\Block\ToolbarEntry" name="notification.messages" before="user" template="Magento_AdminNotification::toolbar_entry.phtml"/>
+            <block class="Magento\AdminNotification\Block\ToolbarEntry"
+                   name="notification.messages"
+                   before="user"
+                   aclResource="Magento_AdminNotification::show_toolbar"
+                   template="Magento_AdminNotification::toolbar_entry.phtml"/>
         </referenceContainer>
     </body>
 </page>
diff --git a/...de/Magento/Backend/Test/Mftf/ActionGroup/AdminOpenGeneralConfigurationPageActionGroup.xml b/...de/Magento/Backend/Test/Mftf/ActionGroup/AdminOpenGeneralConfigurationPageActionGroup.xml
@@ -0,0 +1,19 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ /**
+  * Copyright © Magento, Inc. All rights reserved.
+  * See COPYING.txt for license details.
+  */
+-->
+
+<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+              xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
+    <actionGroup name="AdminOpenGeneralConfigurationPageActionGroup">
+        <annotations>
+            <description>Open general configuration page.</description>
+        </annotations>
+
+        <amOnPage url="{{GeneralConfigurationPage.url}}" stepKey="openGeneralConfigurationPage"/>
+        <waitForPageLoad stepKey="waitForPageLoad"/>
+    </actionGroup>
+</actionGroups>
diff --git a/app/code/Magento/Backend/Test/Mftf/ActionGroup/AdminOpenWebConfigurationPageActionGroup.xml b/app/code/Magento/Backend/Test/Mftf/ActionGroup/AdminOpenWebConfigurationPageActionGroup.xml
@@ -0,0 +1,19 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ /**
+  * Copyright © Magento, Inc. All rights reserved.
+  * See COPYING.txt for license details.
+  */
+-->
+
+<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+              xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
+    <actionGroup name="AdminOpenWebConfigurationPageActionGroup">
+        <annotations>
+            <description>Open web configuration page.</description>
+        </annotations>
+
+        <amOnPage url="{{WebConfigurationPage.url}}" stepKey="openWebConfigurationPage"/>
+        <waitForPageLoad stepKey="waitPageToLoad"/>
+    </actionGroup>
+</actionGroups>
diff --git a/app/code/Magento/Bundle/Model/ResourceModel/Selection/Collection.php b/app/code/Magento/Bundle/Model/ResourceModel/Selection/Collection.php
@@ -215,7 +215,7 @@ public function joinPrices($websiteId)
     public function setOptionIdsFilter($optionIds)
     {
         if (!empty($optionIds)) {
-            $this->getSelect()->where('selection.option_id IN (?)', $optionIds);
+            $this->getSelect()->where('selection.option_id IN (?)', $optionIds, \Zend_Db::INT_TYPE);
         }
         return $this;
     }
@@ -229,7 +229,7 @@ public function setOptionIdsFilter($optionIds)
     public function setSelectionIdsFilter($selectionIds)
     {
         if (!empty($selectionIds)) {
-            $this->getSelect()->where('selection.selection_id IN (?)', $selectionIds);
+            $this->getSelect()->where('selection.selection_id IN (?)', $selectionIds, \Zend_Db::INT_TYPE);
         }
         return $this;
     }

diff --git a/app/code/Magento/Bundle/Test/Mftf/Test/StorefrontGoToDetailsPageWhenAddingToCartTest.xml b/app/code/Magento/Bundle/Test/Mftf/Test/StorefrontGoToDetailsPageWhenAddingToCartTest.xml
@@ -71,8 +71,7 @@
 
         <!--Click add to cart-->
         <moveMouseOver selector="{{StorefrontCategoryMainSection.ProductItemInfo}}" stepKey="hoverProduct"/>
-        <click selector="{{StorefrontCategoryMainSection.AddToCartBtn}}" stepKey="addProductToCart"/>
-        <waitForPageLoad stepKey="waitForProductPage"/>
+        <actionGroup ref="StorefrontClickAddToCartButtonActionGroup" stepKey="addProductToCart"/>
 
         <!--Check for details page-->
         <seeInCurrentUrl url="{{BundleProduct.sku}}" stepKey="seeBundleProductDetailsPage"/>

diff --git a/app/code/Magento/BundleGraphQl/Model/Resolver/Links/Collection.php b/app/code/Magento/BundleGraphQl/Model/Resolver/Links/Collection.php
@@ -108,7 +108,7 @@ private function fetch() : array
         }
 
         $linkCollection->getSelect()
-            ->where($field . ' IN (?)', $this->parentIds);
+            ->where($field . ' IN (?)', $this->parentIds, \Zend_Db::INT_TYPE);
 
         /** @var Selection $link */
         foreach ($linkCollection as $link) {

diff --git a/...ento/CardinalCommerce/Test/Mftf/ActionGroup/AdminOpenAdminThreeDSecurePageActionGroup.xml b/...ento/CardinalCommerce/Test/Mftf/ActionGroup/AdminOpenAdminThreeDSecurePageActionGroup.xml
@@ -0,0 +1,19 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ /**
+  * Copyright © Magento, Inc. All rights reserved.
+  * See COPYING.txt for license details.
+  */
+-->
+
+<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+              xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
+    <actionGroup name="AdminOpenAdminThreeDSecurePageActionGroup">
+        <annotations>
+            <description>Open ThreeDSecure page.</description>
+        </annotations>
+
+        <amOnPage url="{{AdminThreeDSecurePage.url}}" stepKey="openAdminThreeDSecurePage"/>
+        <waitForPageLoad stepKey="waitThreeDSecurePageToLoad"/>
+    </actionGroup>
+</actionGroups>