Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#25192 fixed #25244

Merged
merged 4 commits into from Sep 4, 2020
Merged

#25192 fixed #25244

merged 4 commits into from Sep 4, 2020

Conversation

ghost
Copy link

@ghost ghost commented Oct 23, 2019 •
edited by VladimirZaets
Loading

Description (*)

Fixed Issues (if relevant)

  1. DHL Shipping #25192: DHL Shipping

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@ghost ghost requested a review from YevSent as a code owner October 23, 2019 13:36
@m2-assistant
Copy link

m2-assistant bot commented Oct 23, 2019

Hi @vishalverma279. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@VladimirZaets
Copy link
Contributor

Hi @vishalverma279.
Thanks for collaboration.
The processing of this PR will be after the issue will be confirmed.

@VladimirZaets VladimirZaets self-assigned this Oct 23, 2019
@sidolov sidolov changed the base branch from 2.3-develop to 2.4-develop December 5, 2019 17:17
@ihor-sviziev
Copy link
Contributor

@magento run all tests

@ihor-sviziev
Copy link
Contributor

Issue was already confirmed, removing "on hold" label

@lenaorobei
Copy link
Contributor

@magento run all tests

@sidolov sidolov added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Aug 18, 2020
sidolov
sidolov requested changes Aug 25, 2020
View reviewed changes
Copy link
Contributor

@sidolov sidolov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vishalverma279 please, cover changes with automated test

@ghost ghost assigned sidolov Aug 25, 2020
@engcom-Charlie engcom-Charlie self-assigned this Aug 26, 2020
@engcom-Charlie
Copy link
Contributor

Hi @sidolov, these changes was checked by unit test. With changes from PR test passed, without - failed(as expected).
If it's not enough what type of autotest would you suggest to cover this scenario?
Thank you.

@sidolov
Copy link
Contributor

sidolov commented Aug 26, 2020

@engcom-Charlie you are right, unit test should be enough for such minor changes.

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-8077 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Alfa engcom-Alfa self-assigned this Sep 1, 2020
@engcom-Alfa engcom-Alfa added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Sep 1, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Before: ✖️ The Domestic express isn't presented in Non Documents Allowed Methods

Screenshot from 2020-09-01 14-37-57

After: ✔️ The Domestic express is presented in Non Documents Allowed Methods

2020-09-01_14-58

@engcom-Alfa engcom-Alfa added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Sep 1, 2020
@magento-engcom-team magento-engcom-team mentioned this pull request Sep 4, 2020
Closed
@m2-assistant
Copy link

m2-assistant bot commented Sep 4, 2020

Hi @vishalverma279, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Sep 4, 2020
@gabrieldagama
ENGCOM-8077: #25192 fixed #25244
fb1c569
@magento-engcom-team magento-engcom-team merged commit b494f63 into magento:2.4-develop Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YevSent YevSent Awaiting requested review from YevSent

Assignees

@VladimirZaets VladimirZaets

@sidolov sidolov

@engcom-Alfa engcom-Alfa

@engcom-Charlie engcom-Charlie

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Dhl Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Squashtoberfest 2019
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@VladimirZaets @ihor-sviziev @lenaorobei @engcom-Charlie @sidolov @magento-engcom-team @engcom-Alfa