Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DHL Shipping #25192

Closed
insaurabh opened this issue Oct 21, 2019 · 15 comments
Closed

DHL Shipping #25192

insaurabh opened this issue Oct 21, 2019 · 15 comments
Labels
Component: Shipping Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Triage: Done Has been reviewed and prioritized during Triage with Product Managers

Comments

@insaurabh
Copy link

insaurabh commented Oct 21, 2019 •
edited by engcom-Charlie
Loading

Preconditions (*)

Magento (Open Source) 2.2.4 & 2.3.x
PHP 7.1.32
MySQL 5.7.15

Summary of the issue
In Non-Document, we don't get the desired Allowed Methods:

Steps to reproduce (*)

Content-type in the setting of DHL have two options

  • Document
  • Non-Document
    But while we make a selection of Document we get the desired Allowed methods:

Expected result (*)

image

Actual result (*)

Screenshot_2

but in case of Non-Document, we don't get the desired Allowed Methods:

Screenshot_3

I had a word with the DHL team and they said these settings are incorrect. We should be able to get the delivery type options of Document in Non-Document as well.
@m2-assistant
Copy link

m2-assistant bot commented Oct 21, 2019

Hi @maddyboy. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@maddyboy do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Oct 21, 2019
@insaurabh
Copy link
Author

@magento give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @maddyboy. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @maddyboy, here is your Magento instance.
Admin access: https://i-25192-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@engcom-Charlie engcom-Charlie self-assigned this Oct 22, 2019
@m2-assistant
Copy link

m2-assistant bot commented Oct 22, 2019

Hi @engcom-Charlie. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Charlie
Copy link
Contributor

Hello @maddyboy
Could you explain what do you want to see in Non-Document Allowed Methods section?
And could you give me any links that confirm this information?

@insaurabh
Copy link
Author

Hey @engcom-Charlie
I would like to have the option of normal Domestic Express in Non-Document panel. As the one we've is restricted till the delivery of 12 PM due to which it's charging more cost from the client.

I had a word with DHL about this and they've mentioned this specifically.

Screenshot_4

@ghost
Copy link

ghost commented Oct 23, 2019

@maddyboy will adding the mentioned option of Domestic Express in Non-Document panel will resolve this issue?

@ghost ghost self-assigned this Oct 23, 2019
@m2-assistant
Copy link

m2-assistant bot commented Oct 23, 2019

Hi @vishalverma279. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

@insaurabh
Copy link
Author

@vishalverma279 Yeah, that would resolve the issue. Possible to share some timeframe over this?

@ghost
Copy link

ghost commented Oct 23, 2019

@maddyboy will this work:
image

@insaurabh
Copy link
Author

Yeah, that should work, @vishalverma279

@ghost ghost mentioned this issue Oct 23, 2019
Merged
4 tasks
@ghost ghost unassigned engcom-Charlie Nov 16, 2019
@insaurabh
Copy link
Author

#25872

@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Dec 2, 2019
@engcom-Charlie engcom-Charlie self-assigned this Dec 2, 2019
@engcom-Charlie engcom-Charlie added Component: Shipping Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release and removed Progress: needs update labels Dec 2, 2019
@ghost ghost unassigned engcom-Charlie Dec 2, 2019
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Dec 2, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Charlie
Thank you for verifying the issue. Based on the provided information internal tickets MC-29295 were created

Issue Available: @engcom-Charlie, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

vrajesh-patel1993 added a commit to vrajesh-patel1993/magento2 that referenced this issue Feb 29, 2020
@vrajesh-patel1993
Fixed DHL shipping magento#25192
e4a2eeb
@vrajesh-patel1993 vrajesh-patel1993 mentioned this issue Feb 29, 2020
Closed
@magento-engcom-team magento-engcom-team added the Triage: Done Has been reviewed and prioritized during Triage with Product Managers label Jul 22, 2020
@ghost ghost added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Aug 18, 2020
@magento-engcom-team
Copy link
Contributor

Hi @insaurabh. Thank you for your report.
The issue has been fixed in #25244 by @vishalverma279 in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.2 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Sep 4, 2020
magento-engcom-team added a commit that referenced this issue Sep 4, 2020
@magento-engcom-team
ENGCOM-8077: #25192 fixed #25244
b494f63 
 - Merge Pull Request #25244 from vishalverma279/magento2:25192fixed
 - Merged commits:
   1. 4ac223b
   2. a220df1
   3. ab97e97
   4. cef3fe7
magento-engcom-team pushed a commit that referenced this issue Sep 4, 2020
@gabrieldagama
ENGCOM-8077: #25192 fixed #25244
fb1c569
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Shipping Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Triage: Done Has been reviewed and prioritized during Triage with Product Managers
Projects
High Priority Backlog
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sdzhepa @insaurabh @magento-engcom-team @engcom-Charlie