Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] Added missing aclResource attribute to Backend Header AdminNotification Toolbar Block #29067

Closed
4 tasks
m2-assistant bot opened this issue Jul 10, 2020 · 2 comments · Fixed by #28343
Closed
4 tasks

[Issue] Added missing aclResource attribute to Backend Header AdminNotification Toolbar Block #29067

m2-assistant bot opened this issue Jul 10, 2020 · 2 comments · Fixed by #28343
Labels
Component: Acl Component: AdminNotification Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Progress: ready for dev Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Triage: Done Has been reviewed and prioritized during Triage with Product Managers

Comments

@m2-assistant
Copy link

m2-assistant bot commented Jul 10, 2020 •
edited by engcom-Alfa
Loading

This issue is automatically created based on existing pull request: #28343: Added missing aclResource attribute to Backend Header AdminNotification Toolbar Block

Preconditions: (*)

Admin notification toolbar entry (bell) is visible despite admin user does not have role resource permissions to see it.

Steps to reproduce (*)

  1. Create Admin Role with Resource Access set to Custom;
  2. Edit Resources Tree so that System->Other Settings->Notifications->Show Toolbar is unchecked;

2020-07-10_10-19

  1. Save Role;
  2. Refresh caches and re-login;

Actual Result: ✖️ The admin notification bell icon is still visible

2020-07-10_10-14

Expected Result: ✔️ As admin user you should not see admin notifications bell icon

Screenshot from 2020-07-10 10-09-01

Questions or comments

n/a

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@denysbabenko denysbabenko mentioned this issue Jul 10, 2020
Merged
5 tasks
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Jul 10, 2020
@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Jul 16, 2020
@engcom-Alfa engcom-Alfa added Component: Acl Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Jul 16, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Alfa
Thank you for verifying the issue. Based on the provided information internal tickets MC-35917 were created

Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jul 16, 2020
@VladimirZaets VladimirZaets added Priority: P3 May be fixed according to the position in the backlog. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Jul 16, 2020
@sdzhepa sdzhepa added the Triage: Done Has been reviewed and prioritized during Triage with Product Managers label Jul 17, 2020
@engcom-Alfa engcom-Alfa removed the Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. label Jul 20, 2020
@magento-engcom-team
Copy link
Contributor

Hi @m2-assistant[bot]. Thank you for your report.
The issue has been fixed in #28343 by @denysbabenko in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.2 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Acl Component: AdminNotification Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Progress: ready for dev Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Triage: Done Has been reviewed and prioritized during Triage with Product Managers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added missing aclResource attribute to Backend Header AdminNotification Toolbar Block
4 participants
@sdzhepa @VladimirZaets @magento-engcom-team @engcom-Alfa