Improve performance of "in" condition on some version of MySQl

[kandy]

Improve performance of "in" condition on some version of MySql

Description (*)

Related Pull Requests

Workaround https://jira.mariadb.org/browse/MDEV-20900

Fixed Issues (if relevant)

1. Fixes Catalog Category Indexing takes very long on MariaDB 10.3 with many products #25199 :Catalog Category Indexing takes very long on MariaDB 10.3 with many products

Manual testing scenarios (*)

see #25199

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @kandy. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[ihor-sviziev]

Hi @kandy,
Your changes looks good, except one small missing space.
Due to definition of done all changes should be covered with some tests. Could you cover your changes with any type of test?

[ihor-sviziev]

@kandy I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

[m2-assistant]

Hi @kandy, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7542 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

Preconditions:

Magento 2.4-develop
MariaDB v.10.3.18

Manual testing scenario:

1. Change value for simple products to 50000 for example (setup/performance-toolkit/profiles/ce/small.xml);
2. Run in console: bin/magento setup:perf:generate-fixtures /var/www/html/magento24/setup/performance-toolkit/profiles/ce/small.xml for example

Before: ✖️ Indexation works very slow, freezes and does not pass...

After: ✔️ Catalog Category Indexing run quickly. For 50,000 products, it took about 3 minutes.

and all products were successfully indexed in about 2 minutes

[gabrieldagama]

@magento run all tests

[m2-assistant]

Hi @kandy, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[ihor-sviziev]

Finally it got merged! 🎉

[Quazz]

Glad to see this get merged!

I found 2 more instances of this in the catalog_url_rewrite module. I think the reason it wasn't in this PR is because it doesn't go through the DB/Select but instead it is about creating a temporary table.

https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/CatalogUrlRewrite/Model/Map/DataCategoryUrlRewriteDatabaseMap.php#L91

That one especially can take a long time to get it done.

Here's the other one:
https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/CatalogUrlRewrite/Model/Map/DataProductUrlRewriteDatabaseMap.php#L104

It can be wrapped in an array_map('intval', array_merge(...)) in order to force the productids to come through as INT. There is no option to pass type along, therefore it must be forced into the Query instead.

[ihor-sviziev]

@Quazz feel free to create PR with your suggested changes