Introduce kludge to make "isEnabledForCluster" work again for kube object details PART 6 #5805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Nokel81
reviewed
Jul 7, 2022
.../kube-object-details/kube-object-detail-items/kube-object-matches-to-kind-and-api-version.ts
Outdated
Show resolved
Hide resolved
Nokel81
approved these changes
Jul 7, 2022
...be-object-detail-items/implementations/custom-resource-definitions-detail-item.injectable.ts
Show resolved
Hide resolved
...object-details/kube-object-detail-items/implementations/kube-event-detail-item.injectable.ts
Outdated
Show resolved
Hide resolved
| import type React from "react"; | ||
|
|
||
| export interface KubeObjectDetailItem { | ||
| Component: React.ElementType<KubeObjectDetailsProps<any>>; |
There was a problem hiding this comment.
Same comment as from a previous PR about KubeObject
7a2ab23 to
d2eb445
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
8e9d5cb to
c071fb1
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
d2eb445 to
b747cce
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
c071fb1 to
591f8ed
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
591f8ed to
9a90c19
Compare
b747cce to
e745ab0
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
9a90c19 to
944c4be
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
e745ab0 to
e458ded
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
944c4be to
98560a3
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
e458ded to
3011d92
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
98560a3 to
830d183
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
830d183 to
78a6e8d
Compare
jim-docker
pushed a commit
that referenced
this pull request
Jul 12, 2022
…d overview details PART 5 (#5804) * Kludge "isEnabledForCluster" work again for cluster page menus (sidebar items) Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Kludge "isEnabledForCluster" work again for kube object status texts Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Kludge "isEnabledForCluster" work again for kube object menu items Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Kludge "isEnabledForCluster" work again for workload overview details Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Kludge "isEnabledForCluster" work again for kube object details (#5805) Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
jansav
added a commit
that referenced
this pull request
Jul 13, 2022
… pages PART 1 (#5800) * Kludge "isEnabledForCluster" work again for cluster pages Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Introduce kludge to make "isEnabledForCluster" work again for cluster page menus PART 2 (#5801) * Kludge "isEnabledForCluster" work again for cluster page menus (sidebar items) Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Introduce kludge to make "isEnabledForCluster" work again for kube object status texts PART 3 (#5802) * Kludge "isEnabledForCluster" work again for kube object status texts Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Kludge "isEnabledForCluster" work again for kube object menu items (#5803) Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Introduce kludge to make "isEnabledForCluster" work again for workload overview details PART 5 (#5804) * Kludge "isEnabledForCluster" work again for cluster page menus (sidebar items) Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Kludge "isEnabledForCluster" work again for kube object status texts Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Kludge "isEnabledForCluster" work again for kube object menu items Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Kludge "isEnabledForCluster" work again for workload overview details Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Kludge "isEnabledForCluster" work again for kube object details (#5805) Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 6 of #5800
In this PR, we replace
KubeObjectDetailsRegistrywith new alternative which works properly withisEnabledForCluster.Signed-off-by: Janne Savolainen janne.savolainen@live.fi
Closes #4632