Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce kludge to make "isEnabledForCluster" work again for kube object status texts PART 3 #5802

Merged
merged 2 commits into from
Jul 12, 2022
Merged

Introduce kludge to make "isEnabledForCluster" work again for kube object status texts PART 3 #5802

merged 2 commits into from
Jul 12, 2022

Conversation

jansav
Copy link
Contributor

@jansav jansav commented Jul 7, 2022

Part 3 of #5800

Signed-off-by: Janne Savolainen janne.savolainen@live.fi

@jansav jansav added the bug Something isn't working label Jul 7, 2022
@jansav jansav added this to the 5.6.0 milestone Jul 7, 2022
@jansav jansav requested a review from a team as a code owner July 7, 2022 10:02
@jansav jansav requested review from jweak and JAtula and removed request for a team July 7, 2022 10:02
@jansav jansav changed the title Kludge "isEnabledForCluster" work again for kube object status texts PART 3 Introduce kludge to make "isEnabledForCluster" work again for kube object status texts PART 3 Jul 7, 2022
@jansav jansav mentioned this pull request Jul 7, 2022
Closed
7 tasks
@jansav jansav force-pushed the fix/is-enabled-for-cluster-part-2 branch from 3759636 to 77940b7 Compare July 11, 2022 05:37
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@jansav jansav force-pushed the fix/is-enabled-for-cluster-part-3 branch from af755dc to 6fedc5e Compare July 11, 2022 05:38
@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@jansav jansav force-pushed the fix/is-enabled-for-cluster-part-2 branch from 77940b7 to 0fa7bef Compare July 11, 2022 05:46
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@jansav jansav force-pushed the fix/is-enabled-for-cluster-part-3 branch from 6fedc5e to c13c0e1 Compare July 11, 2022 05:47
@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@jansav jansav force-pushed the fix/is-enabled-for-cluster-part-2 branch from 0fa7bef to e30c960 Compare July 11, 2022 06:58
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@jansav jansav force-pushed the fix/is-enabled-for-cluster-part-3 branch from c13c0e1 to 392b2ef Compare July 11, 2022 06:59
@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@jansav jansav force-pushed the fix/is-enabled-for-cluster-part-2 branch from e30c960 to 08ff251 Compare July 12, 2022 05:38
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@jansav jansav force-pushed the fix/is-enabled-for-cluster-part-3 branch from 392b2ef to a5216e0 Compare July 12, 2022 05:41
@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@jansav jansav force-pushed the fix/is-enabled-for-cluster-part-2 branch from 08ff251 to 5460583 Compare July 12, 2022 05:48
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@jansav jansav force-pushed the fix/is-enabled-for-cluster-part-3 branch from a5216e0 to b5b38a0 Compare July 12, 2022 05:49
@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@jansav jansav force-pushed the fix/is-enabled-for-cluster-part-2 branch from 5460583 to d091f47 Compare July 12, 2022 06:35
@jansav
Kludge "isEnabledForCluster" work again for kube object status texts
6de388a 
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
@jansav jansav force-pushed the fix/is-enabled-for-cluster-part-3 branch from b5b38a0 to 6de388a Compare July 12, 2022 06:35
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@jansav
Kludge "isEnabledForCluster" work again for kube object menu items (#…
7656c65 
…5803)

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
@jim-docker jim-docker merged commit a173915 into fix/is-enabled-for-cluster-part-2 Jul 12, 2022
@jim-docker jim-docker deleted the fix/is-enabled-for-cluster-part-3 branch July 12, 2022 18:26
jim-docker pushed a commit that referenced this pull request Jul 12, 2022
@jansav
Introduce kludge to make "isEnabledForCluster" work again for cluster…
3ec6113 
… page menus PART 2 (#5801)

* Kludge "isEnabledForCluster" work again for cluster page menus (sidebar items)

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Introduce kludge to make "isEnabledForCluster" work again for kube object status texts PART 3 (#5802)

* Kludge "isEnabledForCluster" work again for kube object status texts

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Kludge "isEnabledForCluster" work again for kube object menu items (#5803)

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
jansav added a commit that referenced this pull request Jul 13, 2022
@jansav
Introduce kludge to make "isEnabledForCluster" work again for cluster…
ca40c51 
… pages PART 1 (#5800)

* Kludge "isEnabledForCluster" work again for cluster pages

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Introduce kludge to make "isEnabledForCluster" work again for cluster page menus  PART 2 (#5801)

* Kludge "isEnabledForCluster" work again for cluster page menus (sidebar items)

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Introduce kludge to make "isEnabledForCluster" work again for kube object status texts PART 3 (#5802)

* Kludge "isEnabledForCluster" work again for kube object status texts

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Kludge "isEnabledForCluster" work again for kube object menu items (#5803)

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Introduce kludge to make "isEnabledForCluster" work again for workload overview details PART 5 (#5804)

* Kludge "isEnabledForCluster" work again for cluster page menus (sidebar items)

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Kludge "isEnabledForCluster" work again for kube object status texts

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Kludge "isEnabledForCluster" work again for kube object menu items

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Kludge "isEnabledForCluster" work again for workload overview details

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Kludge "isEnabledForCluster" work again for kube object details (#5805)

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nokel81 Nokel81 Nokel81 approved these changes

@jweak jweak Awaiting requested review from jweak jweak was automatically assigned from lensapp/lens-ide

@JAtula JAtula Awaiting requested review from JAtula JAtula was automatically assigned from lensapp/lens-ide

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jansav @Nokel81 @jim-docker