Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce kludge to make "isEnabledForCluster" work again for workload overview details PART 5 #5804

Merged

Conversation

jansav
Copy link
Contributor

@jansav jansav commented Jul 7, 2022

Part 5 of #5800

Signed-off-by: Janne Savolainen janne.savolainen@live.fi

@jansav jansav added the bug Something isn't working label Jul 7, 2022
@jansav jansav added this to the 5.6.0 milestone Jul 7, 2022
@jansav jansav requested a review from a team as a code owner July 7, 2022 10:04
@jansav jansav requested review from nevalla and Iku-turso and removed request for a team July 7, 2022 10:04
@jansav jansav changed the title Kludge "isEnabledForCluster" work again for workload overview details PART 5 Introduce kludge to make "isEnabledForCluster" work again for workload overview details PART 5 Jul 7, 2022
@jansav jansav force-pushed the fix/is-enabled-for-cluster-part-4 branch from cf0634f to baff648 Compare July 11, 2022 05:43
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@jansav jansav force-pushed the fix/is-enabled-for-cluster-part-4 branch from baff648 to 4355f2a Compare July 11, 2022 05:48
@jansav jansav force-pushed the fix/is-enabled-for-cluster-part-5 branch from 7a2ab23 to d2eb445 Compare July 11, 2022 06:48
@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@jansav jansav force-pushed the fix/is-enabled-for-cluster-part-4 branch from 4355f2a to 6d0bda5 Compare July 11, 2022 06:59
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@jansav jansav force-pushed the fix/is-enabled-for-cluster-part-5 branch from d2eb445 to b747cce Compare July 11, 2022 07:00
@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@jansav jansav force-pushed the fix/is-enabled-for-cluster-part-4 branch from 6d0bda5 to e3d4a77 Compare July 12, 2022 05:42
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@jansav jansav force-pushed the fix/is-enabled-for-cluster-part-5 branch from b747cce to e745ab0 Compare July 12, 2022 05:43
@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@jansav jansav force-pushed the fix/is-enabled-for-cluster-part-4 branch from e3d4a77 to fb71ebc Compare July 12, 2022 05:49
@jansav jansav force-pushed the fix/is-enabled-for-cluster-part-5 branch from e745ab0 to e458ded Compare July 12, 2022 05:49
jansav added 3 commits July 12, 2022 09:35
…ar items)

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
@jansav jansav force-pushed the fix/is-enabled-for-cluster-part-4 branch from fb71ebc to 103dbb4 Compare July 12, 2022 06:35
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
@jansav jansav force-pushed the fix/is-enabled-for-cluster-part-5 branch from e458ded to 3011d92 Compare July 12, 2022 06:36
Base automatically changed from fix/is-enabled-for-cluster-part-4 to fix/is-enabled-for-cluster-part-3 July 12, 2022 18:26
Base automatically changed from fix/is-enabled-for-cluster-part-3 to fix/is-enabled-for-cluster-part-2 July 12, 2022 18:26
Base automatically changed from fix/is-enabled-for-cluster-part-2 to fix/is-enabled-for-cluster-part-1 July 12, 2022 18:27
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
@jim-docker jim-docker merged commit a09a919 into fix/is-enabled-for-cluster-part-1 Jul 12, 2022
@jim-docker jim-docker deleted the fix/is-enabled-for-cluster-part-5 branch July 12, 2022 19:15
jansav added a commit that referenced this pull request Jul 13, 2022
… pages PART 1 (#5800)

* Kludge "isEnabledForCluster" work again for cluster pages

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Introduce kludge to make "isEnabledForCluster" work again for cluster page menus  PART 2 (#5801)

* Kludge "isEnabledForCluster" work again for cluster page menus (sidebar items)

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Introduce kludge to make "isEnabledForCluster" work again for kube object status texts PART 3 (#5802)

* Kludge "isEnabledForCluster" work again for kube object status texts

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Kludge "isEnabledForCluster" work again for kube object menu items (#5803)

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Introduce kludge to make "isEnabledForCluster" work again for workload overview details PART 5 (#5804)

* Kludge "isEnabledForCluster" work again for cluster page menus (sidebar items)

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Kludge "isEnabledForCluster" work again for kube object status texts

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Kludge "isEnabledForCluster" work again for kube object menu items

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Kludge "isEnabledForCluster" work again for workload overview details

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Kludge "isEnabledForCluster" work again for kube object details (#5805)

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants