Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension API fails to respect isEnabledForCluster #5786

Closed
6 of 7 tasks
Nokel81 opened this issue Jul 5, 2022 · 0 comments · Fixed by #5824
Closed
6 of 7 tasks

Extension API fails to respect isEnabledForCluster #5786

Nokel81 opened this issue Jul 5, 2022 · 0 comments · Fixed by #5824
Assignees
Labels
area/extension Something to related to the extension api blocker bug Something isn't working
Milestone

Comments

@Nokel81
Copy link
Collaborator

Nokel81 commented Jul 5, 2022

Because of the changes being made to ExtensionLoader the isEnabledForCluster() method on extensions is not being respected for most registrators. This means that even if that method is return false an extension's clusterPages, clusterPageMenus, etc... will still be shown.

Affects at least 5.5 and master, probably also some of 5.4.

Should not be referenced for the following (since these are only used in the root frame):

  • entitySettings
  • globalPages
  • catalogEntityDetailItems
  • appPreferences
  • appPreferenceTabs
  • statusBarItems
  • commands (but should be called for commands in the cluster frame)
  • welcomeMenus
  • welcomeBanners
  • topBarItems
  • additionalCategoryColumns
  • customCategoryViews

Should be references for the following:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/extension Something to related to the extension api blocker bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants