Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isEnabledForCluster is not respected for kubeObjectHandlers in Extension API #5830

Open
Tracked by #5786
jansav opened this issue Jul 13, 2022 · 0 comments
Open
Tracked by #5786
Labels
area/extension Something to related to the extension api bug Something isn't working

Comments

@jansav
Copy link
Contributor

jansav commented Jul 13, 2022

Left-over from #5786, since we decided not to treat this as blocker.

kubeObjectHandlers is way too complicated API for the job that it is doing, so better alternative is to simplify the API.

We should refactor remove and edit menu items to be as any other kubeObjectMenuItem. After that we can just introduce enabled computed for those which utilizes currentKubeObject and checks whether it is removable or editable. By doing that extension have a way to remove them by making kubeObject it introduced non removable or editable.

@jansav jansav changed the title kubeObjectHandlers isEnabledForCluster is not respected for kubeObjectHandlers in Extension API Jul 13, 2022
@jansav jansav added the bug Something isn't working label Jul 13, 2022
@Nokel81 Nokel81 added the area/extension Something to related to the extension api label Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/extension Something to related to the extension api bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants