Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce kludge to make "isEnabledForCluster" work again for cluster page menus PART 2 #5801

Merged

Conversation

jansav
Copy link
Contributor

@jansav jansav commented Jul 7, 2022

Part 2 of #5800.

Signed-off-by: Janne Savolainen janne.savolainen@live.fi

@jansav jansav added the bug Something isn't working label Jul 7, 2022
@jansav jansav added this to the 5.6.0 milestone Jul 7, 2022
@jansav jansav requested a review from a team as a code owner July 7, 2022 10:01
@jansav jansav requested review from lounjukk and DmitriyNoa and removed request for a team July 7, 2022 10:01
@jansav jansav changed the title Kludge "isEnabledForCluster" work again for cluster page menus PART 2 Introduce kludge to make "isEnabledForCluster" work again for cluster page menus PART 2 Jul 7, 2022
@jansav jansav force-pushed the fix/is-enabled-for-cluster-part-1 branch from 2010df9 to a9fe67b Compare July 11, 2022 05:36
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@jansav jansav force-pushed the fix/is-enabled-for-cluster-part-2 branch from 3759636 to 77940b7 Compare July 11, 2022 05:37
@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@jansav jansav force-pushed the fix/is-enabled-for-cluster-part-1 branch from a9fe67b to 17c3f01 Compare July 11, 2022 05:46
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@jansav jansav force-pushed the fix/is-enabled-for-cluster-part-2 branch from 77940b7 to 0fa7bef Compare July 11, 2022 05:46
@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@jansav jansav force-pushed the fix/is-enabled-for-cluster-part-1 branch from 17c3f01 to 284feac Compare July 11, 2022 06:57
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@jansav jansav force-pushed the fix/is-enabled-for-cluster-part-2 branch from 0fa7bef to e30c960 Compare July 11, 2022 06:58
@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@jansav jansav force-pushed the fix/is-enabled-for-cluster-part-2 branch from e30c960 to 08ff251 Compare July 12, 2022 05:38
@jansav jansav force-pushed the fix/is-enabled-for-cluster-part-1 branch from 284feac to 497ccdf Compare July 12, 2022 05:46
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@jansav jansav force-pushed the fix/is-enabled-for-cluster-part-2 branch from 08ff251 to 5460583 Compare July 12, 2022 05:48
@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@jansav jansav force-pushed the fix/is-enabled-for-cluster-part-1 branch from 497ccdf to fb6ad38 Compare July 12, 2022 06:35
…ar items)

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
@jansav jansav force-pushed the fix/is-enabled-for-cluster-part-2 branch from 5460583 to d091f47 Compare July 12, 2022 06:35
…ject status texts PART 3 (#5802)

* Kludge "isEnabledForCluster" work again for kube object status texts

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Kludge "isEnabledForCluster" work again for kube object menu items (#5803)

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
@jim-docker jim-docker merged commit 3ec6113 into fix/is-enabled-for-cluster-part-1 Jul 12, 2022
@jim-docker jim-docker deleted the fix/is-enabled-for-cluster-part-2 branch July 12, 2022 18:27
jansav added a commit that referenced this pull request Jul 13, 2022
… pages PART 1 (#5800)

* Kludge "isEnabledForCluster" work again for cluster pages

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Introduce kludge to make "isEnabledForCluster" work again for cluster page menus  PART 2 (#5801)

* Kludge "isEnabledForCluster" work again for cluster page menus (sidebar items)

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Introduce kludge to make "isEnabledForCluster" work again for kube object status texts PART 3 (#5802)

* Kludge "isEnabledForCluster" work again for kube object status texts

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Kludge "isEnabledForCluster" work again for kube object menu items (#5803)

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Introduce kludge to make "isEnabledForCluster" work again for workload overview details PART 5 (#5804)

* Kludge "isEnabledForCluster" work again for cluster page menus (sidebar items)

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Kludge "isEnabledForCluster" work again for kube object status texts

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Kludge "isEnabledForCluster" work again for kube object menu items

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Kludge "isEnabledForCluster" work again for workload overview details

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Kludge "isEnabledForCluster" work again for kube object details (#5805)

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants