Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

13 ➡️ main #1179

Merged
merged 52 commits into from
Oct 13, 2022
Merged

13 ➡️ main #1179

merged 52 commits into from
Oct 13, 2022

Conversation

azeey
Copy link
Collaborator

@azeey azeey commented Sep 29, 2022

➡️ Forward port

Port sdf13 to main

Branch comparison: main...sdf13

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

Pro and others added 30 commits July 27, 2022 13:08
* fix: Use PACKAGE_PREFIX_DIR to ensure relocatable CMake install for conan

Signed-off-by: Stefan Profanter <stefan.profanter@agile-robots.com>

* Compute relative path for pkgconfig folder.
  This accounts for arch-dependent lib folders.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Co-authored-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
HAVE_URDFDOM and USE_INTERNAL_URDF aren't
used in C++ code and should be removed.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
* Use `±inf` instead of `±1e16` for position limits
* Use `inf` instead of `-1` for effort, velocity limits

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
The urdf.sdf and collision_engine.sdf files are not
included by any other spec file, so they can be removed.

Fixes #635.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
When converting a fixed joint in a URDF file to SDFormat,
by default the contents of the child link are merged into
the parent link, but poses in gazebo extensions such as
//gazebo/sensor/pose are not properly transformed (#378).
This issue has already been fixed in newer branches by #525,
so the test and that fix have been backported and refactored to
reduce code duplication (about 30 lines removed from parser_urdf.cc)
and also fix the treatment of //gazebo/light/pose.

Fixes #378.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: marqrazz <marq.razz@gmail.com>
Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Co-authored-by: Steve Peters <scpeters@openrobotics.org>
This fixes an issue with linking to python libraries
on macOS.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
* camera.sdf: fields for projection matrix

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Update Changelog and Migration guide.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Adapting the code to the change in gazebosim/gz-math#503
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
* Change to sdformat13 module name for python

Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
* Update to 13.0.0~pre2

Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>

* Update Changelog

Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>

Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
The urdf_gazebo_extensions.urdf file had incorrect kinematics
with link3 being the child of two different joints.
This adds a link4 and replaces joint13 with joint14
connecting link1 and link4. This also fixes some
expectations about the implicit_spring_damper tags.

* parser_urdf: clean up internal functions by removing
unused parameters and making other parameters const.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>

Signed-off-by: Nate Koenig <nate@openrobotics.org>
Co-authored-by: Nate Koenig <nate@openrobotics.org>
These directories are added via our cmake macros and don't need to be
here. Additionally, one of the patterns was incorrect and adding a
relative path to the include dirs.

Signed-off-by: Michael Carroll <michael@openrobotics.org>
* Just disable the tests

Signed-off-by: Nate Koenig <nate@openrobotics.org>
Currently the location of some links and joints is lost
when fixed joints are reduced and links lumped together.
This adds //model/frame tags with the same name and
pose of the reduced links and joints.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@azeey azeey requested a review from scpeters as a code owner September 29, 2022 21:08
@scpeters
Copy link
Member

lots of python test failures

@azeey
Copy link
Collaborator Author

azeey commented Sep 30, 2022

lots of python test failures

Will need #1130 and #1180 first.

willstott101 and others added 10 commits September 29, 2022 21:58
* python: Don't import more than is used in the tests - should cause a failure due to gz.math not always being imported.
* python: Import gz.math at startup to fix #1129

Signed-off-by: Will Stott <willstott101@gmail.com>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
Follow-up for #1148 with a cleaner implementation for
the sdf13 branch that constructs sdf::Frame objects
and serializes them to a string rather than using
a stringstream to construct XML.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
Co-authored-by: Steve Peters <scpeters@openrobotics.org>
…cementPolicy::ERR (#1131)

Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
This adds an option for the SDF parser to attempt to resolve any URIs in the document via a user-provided callback.
This works similarly to how include/uri is resolved, but works for all uri elements.
A ParserConfig parameter is added to opt in to this behavior.
In the case that the user-provided callback cannot resolve the URI (returns an empty string), the original contents of the uri tag will be preserved.

Signed-off-by: Michael Carroll <michael@openrobotics.org>
…kages (#1180)

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #1179 (5ada88a) into main (3501e02) will increase coverage by 0.38%.
The diff coverage is 98.05%.

@@            Coverage Diff             @@
##             main    #1179      +/-   ##
==========================================
+ Coverage   86.71%   87.10%   +0.38%     
==========================================
  Files         125      125              
  Lines       15964    16027      +63     
==========================================
+ Hits        13843    13960     +117     
+ Misses       2121     2067      -54     
Impacted Files Coverage Δ
src/parser_urdf.cc 87.79% <92.98%> (+2.82%) ⬆️
include/sdf/Param.hh 80.72% <100.00%> (ø)
python/src/sdf/_gz_sdformat_pybind11.cc 100.00% <100.00%> (ø)
src/Camera.cc 89.03% <100.00%> (+1.24%) ⬆️
src/Collision.cc 97.26% <100.00%> (+0.11%) ⬆️
src/Geometry.cc 100.00% <100.00%> (ø)
src/Heightmap.cc 100.00% <100.00%> (ø)
src/JointAxis.cc 96.20% <100.00%> (+0.68%) ⬆️
src/Link.cc 97.99% <100.00%> (+0.01%) ⬆️
src/Material.cc 95.37% <100.00%> (+0.04%) ⬆️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Prepare for sdfromat13 13.1.0 release.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Co-authored-by: Steve Peters <scpeters@openrobotics.org>
@mjcarroll
Copy link
Contributor

mjcarroll commented Oct 13, 2022

May be worth doing one more pull now that 13 has a 13.1.0 release.

Signed-off-by: Michael Carroll <michael@openrobotics.org>
@azeey azeey merged commit 94cdc7d into main Oct 13, 2022
@azeey azeey deleted the azeey/13_to_main branch October 13, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

10 participants