Merge sdf9 ➡️ sdf12 #1167
Merged
Merge sdf9 ➡️ sdf12 #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
The urdf_gazebo_extensions.urdf file had incorrect kinematics with link3 being the child of two different joints. This adds a link4 and replaces joint13 with joint14 connecting link1 and link4. This also fixes some expectations about the implicit_spring_damper tags. * parser_urdf: clean up internal functions by removing unused parameters and making other parameters const. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
azeey
approved these changes
Sep 21, 2022
Codecov Report
@@ Coverage Diff @@
## sdf12 #1167 +/- ##
==========================================
- Coverage 91.69% 91.69% -0.01%
==========================================
Files 80 80
Lines 13083 13079 -4
==========================================
- Hits 11997 11993 -4
Misses 1086 1086
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port
sdf9➡️sdf12Branch comparision: sdf12...sdf9
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)